* [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs
@ 2022-09-06 9:35 Xiu Jianfeng
2022-09-07 1:59 ` Miaohe Lin
2022-09-08 5:15 ` HORIGUCHI NAOYA(堀口 直也)
0 siblings, 2 replies; 3+ messages in thread
From: Xiu Jianfeng @ 2022-09-06 9:35 UTC (permalink / raw)
To: naoya.horiguchi, linmiaohe, akpm; +Cc: linux-mm, linux-kernel
Add missing __init/__exit annotations to module init/exit funcs.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
mm/hwpoison-inject.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
index 65e242b5a432..d0548e382b6b 100644
--- a/mm/hwpoison-inject.c
+++ b/mm/hwpoison-inject.c
@@ -63,13 +63,13 @@ static int hwpoison_unpoison(void *data, u64 val)
DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
-static void pfn_inject_exit(void)
+static void __exit pfn_inject_exit(void)
{
hwpoison_filter_enable = 0;
debugfs_remove_recursive(hwpoison_dir);
}
-static int pfn_inject_init(void)
+static int __init pfn_inject_init(void)
{
hwpoison_dir = debugfs_create_dir("hwpoison", NULL);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs
2022-09-06 9:35 [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs Xiu Jianfeng
@ 2022-09-07 1:59 ` Miaohe Lin
2022-09-08 5:15 ` HORIGUCHI NAOYA(堀口 直也)
1 sibling, 0 replies; 3+ messages in thread
From: Miaohe Lin @ 2022-09-07 1:59 UTC (permalink / raw)
To: Xiu Jianfeng; +Cc: linux-mm, linux-kernel, naoya.horiguchi, akpm
On 2022/9/6 17:35, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
LGTM. Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks,
Miaohe Lin
> ---
> mm/hwpoison-inject.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index 65e242b5a432..d0548e382b6b 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -63,13 +63,13 @@ static int hwpoison_unpoison(void *data, u64 val)
> DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
> DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
>
> -static void pfn_inject_exit(void)
> +static void __exit pfn_inject_exit(void)
> {
> hwpoison_filter_enable = 0;
> debugfs_remove_recursive(hwpoison_dir);
> }
>
> -static int pfn_inject_init(void)
> +static int __init pfn_inject_init(void)
> {
> hwpoison_dir = debugfs_create_dir("hwpoison", NULL);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs
2022-09-06 9:35 [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs Xiu Jianfeng
2022-09-07 1:59 ` Miaohe Lin
@ 2022-09-08 5:15 ` HORIGUCHI NAOYA(堀口 直也)
1 sibling, 0 replies; 3+ messages in thread
From: HORIGUCHI NAOYA(堀口 直也) @ 2022-09-08 5:15 UTC (permalink / raw)
To: Xiu Jianfeng; +Cc: linmiaohe, akpm, linux-mm, linux-kernel
On Tue, Sep 06, 2022 at 05:35:30PM +0800, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Thank you.
- Naoya Horiguchi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-08 5:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-06 9:35 [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs Xiu Jianfeng
2022-09-07 1:59 ` Miaohe Lin
2022-09-08 5:15 ` HORIGUCHI NAOYA(堀口 直也)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).