* [PATCH v2] mm/damon/vaddr: add a comment for 'default' case in damon_va_apply_scheme()
@ 2022-09-08 3:13 xiakaixu1987
2022-09-08 18:22 ` SeongJae Park
0 siblings, 1 reply; 2+ messages in thread
From: xiakaixu1987 @ 2022-09-08 3:13 UTC (permalink / raw)
To: sj, akpm; +Cc: damon, linux-mm, linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The switch case 'DAMOS_STAT' and switch case 'default' have same
return value in damon_va_apply_scheme(), and the 'default' case
is for DAMOS actions that not supported by 'vaddr'. It might
make sense to add a comment here.
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
mm/damon/vaddr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
index 3c7b9d6dca95..3814200e61e4 100644
--- a/mm/damon/vaddr.c
+++ b/mm/damon/vaddr.c
@@ -646,6 +646,9 @@ static unsigned long damon_va_apply_scheme(struct damon_ctx *ctx,
case DAMOS_STAT:
return 0;
default:
+ /*
+ * DAMOS actions that not yet supported by 'vaddr'.
+ */
return 0;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mm/damon/vaddr: add a comment for 'default' case in damon_va_apply_scheme()
2022-09-08 3:13 [PATCH v2] mm/damon/vaddr: add a comment for 'default' case in damon_va_apply_scheme() xiakaixu1987
@ 2022-09-08 18:22 ` SeongJae Park
0 siblings, 0 replies; 2+ messages in thread
From: SeongJae Park @ 2022-09-08 18:22 UTC (permalink / raw)
To: xiakaixu1987; +Cc: sj, akpm, damon, linux-mm, linux-kernel, Kaixu Xia
Hi Kaixu,
On Thu, 8 Sep 2022 11:13:17 +0800 xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The switch case 'DAMOS_STAT' and switch case 'default' have same
> return value in damon_va_apply_scheme(), and the 'default' case
> is for DAMOS actions that not supported by 'vaddr'. It might
> make sense to add a comment here.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
> ---
From next time, giving change log from previous versions of the patch here
would be a good practice:
https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format
Thanks,
SJ
> mm/damon/vaddr.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> index 3c7b9d6dca95..3814200e61e4 100644
> --- a/mm/damon/vaddr.c
> +++ b/mm/damon/vaddr.c
> @@ -646,6 +646,9 @@ static unsigned long damon_va_apply_scheme(struct damon_ctx *ctx,
> case DAMOS_STAT:
> return 0;
> default:
> + /*
> + * DAMOS actions that not yet supported by 'vaddr'.
> + */
> return 0;
> }
>
> --
> 2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-08 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-08 3:13 [PATCH v2] mm/damon/vaddr: add a comment for 'default' case in damon_va_apply_scheme() xiakaixu1987
2022-09-08 18:22 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).