From: Joe Perches <joe@perches.com>
To: Matthew Wilcox <willy@infradead.org>, Yafang Shao <laoar.shao@gmail.com>
Cc: andriy.shevchenko@linux.intel.com, david@redhat.com,
vbabka@suse.cz, linmiaohe@huawei.com, cl@linux.com,
penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, pmladek@suse.com,
rostedt@goodmis.org, sergey.senozhatsky@gmail.com,
linux@rasmusvillemoes.dk, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp
Date: Mon, 01 Feb 2021 10:51:03 -0800 [thread overview]
Message-ID: <9c475803276ea2b32cadc8f72d397c180475d0cc.camel@perches.com> (raw)
In-Reply-To: <20210201141505.GR308988@casper.infradead.org>
On Mon, 2021-02-01 at 14:15 +0000, Matthew Wilcox wrote:
> On Mon, Feb 01, 2021 at 07:56:10PM +0800, Yafang Shao wrote:
> > - Before the patch,
> > [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head)
> >
> > - After the patch,
> > [ 6871.296131] Slab 0x00000000c0e19a37 objects=33 used=3 fp=0x00000000c4902159 flags=0x17ffffc0010200(Node 0,Zone 2,Lastcpupid 0x1fffff,slab|head)
>
> I would suggest it will be easier to parse as:
>
> flags=0x17ffffc0010200(slab|head|node=0|zone=2|lastcpupid=0x1fffff)
>
> That should alleviate the concerns about debugfs format change -- we've
> never guaranteed that flag names won't change, and they now look enough
> like flags that parsers shouldn't fall over them.
Seems sensible and would make the generating code simpler too.
But is it worth the vsprintf code expansion for the 5 current uses?
mm/debug.c: pr_warn("%sflags: %#lx(%pGp)%s\n", type, head->flags, &head->flags,
mm/memory-failure.c: pr_info("soft offline: %#lx: %s migration failed %d, type %lx (%pGp)\n",
mm/memory-failure.c: pr_info("soft offline: %#lx: %s isolation failed, page count %d, type %lx (%pGp)\n",
mm/memory-failure.c: pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n",
mm/page_owner.c: "PFN %lu type %s Block %lu type %s Flags %#lx(%pGp)\n",
Wouldn't it be more sensible just to put this code in a new function
call in mm?
next prev parent reply other threads:[~2021-02-01 18:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 11:56 [PATCH v2 0/3] mm, vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-01 11:56 ` [PATCH v2 1/3] mm, slub: use pGp to print page flags Yafang Shao
2021-02-01 11:56 ` [PATCH v2 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-02-01 11:56 ` [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-01 13:05 ` Joe Perches
2021-02-01 13:27 ` Yafang Shao
2021-02-01 13:23 ` David Hildenbrand
2021-02-01 13:32 ` David Hildenbrand
2021-02-01 13:34 ` Andy Shevchenko
2021-02-01 13:52 ` Yafang Shao
2021-02-01 16:03 ` Andy Shevchenko
2021-02-01 13:27 ` Andy Shevchenko
2021-02-01 13:49 ` Yafang Shao
2021-02-01 16:16 ` Andy Shevchenko
2021-02-01 16:20 ` Andy Shevchenko
2021-02-02 13:25 ` Yafang Shao
2021-02-01 14:15 ` Matthew Wilcox
2021-02-01 14:44 ` Yafang Shao
2021-02-01 18:51 ` Joe Perches [this message]
2021-02-01 18:59 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c475803276ea2b32cadc8f72d397c180475d0cc.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=laoar.shao@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).