From: Yafang Shao <laoar.shao@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Miaohe Lin <linmiaohe@huawei.com>,
Christoph Lameter <cl@linux.com>,
penberg@kernel.org, David Rientjes <rientjes@google.com>,
iamjoonsoo.kim@lge.com,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp
Date: Mon, 1 Feb 2021 21:27:14 +0800 [thread overview]
Message-ID: <CALOAHbDz=BSuSrcxTTE9Xn+NTgi15jUDf9oW5VxUBDhr7dCzmA@mail.gmail.com> (raw)
In-Reply-To: <06481a01f551697d42c792506f3538d459ce8bdd.camel@perches.com>
On Mon, Feb 1, 2021 at 9:05 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2021-02-01 at 19:56 +0800, Yafang Shao wrote:
> > Currently the pGp only shows the names of page flags, rather than
> > the full information including section, node, zone, last cpupid and
> > kasan tag. While it is not easy to parse these information manually
> > because there're so many flavors. Let's interpret them in pGp as well.
> >
> > - Before the patch,
> > [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head)
> >
> > - After the patch,
> > [ 6871.296131] Slab 0x00000000c0e19a37 objects=33 used=3 fp=0x00000000c4902159 flags=0x17ffffc0010200(Node 0,Zone 2,Lastcpupid 0x1fffff,slab|head)
>
> While debugfs is not an ABI, this format is exported in debugfs to
> userspace via mm/page_owner.c read_page_owner/print_page_owner.
>
Right, the page_owner will be affected by this change.
> Does changing the output format matter to anyone?
>
The user tools which parse the page_owner may be affected.
If we don't want to affect the userspace tools, I think we can make a
little change in page_owner as follows,
unsigned long masked_flags = page->flags & (BIT(NR_PAGEFLAGS) - 1);
snprintf("..., %#lx(%pGp)\n", page->flags, &masked_flags);
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> []
> > +static
> > +char *format_page_flags(char *buf, char *end, unsigned long page_flags)
> > +{
> > + unsigned long flags = page_flags & ((1UL << NR_PAGEFLAGS) - 1);
> > + int size = ARRAY_SIZE(pfl);
>
> There's no real value in used-once variables.
>
> > + bool separator = false;
> > + int i;
> > +
> > + for (i = 0; i < size; i++) {
>
> Use ARRAY_SIZE here instead
>
Sure
> for (i = 0; i < ARRAY_SIZE(pfl); i++) {
>
> > + if (pfl[i].width == 0)
> > + continue;
> > +
> > + if (separator) {
> > + if (buf < end)
> > + *buf = ',';
> > + buf++;
> > + }
> > +
> > +
> > + buf = string(buf, end, pfl[i].name, *pfl[i].spec);
> > +
> > + buf = number(buf, end, (page_flags >> pfl[i].shift) & pfl[i].mask,
> > + *pfl[i].spec);
> > + separator = true;
> > + }
>
> Style question:
> Might this array be more intelligible with pointers instead of indexes?
Good suggestion!
I will change it in the next version.
> Something like:
>
> struct page_flags_layout *p;
>
> for (p = pfl; p < pfl + ARRAY_SIZE(pfl); p++) {
> if (p->width == 0)
> continue;
>
> if (p > pfl) {
> if (buf < end)
> *buf = ',';
> buf++;
> }
It doesn't work, because there's a 'continue' above, meaning that the
p may be greater than pfl without doing anything.
>
> buf = string(buf, end, p->name, *p->spec);
> buf = number(buf, end, (page_flags >> p->shift) & p->mask, *p->spec);
> }
>
> > +
> > + if (flags) {
>
> Maybe:
>
> if (page_flags & (BIT(NR_PAGEFLAGS) - 1)) {
>
Sure.
> > + if (buf < end)
> > + *buf = ',';
> > + buf++;
> > + }
> > +
> > + return buf;
> > +}
> > +
>
>
--
Thanks
Yafang
next prev parent reply other threads:[~2021-02-01 13:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 11:56 [PATCH v2 0/3] mm, vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-01 11:56 ` [PATCH v2 1/3] mm, slub: use pGp to print page flags Yafang Shao
2021-02-01 11:56 ` [PATCH v2 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-02-01 11:56 ` [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-01 13:05 ` Joe Perches
2021-02-01 13:27 ` Yafang Shao [this message]
2021-02-01 13:23 ` David Hildenbrand
2021-02-01 13:32 ` David Hildenbrand
2021-02-01 13:34 ` Andy Shevchenko
2021-02-01 13:52 ` Yafang Shao
2021-02-01 16:03 ` Andy Shevchenko
2021-02-01 13:27 ` Andy Shevchenko
2021-02-01 13:49 ` Yafang Shao
2021-02-01 16:16 ` Andy Shevchenko
2021-02-01 16:20 ` Andy Shevchenko
2021-02-02 13:25 ` Yafang Shao
2021-02-01 14:15 ` Matthew Wilcox
2021-02-01 14:44 ` Yafang Shao
2021-02-01 18:51 ` Joe Perches
2021-02-01 18:59 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbDz=BSuSrcxTTE9Xn+NTgi15jUDf9oW5VxUBDhr7dCzmA@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).