From: David Hildenbrand <david@redhat.com>
To: Yafang Shao <laoar.shao@gmail.com>,
andriy.shevchenko@linux.intel.com, vbabka@suse.cz,
linmiaohe@huawei.com, cl@linux.com, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org,
sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp
Date: Mon, 1 Feb 2021 14:32:13 +0100 [thread overview]
Message-ID: <a9790427-1028-6acc-18e6-aafc1a5eb29d@redhat.com> (raw)
In-Reply-To: <66784ea1-29c7-6bed-ca7f-cd3e7ea9155b@redhat.com>
On 01.02.21 14:23, David Hildenbrand wrote:
> On 01.02.21 12:56, Yafang Shao wrote:
>> Currently the pGp only shows the names of page flags, rather than
>> the full information including section, node, zone, last cpupid and
>> kasan tag. While it is not easy to parse these information manually
>> because there're so many flavors. Let's interpret them in pGp as well.
>>
>> - Before the patch,
>> [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head)
>>
>> - After the patch,
>> [ 6871.296131] Slab 0x00000000c0e19a37 objects=33 used=3 fp=0x00000000c4902159 flags=0x17ffffc0010200(Node 0,Zone 2,Lastcpupid 0x1fffff,slab|head)
>
> For debugging purposes, it might be helpful to have the actual zone name
> (and to know if the value is sane). You could obtain it (without other
> modifications) via
>
> const char zname = "Invalid";
>
> if (zone < MAX_NR_ZONES)
> zname = first_online_pgdat()->node_zones[zone].name;
>
>
> Similarly, it might also be helpful to indicate if a node is
> online/offline/invalid/.
>
> const char nstate = "Invalid";
>
> if (node_online(nid))
> nstate = "Online";
> else if (node_possible(nid))
> nstate = "Offline";
Just remembering that we have to take care of nid limits:
if (nid >= 0 && nid < MAX_NUMNODES) {
if (node_online(nid))
nstate = "Online";
else if (node_possible(nid))
nstate = "Offline";
}
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-02-01 13:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 11:56 [PATCH v2 0/3] mm, vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-01 11:56 ` [PATCH v2 1/3] mm, slub: use pGp to print page flags Yafang Shao
2021-02-01 11:56 ` [PATCH v2 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-02-01 11:56 ` [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp Yafang Shao
2021-02-01 13:05 ` Joe Perches
2021-02-01 13:27 ` Yafang Shao
2021-02-01 13:23 ` David Hildenbrand
2021-02-01 13:32 ` David Hildenbrand [this message]
2021-02-01 13:34 ` Andy Shevchenko
2021-02-01 13:52 ` Yafang Shao
2021-02-01 16:03 ` Andy Shevchenko
2021-02-01 13:27 ` Andy Shevchenko
2021-02-01 13:49 ` Yafang Shao
2021-02-01 16:16 ` Andy Shevchenko
2021-02-01 16:20 ` Andy Shevchenko
2021-02-02 13:25 ` Yafang Shao
2021-02-01 14:15 ` Matthew Wilcox
2021-02-01 14:44 ` Yafang Shao
2021-02-01 18:51 ` Joe Perches
2021-02-01 18:59 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9790427-1028-6acc-18e6-aafc1a5eb29d@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=laoar.shao@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).