From: Muchun Song <muchun.song@linux.dev>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
mike.kravetz@oracle.com, Muchun Song <songmuchun@bytedance.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] mm/hugetlb: fix WARN_ON(!kobj) in sysfs_create_group()
Date: Wed, 17 Aug 2022 10:31:07 +0800 [thread overview]
Message-ID: <AA374889-2C8B-4D8B-9542-A760267F00E4@linux.dev> (raw)
In-Reply-To: <20220816130553.31406-3-linmiaohe@huawei.com>
> On Aug 16, 2022, at 21:05, Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> If sysfs_create_group() fails with hstate_attr_group, hstate_kobjs[hi]
> will be set to NULL. Then it will be passed to sysfs_create_group() if
> h->demote_order != 0 thus triggering WARN_ON(!kobj) check. Fix this by
> making sure hstate_kobjs[hi] != NULL when calling sysfs_create_group.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
It’s better to add a Fixes tag here.
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
next prev parent reply other threads:[~2022-08-17 2:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 13:05 [PATCH 0/6] A few fixup patches for hugetlb Miaohe Lin
2022-08-16 13:05 ` [PATCH 1/6] mm/hugetlb: fix incorrect update of max_huge_pages Miaohe Lin
2022-08-16 22:52 ` Mike Kravetz
2022-08-16 23:20 ` Andrew Morton
2022-08-16 23:34 ` Mike Kravetz
2022-08-17 1:53 ` Miaohe Lin
2022-08-17 2:28 ` Muchun Song
2022-08-16 13:05 ` [PATCH 2/6] mm/hugetlb: fix WARN_ON(!kobj) in sysfs_create_group() Miaohe Lin
2022-08-16 22:55 ` Mike Kravetz
2022-08-17 2:31 ` Muchun Song [this message]
2022-08-17 2:39 ` Miaohe Lin
2022-08-16 13:05 ` [PATCH 3/6] mm/hugetlb: fix missing call to restore_reserve_on_error() Miaohe Lin
2022-08-16 23:31 ` Mike Kravetz
2022-08-17 1:59 ` Miaohe Lin
2022-08-16 13:05 ` [PATCH 4/6] mm: hugetlb_vmemmap: add missing smp_wmb() before set_pte_at() Miaohe Lin
2022-08-17 2:53 ` Muchun Song
2022-08-17 8:41 ` Miaohe Lin
2022-08-17 9:13 ` Yin, Fengwei
2022-08-17 11:21 ` Muchun Song
2022-08-18 1:14 ` Yin, Fengwei
2022-08-18 1:55 ` Miaohe Lin
2022-08-18 2:00 ` Yin, Fengwei
2022-08-18 2:47 ` Muchun Song
2022-08-18 7:52 ` Miaohe Lin
2022-08-18 7:59 ` Muchun Song
2022-08-18 8:32 ` Yin, Fengwei
2022-08-18 8:40 ` Muchun Song
2022-08-18 8:54 ` Yin, Fengwei
2022-08-18 9:18 ` Muchun Song
2022-08-18 12:58 ` Miaohe Lin
2022-08-18 23:53 ` Yin, Fengwei
2022-08-19 3:19 ` Muchun Song
2022-08-19 7:26 ` Miaohe Lin
2022-08-18 1:15 ` Yin, Fengwei
2022-08-20 8:12 ` Muchun Song
2022-08-22 8:45 ` Miaohe Lin
2022-08-22 10:23 ` Muchun Song
2022-08-23 1:42 ` Miaohe Lin
2022-08-16 13:05 ` [PATCH 5/6] mm/hugetlb: fix sysfs group leak in hugetlb_unregister_node() Miaohe Lin
2022-08-17 9:41 ` Yin, Fengwei
2022-08-18 1:00 ` Yin, Fengwei
2022-08-18 1:12 ` Yin, Fengwei
2022-08-16 13:05 ` [PATCH 6/6] mm/hugetlb: make detecting shared pte more reliable Miaohe Lin
2022-08-17 23:56 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AA374889-2C8B-4D8B-9542-A760267F00E4@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).