* [PATCH] mm: cma: Return cma->name directly in cma_get_name
@ 2020-06-23 1:58 Nathan Chancellor
2020-06-23 2:07 ` Song Bao Hua (Barry Song)
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2020-06-23 1:58 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-mm, linux-kernel, clang-built-linux, Barry Song, Nathan Chancellor
clang warns:
mm/cma.c:55:14: warning: address of array 'cma->name' will always
evaluate to 'true' [-Wpointer-bool-conversion]
return cma->name ? cma->name : "(undefined)";
~~~~~^~~~ ~
1 warning generated.
After commit e7f0557d7de9 ("mm: cma: fix the name of CMA areas"),
cma->name will be an array with some value worth printing so we do not
need to check for NULL.
Link: https://github.com/ClangBuiltLinux/linux/issues/1063
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
mm/cma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/cma.c b/mm/cma.c
index 31a61d410c59..6cf08817bac6 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -52,7 +52,7 @@ unsigned long cma_get_size(const struct cma *cma)
const char *cma_get_name(const struct cma *cma)
{
- return cma->name ? cma->name : "(undefined)";
+ return cma->name;
}
static unsigned long cma_bitmap_aligned_mask(const struct cma *cma,
base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] mm: cma: Return cma->name directly in cma_get_name
2020-06-23 1:58 [PATCH] mm: cma: Return cma->name directly in cma_get_name Nathan Chancellor
@ 2020-06-23 2:07 ` Song Bao Hua (Barry Song)
0 siblings, 0 replies; 2+ messages in thread
From: Song Bao Hua (Barry Song) @ 2020-06-23 2:07 UTC (permalink / raw)
To: Nathan Chancellor, Andrew Morton
Cc: linux-mm, linux-kernel, clang-built-linux
> -----Original Message-----
> From: Nathan Chancellor [mailto:natechancellor@gmail.com]
> Sent: Tuesday, June 23, 2020 1:59 PM
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org;
> clang-built-linux@googlegroups.com; Song Bao Hua (Barry Song)
> <song.bao.hua@hisilicon.com>; Nathan Chancellor
> <natechancellor@gmail.com>
> Subject: [PATCH] mm: cma: Return cma->name directly in cma_get_name
>
> clang warns:
>
> mm/cma.c:55:14: warning: address of array 'cma->name' will always
> evaluate to 'true' [-Wpointer-bool-conversion]
> return cma->name ? cma->name : "(undefined)";
> ~~~~~^~~~ ~
> 1 warning generated.
>
> After commit e7f0557d7de9 ("mm: cma: fix the name of CMA areas"),
> cma->name will be an array with some value worth printing so we do not
> need to check for NULL.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1063
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Thanks!
Acked-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
> mm/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 31a61d410c59..6cf08817bac6 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -52,7 +52,7 @@ unsigned long cma_get_size(const struct cma *cma)
>
> const char *cma_get_name(const struct cma *cma)
> {
> - return cma->name ? cma->name : "(undefined)";
> + return cma->name;
> }
>
> static unsigned long cma_bitmap_aligned_mask(const struct cma *cma,
>
> base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821
> --
> 2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-23 2:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 1:58 [PATCH] mm: cma: Return cma->name directly in cma_get_name Nathan Chancellor
2020-06-23 2:07 ` Song Bao Hua (Barry Song)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).