From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: "bvanassche@acm.org" <bvanassche@acm.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH 4/5] mm: update block_dump comment
Date: Mon, 8 Jul 2019 18:49:39 +0000 [thread overview]
Message-ID: <BYAPR04MB57491CF4972D9EBA8587A26586F60@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190701215726.27601-5-chaitanya.kulkarni@wdc.com
Can someone from linux-mm list please provide a feedback on this ?
On 07/01/2019 02:58 PM, Chaitanya Kulkarni wrote:
> With respect to the changes in the submit_bio() in the earlier patch
> now we report all the REQ_OP_XXX associated with bio along with
> REQ_OP_READ and REQ_OP_WRITE (READ/WRITE). Update the following
> comment for block_dump variable to reflect the change.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index bdbe8b6b1225..ef299f95349f 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -109,7 +109,7 @@ EXPORT_SYMBOL_GPL(dirty_writeback_interval);
> unsigned int dirty_expire_interval = 30 * 100; /* centiseconds */
>
> /*
> - * Flag that makes the machine dump writes/reads and block dirtyings.
> + * Flag that makes the machine dump block layer requests and block dirtyings.
> */
> int block_dump;
>
>
next prev parent reply other threads:[~2019-07-08 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 21:57 [PATCH 0/5] block: udpate debug messages with blk_op_str() Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 1/5] block: update error message for bio_check_ro() Chaitanya Kulkarni
2019-07-03 0:42 ` Minwoo Im
2019-07-03 2:24 ` Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 2/5] block: update error message in submit_bio() Chaitanya Kulkarni
2019-07-03 0:43 ` Minwoo Im
2019-07-01 21:57 ` [PATCH 3/5] block: allow block_dump to print all REQ_OP_XXX Chaitanya Kulkarni
2019-07-03 0:50 ` Minwoo Im
2019-07-03 2:26 ` Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 4/5] mm: update block_dump comment Chaitanya Kulkarni
2019-07-08 18:49 ` Chaitanya Kulkarni [this message]
2019-07-01 21:57 ` [PATCH 5/5] Documentation/laptop: add block_dump documentation Chaitanya Kulkarni
2019-07-08 18:49 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB57491CF4972D9EBA8587A26586F60@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).