From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: "bvanassche@acm.org" <bvanassche@acm.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH 5/5] Documentation/laptop: add block_dump documentation
Date: Mon, 8 Jul 2019 18:49:54 +0000 [thread overview]
Message-ID: <BYAPR04MB57493225F93F43B6271DCFDA86F60@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190701215726.27601-6-chaitanya.kulkarni@wdc.com
Can someone from linux-mm list please provide a feedback on this ?
On 07/01/2019 02:58 PM, Chaitanya Kulkarni wrote:
> This patch updates the block_dump documentation with respect to the
> changes from the earlier patch for submit_bio(). Also we adjust rest of
> the lines to fit with standaed format.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> Documentation/laptops/laptop-mode.txt | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/laptops/laptop-mode.txt b/Documentation/laptops/laptop-mode.txt
> index 1c707fc9b141..d4d72ed677c4 100644
> --- a/Documentation/laptops/laptop-mode.txt
> +++ b/Documentation/laptops/laptop-mode.txt
> @@ -101,14 +101,14 @@ a cache miss. The disk can then be spun down in the periods of inactivity.
>
> If you want to find out which process caused the disk to spin up, you can
> gather information by setting the flag /proc/sys/vm/block_dump. When this flag
> -is set, Linux reports all disk read and write operations that take place, and
> -all block dirtyings done to files. This makes it possible to debug why a disk
> -needs to spin up, and to increase battery life even more. The output of
> -block_dump is written to the kernel output, and it can be retrieved using
> -"dmesg". When you use block_dump and your kernel logging level also includes
> -kernel debugging messages, you probably want to turn off klogd, otherwise
> -the output of block_dump will be logged, causing disk activity that is not
> -normally there.
> +is set, Linux reports all disk I/O operations along with read and write
> +operations that take place, and all block dirtyings done to files. This makes
> +it possible to debug why a disk needs to spin up, and to increase battery life
> +even more. The output of block_dump is written to the kernel output, and it can
> +be retrieved using "dmesg". When you use block_dump and your kernel logging
> +level also includes kernel debugging messages, you probably want to turn off
> +klogd, otherwise the output of block_dump will be logged, causing disk activity
> +that is not normally there.
>
>
> Configuration
>
prev parent reply other threads:[~2019-07-08 18:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 21:57 [PATCH 0/5] block: udpate debug messages with blk_op_str() Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 1/5] block: update error message for bio_check_ro() Chaitanya Kulkarni
2019-07-03 0:42 ` Minwoo Im
2019-07-03 2:24 ` Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 2/5] block: update error message in submit_bio() Chaitanya Kulkarni
2019-07-03 0:43 ` Minwoo Im
2019-07-01 21:57 ` [PATCH 3/5] block: allow block_dump to print all REQ_OP_XXX Chaitanya Kulkarni
2019-07-03 0:50 ` Minwoo Im
2019-07-03 2:26 ` Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 4/5] mm: update block_dump comment Chaitanya Kulkarni
2019-07-08 18:49 ` Chaitanya Kulkarni
2019-07-01 21:57 ` [PATCH 5/5] Documentation/laptop: add block_dump documentation Chaitanya Kulkarni
2019-07-08 18:49 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB57493225F93F43B6271DCFDA86F60@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).