* [PATCH mmotm] sparc64: pgtable_64.h: fix mismatched parens
@ 2019-10-01 0:23 Randy Dunlap
2019-10-01 11:53 ` Andrey Konovalov
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2019-10-01 0:23 UTC (permalink / raw)
To: LKML, Linux MM, Andrew Morton; +Cc: Andrey Konovalov
From: Randy Dunlap <rdunlap@infradead.org>
Fix lib-untag-user-pointers-in-strn_user.patch unmatched left paren.
Fixes many of these build errors:
../mm/gup.c: In function '__get_user_pages':
../mm/gup.c:791:30: error: expected ')' before ';' token
start = untagged_addr(start);
^
In file included from ../arch/sparc/include/asm/pgtable.h:5,
from ../include/linux/mm.h:99,
from ../mm/gup.c:7:
../arch/sparc/include/asm/pgtable_64.h:1102:2: note: to match this '('
((__typeof__(addr))(__untagged_addr((unsigned long)(addr)))
^
../mm/gup.c:791:10: note: in expansion of macro 'untagged_addr'
start = untagged_addr(start);
^~~~~~~~~~~~~
../mm/gup.c:892:21: error: expected ';' before '}' token
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrey Konovalov <andreyknvl@google.com>
---
Is this already fixed???
arch/sparc/include/asm/pgtable_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- mmotm-2019-0925-1810.orig/arch/sparc/include/asm/pgtable_64.h
+++ mmotm-2019-0925-1810/arch/sparc/include/asm/pgtable_64.h
@@ -1099,7 +1099,7 @@ static inline unsigned long __untagged_a
return start;
}
#define untagged_addr(addr) \
- ((__typeof__(addr))(__untagged_addr((unsigned long)(addr)))
+ ((__typeof__(addr))(__untagged_addr((unsigned long)(addr))))
static inline bool pte_access_permitted(pte_t pte, bool write)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH mmotm] sparc64: pgtable_64.h: fix mismatched parens
2019-10-01 0:23 [PATCH mmotm] sparc64: pgtable_64.h: fix mismatched parens Randy Dunlap
@ 2019-10-01 11:53 ` Andrey Konovalov
0 siblings, 0 replies; 2+ messages in thread
From: Andrey Konovalov @ 2019-10-01 11:53 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, Linux MM, Andrew Morton
On Tue, Oct 1, 2019 at 2:23 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix lib-untag-user-pointers-in-strn_user.patch unmatched left paren.
> Fixes many of these build errors:
>
> ../mm/gup.c: In function '__get_user_pages':
> ../mm/gup.c:791:30: error: expected ')' before ';' token
> start = untagged_addr(start);
> ^
> In file included from ../arch/sparc/include/asm/pgtable.h:5,
> from ../include/linux/mm.h:99,
> from ../mm/gup.c:7:
> ../arch/sparc/include/asm/pgtable_64.h:1102:2: note: to match this '('
> ((__typeof__(addr))(__untagged_addr((unsigned long)(addr)))
> ^
> ../mm/gup.c:791:10: note: in expansion of macro 'untagged_addr'
> start = untagged_addr(start);
> ^~~~~~~~~~~~~
> ../mm/gup.c:892:21: error: expected ';' before '}' token
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andrey Konovalov <andreyknvl@google.com>
> ---
>
> Is this already fixed???
Hi Randy,
Yes, this has been fixed by a22fea94992a2bc5328005e62f368413ede49c14.
Thanks!
>
>
> arch/sparc/include/asm/pgtable_64.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- mmotm-2019-0925-1810.orig/arch/sparc/include/asm/pgtable_64.h
> +++ mmotm-2019-0925-1810/arch/sparc/include/asm/pgtable_64.h
> @@ -1099,7 +1099,7 @@ static inline unsigned long __untagged_a
> return start;
> }
> #define untagged_addr(addr) \
> - ((__typeof__(addr))(__untagged_addr((unsigned long)(addr)))
> + ((__typeof__(addr))(__untagged_addr((unsigned long)(addr))))
>
> static inline bool pte_access_permitted(pte_t pte, bool write)
> {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-01 11:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 0:23 [PATCH mmotm] sparc64: pgtable_64.h: fix mismatched parens Randy Dunlap
2019-10-01 11:53 ` Andrey Konovalov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).