* [PATCH] mmflags.h: add missing __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON names
@ 2021-08-16 13:35 Mike Rapoport
2021-08-17 0:05 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Mike Rapoport @ 2021-08-16 13:35 UTC (permalink / raw)
To: Andrew Morton
Cc: Mike Rapoport, Mike Rapoport, Peter Collingbourne,
Steven Rostedt, linux-mm, linux-kernel
From: Mike Rapoport <rppt@linux.ibm.com>
Add missing names of __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON flags to
__def_gfpflag_names.
Fixes: 013bb59dbb7c ("arm64: mte: handle tags zeroing at page allocation time")
Fixes: c275c5c6d50a ("kasan: disable freed user page poisoning with HW tags")
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
include/trace/events/mmflags.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h
index 390270e00a1d..f160484afc5c 100644
--- a/include/trace/events/mmflags.h
+++ b/include/trace/events/mmflags.h
@@ -48,7 +48,9 @@
{(unsigned long)__GFP_WRITE, "__GFP_WRITE"}, \
{(unsigned long)__GFP_RECLAIM, "__GFP_RECLAIM"}, \
{(unsigned long)__GFP_DIRECT_RECLAIM, "__GFP_DIRECT_RECLAIM"},\
- {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"}\
+ {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"},\
+ {(unsigned long)__GFP_ZEROTAGS, "__GFP_ZEROTAGS"}, \
+ {(unsigned long)__GFP_SKIP_KASAN_POISON,"__GFP_SKIP_KASAN_POISON"}\
#define show_gfp_flags(flags) \
(flags) ? __print_flags(flags, "|", \
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmflags.h: add missing __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON names
2021-08-16 13:35 [PATCH] mmflags.h: add missing __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON names Mike Rapoport
@ 2021-08-17 0:05 ` Andrew Morton
2021-08-17 4:59 ` Mike Rapoport
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2021-08-17 0:05 UTC (permalink / raw)
To: Mike Rapoport
Cc: Mike Rapoport, Peter Collingbourne, Steven Rostedt, linux-mm,
linux-kernel
On Mon, 16 Aug 2021 16:35:02 +0300 Mike Rapoport <rppt@kernel.org> wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> Add missing names of __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON flags to
> __def_gfpflag_names.
>
> Fixes: 013bb59dbb7c ("arm64: mte: handle tags zeroing at page allocation time")
> Fixes: c275c5c6d50a ("kasan: disable freed user page poisoning with HW tags")
"fixes" in what way? ie, what problems were caused by the above commits?
> --- a/include/trace/events/mmflags.h
> +++ b/include/trace/events/mmflags.h
> @@ -48,7 +48,9 @@
> {(unsigned long)__GFP_WRITE, "__GFP_WRITE"}, \
> {(unsigned long)__GFP_RECLAIM, "__GFP_RECLAIM"}, \
> {(unsigned long)__GFP_DIRECT_RECLAIM, "__GFP_DIRECT_RECLAIM"},\
> - {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"}\
> + {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"},\
> + {(unsigned long)__GFP_ZEROTAGS, "__GFP_ZEROTAGS"}, \
> + {(unsigned long)__GFP_SKIP_KASAN_POISON,"__GFP_SKIP_KASAN_POISON"}\
>
> #define show_gfp_flags(flags) \
> (flags) ? __print_flags(flags, "|", \
I'm guessing that the tracing output was messed up in some fashion?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmflags.h: add missing __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON names
2021-08-17 0:05 ` Andrew Morton
@ 2021-08-17 4:59 ` Mike Rapoport
0 siblings, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2021-08-17 4:59 UTC (permalink / raw)
To: Andrew Morton
Cc: Mike Rapoport, Peter Collingbourne, Steven Rostedt, linux-mm,
linux-kernel
On Mon, Aug 16, 2021 at 05:05:10PM -0700, Andrew Morton wrote:
> On Mon, 16 Aug 2021 16:35:02 +0300 Mike Rapoport <rppt@kernel.org> wrote:
>
> > From: Mike Rapoport <rppt@linux.ibm.com>
> >
> > Add missing names of __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON flags to
> > __def_gfpflag_names.
> >
> > Fixes: 013bb59dbb7c ("arm64: mte: handle tags zeroing at page allocation time")
> > Fixes: c275c5c6d50a ("kasan: disable freed user page poisoning with HW tags")
>
> "fixes" in what way? ie, what problems were caused by the above commits?
>
> > --- a/include/trace/events/mmflags.h
> > +++ b/include/trace/events/mmflags.h
> > @@ -48,7 +48,9 @@
> > {(unsigned long)__GFP_WRITE, "__GFP_WRITE"}, \
> > {(unsigned long)__GFP_RECLAIM, "__GFP_RECLAIM"}, \
> > {(unsigned long)__GFP_DIRECT_RECLAIM, "__GFP_DIRECT_RECLAIM"},\
> > - {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"}\
> > + {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"},\
> > + {(unsigned long)__GFP_ZEROTAGS, "__GFP_ZEROTAGS"}, \
> > + {(unsigned long)__GFP_SKIP_KASAN_POISON,"__GFP_SKIP_KASAN_POISON"}\
> >
> > #define show_gfp_flags(flags) \
> > (flags) ? __print_flags(flags, "|", \
>
> I'm guessing that the tracing output was messed up in some fashion?
I didn't check tracing actually, but printk("%pGg") outputs these two flags
as hexadecimal number, rather that string, e.g:
GFP_KERNEL|0x1800000
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-17 4:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 13:35 [PATCH] mmflags.h: add missing __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON names Mike Rapoport
2021-08-17 0:05 ` Andrew Morton
2021-08-17 4:59 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).