From: Christopher Lameter <cl@linux.com>
To: Alexander Popov <alex.popov@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com, keescook@chromium.org
Subject: Re: [PATCH 1/1] mm/slub.c: add a naive detection of double free or corruption
Date: Mon, 17 Jul 2017 11:57:50 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1707171156390.10415@nuc-kabylake> (raw)
In-Reply-To: <1500309907-9357-1-git-send-email-alex.popov@linux.com>
On Mon, 17 Jul 2017, Alexander Popov wrote:
> Add an assertion similar to "fasttop" check in GNU C Library allocator:
> an object added to a singly linked freelist should not point to itself.
> That helps to detect some double free errors (e.g. CVE-2017-2636) without
> slub_debug and KASAN. Testing with hackbench doesn't show any noticeable
> performance penalty.
We are adding up "unnoticable performance penalties". This is used
int both the critical allocation and free paths. Could this be
VM_BUG_ON()?
>
> Signed-off-by: Alexander Popov <alex.popov@linux.com>
> ---
> mm/slub.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 1d3f983..a106939b 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -261,6 +261,7 @@ static inline void *get_freepointer_safe(struct kmem_cache *s, void *object)
>
> static inline void set_freepointer(struct kmem_cache *s, void *object, void *fp)
> {
> + BUG_ON(object == fp); /* naive detection of double free or corruption */
> *(void **)(object + s->offset) = fp;
> }
>
>
next prev parent reply other threads:[~2017-07-17 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 16:45 [PATCH 1/1] mm/slub.c: add a naive detection of double free or corruption Alexander Popov
2017-07-17 16:57 ` Christopher Lameter [this message]
2017-07-17 17:54 ` Matthew Wilcox
2017-07-17 18:04 ` Christopher Lameter
2017-07-17 19:01 ` Alexander Popov
2017-07-17 19:11 ` Kees Cook
2017-07-18 19:56 ` Alexander Popov
2017-07-18 20:04 ` Kees Cook
2017-07-19 8:38 ` Alexander Popov
2017-07-19 14:02 ` Christopher Lameter
2017-07-18 14:57 ` Christopher Lameter
2017-07-17 18:23 ` Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707171156390.10415@nuc-kabylake \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=alex.popov@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).