From: Hugh Dickins <hughd@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: dchinner@redhat.com, ebiggers@google.com, gaoxiang25@huawei.com,
guoqing.jiang@cloud.ionos.com, jaegeuk@kernel.org,
jhubbard@nvidia.com, johannes.thumshirn@wdc.com,
joseph.qi@linux.alibaba.com, junxiao.bi@oracle.com,
linux-mm@kvack.org, mhocko@suse.com, mm-commits@vger.kernel.org,
mszeredi@redhat.com, xiyou.wangcong@gmail.com,
yuchao0@huawei.com, ziy@nvidia.com
Subject: [PATCH] mm/migrate.c: attach_page_private already does the get_page
Date: Tue, 2 Jun 2020 14:36:32 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.11.2006021423350.1301@eggly.anvils> (raw)
Just finished bisecting mmotm, to find why a test which used to take
four minutes now took more than an hour: the __buffer_migrate_page()
cleanup left behind a get_page() which attach_page_private() now does.
Fixes: cd0f37154443 ("mm/migrate.c: call detach_page_private to cleanup code")
Signed-off-by: Hugh Dickins <hughd@google.com>
---
Fixes the 048/128 of last night's (or today's) incoming from akpm:
sorry I didn't complete the bisection before it went into Linus's tree.
mm/migrate.c | 1 -
1 file changed, 1 deletion(-)
--- linux.git/mm/migrate.c 2020-06-02 14:04:49.098981268 -0700
+++ linux/mm/migrate.c 2020-06-02 14:07:20.431991495 -0700
@@ -798,7 +798,6 @@ recheck_buffers:
goto unlock_buffers;
attach_page_private(newpage, detach_page_private(page));
- get_page(newpage);
bh = head;
do {
next reply other threads:[~2020-06-02 21:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 21:36 Hugh Dickins [this message]
2020-06-02 22:20 ` [PATCH] mm/migrate.c: attach_page_private already does the get_page Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.2006021423350.1301@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=dchinner@redhat.com \
--cc=ebiggers@google.com \
--cc=gaoxiang25@huawei.com \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=jaegeuk@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=johannes.thumshirn@wdc.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yuchao0@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).