* [PATCH] mm/migrate.c: attach_page_private already does the get_page
@ 2020-06-02 21:36 Hugh Dickins
2020-06-02 22:20 ` Linus Torvalds
0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2020-06-02 21:36 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: dchinner, ebiggers, gaoxiang25, guoqing.jiang, jaegeuk, jhubbard,
johannes.thumshirn, joseph.qi, junxiao.bi, linux-mm, mhocko,
mm-commits, mszeredi, xiyou.wangcong, yuchao0, ziy
Just finished bisecting mmotm, to find why a test which used to take
four minutes now took more than an hour: the __buffer_migrate_page()
cleanup left behind a get_page() which attach_page_private() now does.
Fixes: cd0f37154443 ("mm/migrate.c: call detach_page_private to cleanup code")
Signed-off-by: Hugh Dickins <hughd@google.com>
---
Fixes the 048/128 of last night's (or today's) incoming from akpm:
sorry I didn't complete the bisection before it went into Linus's tree.
mm/migrate.c | 1 -
1 file changed, 1 deletion(-)
--- linux.git/mm/migrate.c 2020-06-02 14:04:49.098981268 -0700
+++ linux/mm/migrate.c 2020-06-02 14:07:20.431991495 -0700
@@ -798,7 +798,6 @@ recheck_buffers:
goto unlock_buffers;
attach_page_private(newpage, detach_page_private(page));
- get_page(newpage);
bh = head;
do {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/migrate.c: attach_page_private already does the get_page
2020-06-02 21:36 [PATCH] mm/migrate.c: attach_page_private already does the get_page Hugh Dickins
@ 2020-06-02 22:20 ` Linus Torvalds
0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2020-06-02 22:20 UTC (permalink / raw)
To: Hugh Dickins
Cc: Andrew Morton, Dave Chinner, Eric Biggers, Gao Xiang,
guoqing.jiang, Jaegeuk Kim, jhubbard, johannes.thumshirn,
joseph.qi, junxiao.bi, Linux-MM, Michal Hocko, mm-commits,
Miklos Szeredi, Cong Wang, Chao Yu, ziy
On Tue, Jun 2, 2020 at 2:36 PM Hugh Dickins <hughd@google.com> wrote:
>
> Fixes the 048/128 of last night's (or today's) incoming from akpm:
> sorry I didn't complete the bisection before it went into Linus's tree.
Oh well. I've applied your fix on top of my tree now.
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-02 22:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 21:36 [PATCH] mm/migrate.c: attach_page_private already does the get_page Hugh Dickins
2020-06-02 22:20 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).