Linux-mmc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static
@ 2020-07-27 17:11 Wei Yongjun
  2020-07-31  6:54 ` Chun-Hung Wu
  2020-08-05  6:29 ` Ulf Hansson
  0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2020-07-27 17:11 UTC (permalink / raw)
  To: Hulk Robot, Chaotian Jing, Ulf Hansson, Matthias Brugger, Chun-Hung Wu
  Cc: Wei Yongjun, linux-mmc, linux-arm-kernel, linux-mediatek

The sparse tool complains as follows:

drivers/mmc/host/mtk-sd.c:2269:6: warning:
 symbol 'msdc_cqe_disable' was not declared. Should it be static?

This function is not used outside of mtk-sd.c, so this commit
marks it static.

Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/mmc/host/mtk-sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 734e403a142e..4e2583f69a63 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2266,7 +2266,7 @@ static void msdc_cqe_enable(struct mmc_host *mmc)
 	msdc_set_timeout(host, 1000000000ULL, 0);
 }
 
-void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
+static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
 {
 	struct msdc_host *host = mmc_priv(mmc);
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static
  2020-07-27 17:11 [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static Wei Yongjun
@ 2020-07-31  6:54 ` Chun-Hung Wu
  2020-08-05  6:29 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Chun-Hung Wu @ 2020-07-31  6:54 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Hulk Robot, Chaotian Jing (井朝天),
	Ulf Hansson, Matthias Brugger, linux-mmc, linux-arm-kernel,
	linux-mediatek

On Tue, 2020-07-28 at 01:11 +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> drivers/mmc/host/mtk-sd.c:2269:6: warning:
>  symbol 'msdc_cqe_disable' was not declared. Should it be static?
> 
> This function is not used outside of mtk-sd.c, so this commit
> marks it static.
> 
> Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/mmc/host/mtk-sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 734e403a142e..4e2583f69a63 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2266,7 +2266,7 @@ static void msdc_cqe_enable(struct mmc_host *mmc)
>  	msdc_set_timeout(host, 1000000000ULL, 0);
>  }
>  
> -void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> +static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
>  {
>  	struct msdc_host *host = mmc_priv(mmc);
>  
> 

Acked-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static
  2020-07-27 17:11 [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static Wei Yongjun
  2020-07-31  6:54 ` Chun-Hung Wu
@ 2020-08-05  6:29 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-08-05  6:29 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Hulk Robot, Chaotian Jing, Matthias Brugger, Chun-Hung Wu,
	linux-mmc, Linux ARM, moderated list:ARM/Mediatek SoC support

On Mon, 27 Jul 2020 at 19:11, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> The sparse tool complains as follows:
>
> drivers/mmc/host/mtk-sd.c:2269:6: warning:
>  symbol 'msdc_cqe_disable' was not declared. Should it be static?
>
> This function is not used outside of mtk-sd.c, so this commit
> marks it static.
>
> Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mtk-sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 734e403a142e..4e2583f69a63 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2266,7 +2266,7 @@ static void msdc_cqe_enable(struct mmc_host *mmc)
>         msdc_set_timeout(host, 1000000000ULL, 0);
>  }
>
> -void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> +static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
>  {
>         struct msdc_host *host = mmc_priv(mmc);
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 17:11 [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static Wei Yongjun
2020-07-31  6:54 ` Chun-Hung Wu
2020-08-05  6:29 ` Ulf Hansson

Linux-mmc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mmc/0 linux-mmc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mmc linux-mmc/ https://lore.kernel.org/linux-mmc \
		linux-mmc@vger.kernel.org
	public-inbox-index linux-mmc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mmc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git