Linux-Modules Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] shared: make scratchbuf_str static
@ 2016-11-09  6:52 Yauheni Kaliuta
  2016-11-11  0:14 ` De Marchi, Lucas
  0 siblings, 1 reply; 2+ messages in thread
From: Yauheni Kaliuta @ 2016-11-09  6:52 UTC (permalink / raw)
  To: linux-modules; +Cc: Lucas De Marchi, Jessica Yu

It fixes linking problem

tools/depmod.o: In function `output_symbols_bin':
depmod.c:(.text.output_symbols_bin+0x135): undefined reference to `scratchbuf_str'

for -O0 build, where gcc doesn't actually inline it.

Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
---
 shared/scratchbuf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/shared/scratchbuf.h b/shared/scratchbuf.h
index c12e4902528f..27ea9d9f6008 100644
--- a/shared/scratchbuf.h
+++ b/shared/scratchbuf.h
@@ -19,7 +19,7 @@ int scratchbuf_alloc(struct scratchbuf *buf, size_t sz);
 void scratchbuf_release(struct scratchbuf *buf);
 
 /* Return a C string */
-inline char *scratchbuf_str(struct scratchbuf *buf)
+static inline char *scratchbuf_str(struct scratchbuf *buf)
 {
 	return buf->bytes;
 }
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] shared: make scratchbuf_str static
  2016-11-09  6:52 [PATCH] shared: make scratchbuf_str static Yauheni Kaliuta
@ 2016-11-11  0:14 ` De Marchi, Lucas
  0 siblings, 0 replies; 2+ messages in thread
From: De Marchi, Lucas @ 2016-11-11  0:14 UTC (permalink / raw)
  To: linux-modules, yauheni.kaliuta; +Cc: jeyu

T24gV2VkLCAyMDE2LTExLTA5IGF0IDA4OjUyICswMjAwLCBZYXVoZW5pIEthbGl1dGEgd3JvdGU6
DQo+IEl0IGZpeGVzIGxpbmtpbmcgcHJvYmxlbQ0KPiANCj4gdG9vbHMvZGVwbW9kLm86IEluIGZ1
bmN0aW9uIGBvdXRwdXRfc3ltYm9sc19iaW4nOg0KPiBkZXBtb2QuYzooLnRleHQub3V0cHV0X3N5
bWJvbHNfYmluKzB4MTM1KTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0bw0KPiBgc2NyYXRjaGJ1Zl9z
dHInDQo+IA0KPiBmb3IgLU8wIGJ1aWxkLCB3aGVyZSBnY2MgZG9lc24ndCBhY3R1YWxseSBpbmxp
bmUgaXQuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBZYXVoZW5pIEthbGl1dGEgPHlhdWhlbmkua2Fs
aXV0YUByZWRoYXQuY29tPg0KPiAtLS0NCg0KQXBwbGllZCwgdGhhbmtzDQoNCkx1Y2FzIERlIE1h
cmNoaQ==

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-09  6:52 [PATCH] shared: make scratchbuf_str static Yauheni Kaliuta
2016-11-11  0:14 ` De Marchi, Lucas

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org linux-modules@archiver.kernel.org
	public-inbox-index linux-modules


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/ public-inbox