* [PATCH 01/20] perf/hw_breakpoint: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
@ 2023-02-28 13:01 ` Nick Alcock
2023-02-28 13:01 ` [PATCH 02/20] pinctrl: amd: " Nick Alcock
` (20 subsequent siblings)
21 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:01 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Peter Zijlstra,
Ingo Molnar, Arnaldo Carvalho de Melo, linux-perf-users
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
---
kernel/events/hw_breakpoint_test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/events/hw_breakpoint_test.c b/kernel/events/hw_breakpoint_test.c
index c57610f52bb4d..2cfeeecf8de97 100644
--- a/kernel/events/hw_breakpoint_test.c
+++ b/kernel/events/hw_breakpoint_test.c
@@ -329,5 +329,4 @@ static struct kunit_suite hw_breakpoint_test_suite = {
kunit_test_suites(&hw_breakpoint_test_suite);
-MODULE_LICENSE("GPL");
MODULE_AUTHOR("Marco Elver <elver@google.com>");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 02/20] pinctrl: amd: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:01 ` [PATCH 01/20] perf/hw_breakpoint: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-02-28 13:01 ` Nick Alcock
2023-03-07 13:08 ` Linus Walleij
2023-02-28 13:01 ` [PATCH 03/20] pinctrl: mediatek: " Nick Alcock
` (19 subsequent siblings)
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:01 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Basavaraj Natikar,
Shyam Sundar S K, Linus Walleij, linux-gpio
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
---
drivers/pinctrl/pinctrl-amd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 9bc6e3922e78e..f9928469c1d04 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -1205,6 +1205,5 @@ static struct platform_driver amd_gpio_driver = {
module_platform_driver(amd_gpio_driver);
-MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Ken Xue <Ken.Xue@amd.com>, Jeff Wu <Jeff.Wu@amd.com>");
MODULE_DESCRIPTION("AMD GPIO pinctrl driver");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 02/20] pinctrl: amd: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 ` [PATCH 02/20] pinctrl: amd: " Nick Alcock
@ 2023-03-07 13:08 ` Linus Walleij
0 siblings, 0 replies; 40+ messages in thread
From: Linus Walleij @ 2023-03-07 13:08 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Basavaraj Natikar, Shyam Sundar S K, linux-gpio
On Tue, Feb 28, 2023 at 2:02 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
> Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
Can I just merge the 3 pinctrl patches to the pinctrl tree or are there
any dependencies?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 03/20] pinctrl: mediatek: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:01 ` [PATCH 01/20] perf/hw_breakpoint: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-28 13:01 ` [PATCH 02/20] pinctrl: amd: " Nick Alcock
@ 2023-02-28 13:01 ` Nick Alcock
2023-02-28 13:01 ` [PATCH 04/20] pinctrl: renesas: " Nick Alcock
` (18 subsequent siblings)
21 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:01 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Sean Wang,
Linus Walleij, Matthias Brugger, linux-mediatek, linux-gpio,
linux-arm-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Sean Wang <sean.wang@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/pinctrl/mediatek/pinctrl-mt8188.c | 1 -
drivers/pinctrl/mediatek/pinctrl-mt8192.c | 1 -
drivers/pinctrl/mediatek/pinctrl-mt8365.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8188.c b/drivers/pinctrl/mediatek/pinctrl-mt8188.c
index 6a3d0126288e2..c067e043e6192 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mt8188.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mt8188.c
@@ -1670,5 +1670,4 @@ static int __init mt8188_pinctrl_init(void)
arch_initcall(mt8188_pinctrl_init);
-MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("MediaTek MT8188 Pinctrl Driver");
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.c b/drivers/pinctrl/mediatek/pinctrl-mt8192.c
index 9695f4ec6aba9..dee1b3aefd36e 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c
@@ -1431,5 +1431,4 @@ static int __init mt8192_pinctrl_init(void)
}
arch_initcall(mt8192_pinctrl_init);
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("MediaTek MT8192 Pinctrl Driver");
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8365.c b/drivers/pinctrl/mediatek/pinctrl-mt8365.c
index db4492e9ee673..75a505035e96b 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mt8365.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mt8365.c
@@ -495,6 +495,5 @@ static int __init mtk_pinctrl_init(void)
}
arch_initcall(mtk_pinctrl_init);
-MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("MediaTek MT8365 Pinctrl Driver");
MODULE_AUTHOR("Zhiyong Tao <zhiyong.tao@mediatek.com>");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 04/20] pinctrl: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (2 preceding siblings ...)
2023-02-28 13:01 ` [PATCH 03/20] pinctrl: mediatek: " Nick Alcock
@ 2023-02-28 13:01 ` Nick Alcock
2023-02-28 13:02 ` [PATCH 05/20] lib: " Nick Alcock
` (17 subsequent siblings)
21 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:01 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Geert Uytterhoeven,
Linus Walleij, linux-renesas-soc, linux-gpio
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
---
drivers/pinctrl/renesas/pinctrl-rza1.c | 1 -
drivers/pinctrl/renesas/pinctrl-rza2.c | 1 -
drivers/pinctrl/renesas/pinctrl-rzg2l.c | 1 -
drivers/pinctrl/renesas/pinctrl-rzn1.c | 1 -
drivers/pinctrl/renesas/pinctrl-rzv2m.c | 1 -
5 files changed, 5 deletions(-)
diff --git a/drivers/pinctrl/renesas/pinctrl-rza1.c b/drivers/pinctrl/renesas/pinctrl-rza1.c
index 529c0fc4ec063..48173355a040a 100644
--- a/drivers/pinctrl/renesas/pinctrl-rza1.c
+++ b/drivers/pinctrl/renesas/pinctrl-rza1.c
@@ -1407,4 +1407,3 @@ core_initcall(rza1_pinctrl_init);
MODULE_AUTHOR("Jacopo Mondi <jacopo+renesas@jmondi.org");
MODULE_DESCRIPTION("Pin and gpio controller driver for Reneas RZ/A1 SoC");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/pinctrl/renesas/pinctrl-rza2.c b/drivers/pinctrl/renesas/pinctrl-rza2.c
index c0a04f1ee994e..40b1326a10776 100644
--- a/drivers/pinctrl/renesas/pinctrl-rza2.c
+++ b/drivers/pinctrl/renesas/pinctrl-rza2.c
@@ -514,4 +514,3 @@ core_initcall(rza2_pinctrl_init);
MODULE_AUTHOR("Chris Brandt <chris.brandt@renesas.com>");
MODULE_DESCRIPTION("Pin and gpio controller driver for RZ/A2 SoC");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index 5aa3836dbc226..362c3a0baf1df 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -1561,4 +1561,3 @@ core_initcall(rzg2l_pinctrl_init);
MODULE_AUTHOR("Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>");
MODULE_DESCRIPTION("Pin and gpio controller driver for RZ/G2L family");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/pinctrl/renesas/pinctrl-rzn1.c b/drivers/pinctrl/renesas/pinctrl-rzn1.c
index 9158c17574923..d73741651419f 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzn1.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzn1.c
@@ -952,4 +952,3 @@ subsys_initcall(_pinctrl_drv_register);
MODULE_AUTHOR("Phil Edworthy <phil.edworthy@renesas.com>");
MODULE_DESCRIPTION("Renesas RZ/N1 pinctrl driver");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
index 3b65a71abd9ac..e5472293bc7fb 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
@@ -1117,4 +1117,3 @@ core_initcall(rzv2m_pinctrl_init);
MODULE_AUTHOR("Phil Edworthy <phil.edworthy@renesas.com>");
MODULE_DESCRIPTION("Pin and gpio controller driver for RZ/V2M");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (3 preceding siblings ...)
2023-02-28 13:01 ` [PATCH 04/20] pinctrl: renesas: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 16:35 ` Keller, Jacob E
2023-02-28 13:02 ` [PATCH 06/20] powercap: " Nick Alcock
` (16 subsequent siblings)
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof; +Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Jacob Keller
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>
---
lib/pldmfw/pldmfw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c
index 6e77eb6d8e72e..54e1809a38fd9 100644
--- a/lib/pldmfw/pldmfw.c
+++ b/lib/pldmfw/pldmfw.c
@@ -875,5 +875,4 @@ int pldmfw_flash_image(struct pldmfw *context, const struct firmware *fw)
EXPORT_SYMBOL(pldmfw_flash_image);
MODULE_AUTHOR("Jacob Keller <jacob.e.keller@intel.com>");
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("PLDM firmware flash update library");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* RE: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 05/20] lib: " Nick Alcock
@ 2023-02-28 16:35 ` Keller, Jacob E
0 siblings, 0 replies; 40+ messages in thread
From: Keller, Jacob E @ 2023-02-28 16:35 UTC (permalink / raw)
To: Nick Alcock, mcgrof; +Cc: linux-modules, linux-kernel, Hitomi Hasegawa
> -----Original Message-----
> From: Nick Alcock <nick.alcock@oracle.com>
> Sent: Tuesday, February 28, 2023 5:02 AM
> To: mcgrof@kernel.org
> Cc: linux-modules@vger.kernel.org; linux-kernel@vger.kernel.org; Hitomi
> Hasegawa <hasegawa-hitomi@fujitsu.com>; Keller, Jacob E
> <jacob.e.keller@intel.com>
> Subject: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
>
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> lib/pldmfw/pldmfw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c
> index 6e77eb6d8e72e..54e1809a38fd9 100644
> --- a/lib/pldmfw/pldmfw.c
> +++ b/lib/pldmfw/pldmfw.c
> @@ -875,5 +875,4 @@ int pldmfw_flash_image(struct pldmfw *context, const
> struct firmware *fw)
> EXPORT_SYMBOL(pldmfw_flash_image);
>
> MODULE_AUTHOR("Jacob Keller <jacob.e.keller@intel.com>");
> -MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("PLDM firmware flash update library");
> --
> 2.39.1.268.g9de2f9a303
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 06/20] powercap: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (4 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 05/20] lib: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 20:33 ` Rafael J. Wysocki
2023-02-28 13:02 ` [PATCH 07/20] power: supply: " Nick Alcock
` (15 subsequent siblings)
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Rafael J. Wysocki,
linux-pm
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-pm@vger.kernel.org
---
drivers/powercap/powercap_sys.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
index 1f968353d4799..df806a788a02d 100644
--- a/drivers/powercap/powercap_sys.c
+++ b/drivers/powercap/powercap_sys.c
@@ -675,4 +675,3 @@ fs_initcall(powercap_init);
MODULE_DESCRIPTION("PowerCap sysfs Driver");
MODULE_AUTHOR("Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>");
-MODULE_LICENSE("GPL v2");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 06/20] powercap: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 06/20] powercap: " Nick Alcock
@ 2023-02-28 20:33 ` Rafael J. Wysocki
0 siblings, 0 replies; 40+ messages in thread
From: Rafael J. Wysocki @ 2023-02-28 20:33 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Rafael J. Wysocki, linux-pm
On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: linux-pm@vger.kernel.org
> ---
> drivers/powercap/powercap_sys.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
> index 1f968353d4799..df806a788a02d 100644
> --- a/drivers/powercap/powercap_sys.c
> +++ b/drivers/powercap/powercap_sys.c
> @@ -675,4 +675,3 @@ fs_initcall(powercap_init);
>
> MODULE_DESCRIPTION("PowerCap sysfs Driver");
> MODULE_AUTHOR("Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>");
> -MODULE_LICENSE("GPL v2");
> --
Applied as 6.3-rc material, thanks!
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 07/20] power: supply: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (5 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 06/20] powercap: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:02 ` [PATCH 08/20] remoteproc: " Nick Alcock
` (14 subsequent siblings)
21 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Sebastian Reichel,
linux-pm
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org
---
drivers/power/supply/power_supply_core.c | 1 -
drivers/power/supply/wm97xx_battery.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
index 7c790c41e2fe3..411fb8b8945a7 100644
--- a/drivers/power/supply/power_supply_core.c
+++ b/drivers/power/supply/power_supply_core.c
@@ -1578,4 +1578,3 @@ MODULE_DESCRIPTION("Universal power supply monitor class");
MODULE_AUTHOR("Ian Molton <spyro@f2s.com>, "
"Szabolcs Gyurko, "
"Anton Vorontsov <cbou@mail.ru>");
-MODULE_LICENSE("GPL");
diff --git a/drivers/power/supply/wm97xx_battery.c b/drivers/power/supply/wm97xx_battery.c
index a0e1eaa25d93e..f4b190adb3359 100644
--- a/drivers/power/supply/wm97xx_battery.c
+++ b/drivers/power/supply/wm97xx_battery.c
@@ -271,6 +271,5 @@ static struct platform_driver wm97xx_bat_driver = {
module_platform_driver(wm97xx_bat_driver);
-MODULE_LICENSE("GPL");
MODULE_AUTHOR("Marek Vasut <marek.vasut@gmail.com>");
MODULE_DESCRIPTION("WM97xx battery driver");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 08/20] remoteproc: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (6 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 07/20] power: supply: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:35 ` Mukesh Ojha
2023-03-02 22:01 ` Mathieu Poirier
2023-02-28 13:02 ` [PATCH 09/20] clk: renesas: " Nick Alcock
` (13 subsequent siblings)
21 siblings, 2 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Bjorn Andersson,
Mathieu Poirier, linux-remoteproc
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: linux-remoteproc@vger.kernel.org
---
drivers/remoteproc/remoteproc_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 1cd4815a6dd19..de1ace44cb57b 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -2765,5 +2765,4 @@ static void __exit remoteproc_exit(void)
}
module_exit(remoteproc_exit);
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("Generic Remote Processor Framework");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 08/20] remoteproc: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 08/20] remoteproc: " Nick Alcock
@ 2023-02-28 13:35 ` Mukesh Ojha
2023-03-02 22:01 ` Mathieu Poirier
1 sibling, 0 replies; 40+ messages in thread
From: Mukesh Ojha @ 2023-02-28 13:35 UTC (permalink / raw)
To: Nick Alcock, mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Bjorn Andersson,
Mathieu Poirier, linux-remoteproc
On 2/28/2023 6:32 PM, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: linux-remoteproc@vger.kernel.org
Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
> ---
> drivers/remoteproc/remoteproc_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 1cd4815a6dd19..de1ace44cb57b 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -2765,5 +2765,4 @@ static void __exit remoteproc_exit(void)
> }
> module_exit(remoteproc_exit);
>
> -MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("Generic Remote Processor Framework");
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 08/20] remoteproc: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 08/20] remoteproc: " Nick Alcock
2023-02-28 13:35 ` Mukesh Ojha
@ 2023-03-02 22:01 ` Mathieu Poirier
1 sibling, 0 replies; 40+ messages in thread
From: Mathieu Poirier @ 2023-03-02 22:01 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Bjorn Andersson, linux-remoteproc
On Tue, 28 Feb 2023 at 06:03, Nick Alcock <nick.alcock@oracle.com> wrote:
>
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: linux-remoteproc@vger.kernel.org
> ---
> drivers/remoteproc/remoteproc_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 1cd4815a6dd19..de1ace44cb57b 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -2765,5 +2765,4 @@ static void __exit remoteproc_exit(void)
> }
> module_exit(remoteproc_exit);
>
> -MODULE_LICENSE("GPL v2");
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> MODULE_DESCRIPTION("Generic Remote Processor Framework");
> --
> 2.39.1.268.g9de2f9a303
>
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (7 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 08/20] remoteproc: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:45 ` Geert Uytterhoeven
2023-02-28 13:02 ` [PATCH 10/20] reset: mchp: sparx5: " Nick Alcock
` (12 subsequent siblings)
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Geert Uytterhoeven,
Michael Turquette, Stephen Boyd, Philipp Zabel,
linux-renesas-soc, linux-clk
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-clk@vger.kernel.org
---
drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
drivers/clk/renesas/renesas-cpg-mssr.c | 1 -
drivers/clk/renesas/rzg2l-cpg.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/clk/renesas/rcar-usb2-clock-sel.c b/drivers/clk/renesas/rcar-usb2-clock-sel.c
index 684d8937965e0..ba6b5bd67786f 100644
--- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
+++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
@@ -220,4 +220,3 @@ static struct platform_driver rcar_usb2_clock_sel_driver = {
builtin_platform_driver(rcar_usb2_clock_sel_driver);
MODULE_DESCRIPTION("Renesas R-Car USB2 clock selector Driver");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index 1a0cdf001b2f2..bfe5dc9a2e36b 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -1154,4 +1154,3 @@ void __init mssr_mod_reparent(struct mssr_mod_clk *mod_clks,
}
MODULE_DESCRIPTION("Renesas CPG/MSSR Driver");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c
index 4bf40f6ccd1d1..93b02cdc98c25 100644
--- a/drivers/clk/renesas/rzg2l-cpg.c
+++ b/drivers/clk/renesas/rzg2l-cpg.c
@@ -1440,4 +1440,3 @@ static int __init rzg2l_cpg_init(void)
subsys_initcall(rzg2l_cpg_init);
MODULE_DESCRIPTION("Renesas RZ/G2L CPG Driver");
-MODULE_LICENSE("GPL v2");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 09/20] clk: renesas: " Nick Alcock
@ 2023-02-28 13:45 ` Geert Uytterhoeven
2023-02-28 14:07 ` Adam Ford
2023-03-20 11:08 ` Nick Alcock
0 siblings, 2 replies; 40+ messages in thread
From: Geert Uytterhoeven @ 2023-02-28 13:45 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Michael Turquette, Stephen Boyd, Philipp Zabel,
linux-renesas-soc, linux-clk, Yoshihiro Shimoda, Adam Ford
Hi Nick,
On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Thanks for your patch!
> drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
I think it would make sense to make CLK_RCAR_USB2_CLOCK_SEL
tristate. Shimoda-san?
The Beacon Renesom seems to be the only board where this
is wired up, Adam?
> drivers/clk/renesas/renesas-cpg-mssr.c | 1 -
> drivers/clk/renesas/rzg2l-cpg.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/clk/renesas/rcar-usb2-clock-sel.c b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> index 684d8937965e0..ba6b5bd67786f 100644
> --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
> +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> @@ -220,4 +220,3 @@ static struct platform_driver rcar_usb2_clock_sel_driver = {
> builtin_platform_driver(rcar_usb2_clock_sel_driver);
>
> MODULE_DESCRIPTION("Renesas R-Car USB2 clock selector Driver");
> -MODULE_LICENSE("GPL v2");
> diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
> index 1a0cdf001b2f2..bfe5dc9a2e36b 100644
> --- a/drivers/clk/renesas/renesas-cpg-mssr.c
> +++ b/drivers/clk/renesas/renesas-cpg-mssr.c
> @@ -1154,4 +1154,3 @@ void __init mssr_mod_reparent(struct mssr_mod_clk *mod_clks,
> }
>
> MODULE_DESCRIPTION("Renesas CPG/MSSR Driver");
> -MODULE_LICENSE("GPL v2");
> diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c
> index 4bf40f6ccd1d1..93b02cdc98c25 100644
> --- a/drivers/clk/renesas/rzg2l-cpg.c
> +++ b/drivers/clk/renesas/rzg2l-cpg.c
> @@ -1440,4 +1440,3 @@ static int __init rzg2l_cpg_init(void)
> subsys_initcall(rzg2l_cpg_init);
>
> MODULE_DESCRIPTION("Renesas RZ/G2L CPG Driver");
> -MODULE_LICENSE("GPL v2");
> --
> 2.39.1.268.g9de2f9a303
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:45 ` Geert Uytterhoeven
@ 2023-02-28 14:07 ` Adam Ford
2023-03-20 11:08 ` Nick Alcock
1 sibling, 0 replies; 40+ messages in thread
From: Adam Ford @ 2023-02-28 14:07 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Nick Alcock, mcgrof, linux-modules, linux-kernel,
Hitomi Hasegawa, Michael Turquette, Stephen Boyd, Philipp Zabel,
linux-renesas-soc, linux-clk, Yoshihiro Shimoda
On Tue, Feb 28, 2023 at 7:46 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Nick,
>
> On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> > Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> > are used to identify modules. As a consequence, uses of the macro
> > in non-modules will cause modprobe to misidentify their containing
> > object file as a module when it is not (false positives), and modprobe
> > might succeed rather than failing with a suitable error message.
> >
> > So remove it in the files in this commit, none of which can be built as
> > modules.
> >
> > Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Thanks for your patch!
>
> > drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
>
> I think it would make sense to make CLK_RCAR_USB2_CLOCK_SEL
> tristate. Shimoda-san?
> The Beacon Renesom seems to be the only board where this
> is wired up, Adam?
The CLK_RCAR_USB2_CLOCK_SEL is basically glue that lets the user
select between an external oscillator or a crystal oscillator. The
Beacon board uses an external clock instead of a crystal, so this
driver is plumbed in to make sure the external clock is enabled on
demand and the SoC isn't trying to excite the crystal.
The CLK_RCAR_USB2_CLOCK_SEL is currently set to 'y' in the defconfig,
but it looks like the USB_RENESAS_USB3 and USB_RENESAS_USBHS drivers
are all modules. I am not an expert in this area, but it seems to me
like the CLK_RCAR_USB2_CLOCK_SEL could likely be tri-state as well. I
am not sure how the dependency and/or loading order would be
established.
adam
>
> > drivers/clk/renesas/renesas-cpg-mssr.c | 1 -
> > drivers/clk/renesas/rzg2l-cpg.c | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/clk/renesas/rcar-usb2-clock-sel.c b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > index 684d8937965e0..ba6b5bd67786f 100644
> > --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > @@ -220,4 +220,3 @@ static struct platform_driver rcar_usb2_clock_sel_driver = {
> > builtin_platform_driver(rcar_usb2_clock_sel_driver);
> >
> > MODULE_DESCRIPTION("Renesas R-Car USB2 clock selector Driver");
> > -MODULE_LICENSE("GPL v2");
> > diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
> > index 1a0cdf001b2f2..bfe5dc9a2e36b 100644
> > --- a/drivers/clk/renesas/renesas-cpg-mssr.c
> > +++ b/drivers/clk/renesas/renesas-cpg-mssr.c
> > @@ -1154,4 +1154,3 @@ void __init mssr_mod_reparent(struct mssr_mod_clk *mod_clks,
> > }
> >
> > MODULE_DESCRIPTION("Renesas CPG/MSSR Driver");
> > -MODULE_LICENSE("GPL v2");
> > diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c
> > index 4bf40f6ccd1d1..93b02cdc98c25 100644
> > --- a/drivers/clk/renesas/rzg2l-cpg.c
> > +++ b/drivers/clk/renesas/rzg2l-cpg.c
> > @@ -1440,4 +1440,3 @@ static int __init rzg2l_cpg_init(void)
> > subsys_initcall(rzg2l_cpg_init);
> >
> > MODULE_DESCRIPTION("Renesas RZ/G2L CPG Driver");
> > -MODULE_LICENSE("GPL v2");
> > --
> > 2.39.1.268.g9de2f9a303
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:45 ` Geert Uytterhoeven
2023-02-28 14:07 ` Adam Ford
@ 2023-03-20 11:08 ` Nick Alcock
1 sibling, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-03-20 11:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Michael Turquette, Stephen Boyd, Philipp Zabel,
linux-renesas-soc, linux-clk, Yoshihiro Shimoda, Adam Ford
On 28 Feb 2023, Geert Uytterhoeven outgrape:
> Hi Nick,
>
> On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>>
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>>
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Thanks for your patch!
>
>> drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
>
> I think it would make sense to make CLK_RCAR_USB2_CLOCK_SEL
> tristate. Shimoda-san?
This patch touches three files, so I hope that means the MODULE_LICENSE
removal from drivers/clk/renesas/renesas-cpg-mssr.c and
drivers/clk/renesas/rzg2l-cpg.c is OK :)
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 10/20] reset: mchp: sparx5: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (8 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 09/20] clk: renesas: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 14:53 ` Steen Hegelund
2023-02-28 13:02 ` [PATCH 11/20] reset: lantiq: " Nick Alcock
` (11 subsequent siblings)
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Philipp Zabel,
Lars Povlsen, Steen Hegelund, Daniel Machon, UNGLinuxDriver,
linux-arm-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Lars Povlsen <lars.povlsen@microchip.com>
Cc: Steen Hegelund <Steen.Hegelund@microchip.com>
Cc: Daniel Machon <daniel.machon@microchip.com>
Cc: UNGLinuxDriver@microchip.com
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/reset/reset-microchip-sparx5.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset-microchip-sparx5.c
index f3528dd1d084e..ead25942061d2 100644
--- a/drivers/reset/reset-microchip-sparx5.c
+++ b/drivers/reset/reset-microchip-sparx5.c
@@ -179,4 +179,3 @@ postcore_initcall(mchp_sparx5_reset_init);
MODULE_DESCRIPTION("Microchip Sparx5 switch reset driver");
MODULE_AUTHOR("Steen Hegelund <steen.hegelund@microchip.com>");
-MODULE_LICENSE("Dual MIT/GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 10/20] reset: mchp: sparx5: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 10/20] reset: mchp: sparx5: " Nick Alcock
@ 2023-02-28 14:53 ` Steen Hegelund
0 siblings, 0 replies; 40+ messages in thread
From: Steen Hegelund @ 2023-02-28 14:53 UTC (permalink / raw)
To: Nick Alcock, mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Philipp Zabel,
Lars Povlsen, Daniel Machon, UNGLinuxDriver, linux-arm-kernel
Hi Nick,
Looks good to me.
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
On Tue, 2023-02-28 at 13:02 +0000, Nick Alcock wrote:
> [Some people who received this message don't often get email from
> nick.alcock@oracle.com. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Lars Povlsen <lars.povlsen@microchip.com>
> Cc: Steen Hegelund <Steen.Hegelund@microchip.com>
> Cc: Daniel Machon <daniel.machon@microchip.com>
> Cc: UNGLinuxDriver@microchip.com
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/reset/reset-microchip-sparx5.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset-
> microchip-sparx5.c
> index f3528dd1d084e..ead25942061d2 100644
> --- a/drivers/reset/reset-microchip-sparx5.c
> +++ b/drivers/reset/reset-microchip-sparx5.c
> @@ -179,4 +179,3 @@ postcore_initcall(mchp_sparx5_reset_init);
>
> MODULE_DESCRIPTION("Microchip Sparx5 switch reset driver");
> MODULE_AUTHOR("Steen Hegelund <steen.hegelund@microchip.com>");
> -MODULE_LICENSE("Dual MIT/GPL");
> --
> 2.39.1.268.g9de2f9a303
>
BR
Steen
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 11/20] reset: lantiq: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (9 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 10/20] reset: mchp: sparx5: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:02 ` [PATCH 12/20] clk: microchip: mpfs: " Nick Alcock
` (10 subsequent siblings)
21 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof; +Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Philipp Zabel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/reset-lantiq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/reset/reset-lantiq.c b/drivers/reset/reset-lantiq.c
index b936cfe856413..549ba45d85971 100644
--- a/drivers/reset/reset-lantiq.c
+++ b/drivers/reset/reset-lantiq.c
@@ -207,4 +207,3 @@ module_platform_driver(lantiq_rcu_reset_driver);
MODULE_AUTHOR("Martin Blumenstingl <martin.blumenstingl@googlemail.com>");
MODULE_DESCRIPTION("Lantiq XWAY RCU Reset Controller Driver");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (10 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 11/20] reset: lantiq: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 19:19 ` Conor Dooley
2023-02-28 13:02 ` [PATCH 13/20] reset: " Nick Alcock
` (9 subsequent siblings)
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Conor Dooley,
Daire McNamara, Michael Turquette, Stephen Boyd, linux-riscv,
linux-clk
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Conor Dooley <conor.dooley@microchip.com>
Cc: Daire McNamara <daire.mcnamara@microchip.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-riscv@lists.infradead.org
Cc: linux-clk@vger.kernel.org
---
drivers/clk/microchip/clk-mpfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk-mpfs.c
index 4f0a19db7ed74..d85b345f4c08d 100644
--- a/drivers/clk/microchip/clk-mpfs.c
+++ b/drivers/clk/microchip/clk-mpfs.c
@@ -513,4 +513,3 @@ MODULE_DESCRIPTION("Microchip PolarFire SoC Clock Driver");
MODULE_AUTHOR("Padmarao Begari <padmarao.begari@microchip.com>");
MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>");
MODULE_AUTHOR("Conor Dooley <conor.dooley@microchip.com>");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 12/20] clk: microchip: mpfs: " Nick Alcock
@ 2023-02-28 19:19 ` Conor Dooley
0 siblings, 0 replies; 40+ messages in thread
From: Conor Dooley @ 2023-02-28 19:19 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Conor Dooley, Daire McNamara, Michael Turquette, Stephen Boyd,
linux-riscv, linux-clk
[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]
On Tue, Feb 28, 2023 at 01:02:07PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Cc: Daire McNamara <daire.mcnamara@microchip.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-riscv@lists.infradead.org
> Cc: linux-clk@vger.kernel.org
> ---
> drivers/clk/microchip/clk-mpfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk-mpfs.c
> index 4f0a19db7ed74..d85b345f4c08d 100644
> --- a/drivers/clk/microchip/clk-mpfs.c
> +++ b/drivers/clk/microchip/clk-mpfs.c
> @@ -513,4 +513,3 @@ MODULE_DESCRIPTION("Microchip PolarFire SoC Clock Driver");
> MODULE_AUTHOR("Padmarao Begari <padmarao.begari@microchip.com>");
> MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>");
> MODULE_AUTHOR("Conor Dooley <conor.dooley@microchip.com>");
> -MODULE_LICENSE("GPL");
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
I'll take this via the microchip/at91 clock tree after v6.3-rc1 has been
released.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (11 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 12/20] clk: microchip: mpfs: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 19:17 ` Conor Dooley
2023-02-28 13:02 ` [PATCH 14/20] rv/reactor: " Nick Alcock
` (8 subsequent siblings)
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Conor Dooley,
Daire McNamara, Philipp Zabel, linux-riscv
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Conor Dooley <conor.dooley@microchip.com>
Cc: Daire McNamara <daire.mcnamara@microchip.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-riscv@lists.infradead.org
---
drivers/reset/reset-mpfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/reset/reset-mpfs.c b/drivers/reset/reset-mpfs.c
index e003e50590ec5..e71ab73092abd 100644
--- a/drivers/reset/reset-mpfs.c
+++ b/drivers/reset/reset-mpfs.c
@@ -153,5 +153,4 @@ module_auxiliary_driver(mpfs_reset_driver);
MODULE_DESCRIPTION("Microchip PolarFire SoC Reset Driver");
MODULE_AUTHOR("Conor Dooley <conor.dooley@microchip.com>");
-MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(MCHP_CLK_MPFS);
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 13/20] reset: " Nick Alcock
@ 2023-02-28 19:17 ` Conor Dooley
2023-02-28 19:26 ` Nick Alcock
0 siblings, 1 reply; 40+ messages in thread
From: Conor Dooley @ 2023-02-28 19:17 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Conor Dooley, Daire McNamara, Philipp Zabel, linux-riscv
[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]
On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Cc: Daire McNamara <daire.mcnamara@microchip.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: linux-riscv@lists.infradead.org
> ---
> drivers/reset/reset-mpfs.c | 1 -
I assume your script just got confused here w/ $subject, since there's
only a change for this specific file.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules
2023-02-28 19:17 ` Conor Dooley
@ 2023-02-28 19:26 ` Nick Alcock
2023-02-28 19:53 ` Conor Dooley
0 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 19:26 UTC (permalink / raw)
To: Conor Dooley; +Cc: linux-modules, linux-kernel, linux-riscv
[dropped non-lists to defend innocent ears from my flaming pedantry]
On 28 Feb 2023, Conor Dooley stated:
> On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>>
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>>
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: linux-modules@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
>> Cc: Conor Dooley <conor.dooley@microchip.com>
>> Cc: Daire McNamara <daire.mcnamara@microchip.com>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Cc: linux-riscv@lists.infradead.org
>> ---
>> drivers/reset/reset-mpfs.c | 1 -
>
> I assume your script just got confused here w/ $subject, since there's
> only a change for this specific file.
This file has had no commits since you wrote it last year, and the
subject for that commit was
reset: add polarfire soc reset support
so, er, yes, the script used 'reset:' as a prefix, mimicking the
existing commit. I'm not sure what else it could have done.
(Regarding the rest of the subject line, I suppose I could have arranged
to detect single-file commits and turned the subject into 'in this
non-module'? But there comes a time when even I think that maybe I might
be overdesigning something, and automated grammatical adjustments to the
subject line was that point!)
--
NULL && (void)
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules
2023-02-28 19:26 ` Nick Alcock
@ 2023-02-28 19:53 ` Conor Dooley
0 siblings, 0 replies; 40+ messages in thread
From: Conor Dooley @ 2023-02-28 19:53 UTC (permalink / raw)
To: Nick Alcock; +Cc: linux-modules, linux-kernel, linux-riscv
[-- Attachment #1: Type: text/plain, Size: 2451 bytes --]
On Tue, Feb 28, 2023 at 07:26:55PM +0000, Nick Alcock wrote:
> [dropped non-lists to defend innocent ears from my flaming pedantry]
>
> On 28 Feb 2023, Conor Dooley stated:
>
> > On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
> >> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> >> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> >> are used to identify modules. As a consequence, uses of the macro
> >> in non-modules will cause modprobe to misidentify their containing
> >> object file as a module when it is not (false positives), and modprobe
> >> might succeed rather than failing with a suitable error message.
> >>
> >> So remove it in the files in this commit, none of which can be built as
> >> modules.
> >>
> >> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> >> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> >> Cc: Luis Chamberlain <mcgrof@kernel.org>
> >> Cc: linux-modules@vger.kernel.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> >> Cc: Conor Dooley <conor.dooley@microchip.com>
> >> Cc: Daire McNamara <daire.mcnamara@microchip.com>
> >> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> >> Cc: linux-riscv@lists.infradead.org
> >> ---
> >> drivers/reset/reset-mpfs.c | 1 -
> >
> > I assume your script just got confused here w/ $subject, since there's
> > only a change for this specific file.
>
> This file has had no commits since you wrote it last year, and the
> subject for that commit was
>
> reset: add polarfire soc reset support
>
> so, er, yes, the script used 'reset:' as a prefix, mimicking the
> existing commit. I'm not sure what else it could have done.
Oh ye, silly me - I didn't think of that. I guess that's a common
pattern for commits adding a driver, as the "mpfs:" doesn't really make
sense until the driver is in-tree.
I'm not too sure what you could have done either, but I'm not
complaining, or requesting that something be changed here.
> (Regarding the rest of the subject line, I suppose I could have arranged
> to detect single-file commits and turned the subject into 'in this
> non-module'? But there comes a time when even I think that maybe I might
> be overdesigning something, and automated grammatical adjustments to the
> subject line was that point!)
Yeah, I think it's not worth doing anything about really...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (12 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 13/20] reset: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:19 ` Daniel Bristot de Oliveira
2023-02-28 13:02 ` [PATCH 15/20] tty: serial: imx: " Nick Alcock
` (7 subsequent siblings)
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa,
Daniel Bristot de Oliveira, Steven Rostedt, Masami Hiramatsu,
linux-trace-devel, linux-trace-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-trace-devel@vger.kernel.org
Cc: linux-trace-kernel@vger.kernel.org
---
kernel/trace/rv/reactor_panic.c | 1 -
kernel/trace/rv/reactor_printk.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_panic.c
index d65f6c25a87cd..0186ff4cbd0b4 100644
--- a/kernel/trace/rv/reactor_panic.c
+++ b/kernel/trace/rv/reactor_panic.c
@@ -38,6 +38,5 @@ static void __exit unregister_react_panic(void)
module_init(register_react_panic);
module_exit(unregister_react_panic);
-MODULE_LICENSE("GPL");
MODULE_AUTHOR("Daniel Bristot de Oliveira");
MODULE_DESCRIPTION("panic rv reactor: panic if an exception is found.");
diff --git a/kernel/trace/rv/reactor_printk.c b/kernel/trace/rv/reactor_printk.c
index 4b6b7106a477c..178759dbf89f5 100644
--- a/kernel/trace/rv/reactor_printk.c
+++ b/kernel/trace/rv/reactor_printk.c
@@ -37,6 +37,5 @@ static void __exit unregister_react_printk(void)
module_init(register_react_printk);
module_exit(unregister_react_printk);
-MODULE_LICENSE("GPL");
MODULE_AUTHOR("Daniel Bristot de Oliveira");
MODULE_DESCRIPTION("printk rv reactor: printk if an exception is hit.");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 14/20] rv/reactor: " Nick Alcock
@ 2023-02-28 13:19 ` Daniel Bristot de Oliveira
0 siblings, 0 replies; 40+ messages in thread
From: Daniel Bristot de Oliveira @ 2023-02-28 13:19 UTC (permalink / raw)
To: Nick Alcock, mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Steven Rostedt,
Masami Hiramatsu, linux-trace-devel, linux-trace-kernel
On 2/28/23 10:02, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
-- Daniel
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 15/20] tty: serial: imx: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (13 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 14/20] rv/reactor: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:02 ` [PATCH 16/20] irqchip/irq-sl28cpld: " Nick Alcock
` (6 subsequent siblings)
21 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Greg Kroah-Hartman,
Jiri Slaby, Shawn Guo, Sascha Hauer, linux-serial,
linux-arm-kernel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-serial@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/tty/serial/imx_earlycon.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/imx_earlycon.c b/drivers/tty/serial/imx_earlycon.c
index 7aab38b2bd8cb..2dacd7ae63088 100644
--- a/drivers/tty/serial/imx_earlycon.c
+++ b/drivers/tty/serial/imx_earlycon.c
@@ -47,4 +47,3 @@ OF_EARLYCON_DECLARE(ec_imx21, "fsl,imx21-uart", imx_console_early_setup);
MODULE_AUTHOR("NXP");
MODULE_DESCRIPTION("IMX earlycon driver");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 16/20] irqchip/irq-sl28cpld: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (14 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 15/20] tty: serial: imx: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 16:12 ` Michael Walle
2023-02-28 13:02 ` [PATCH 17/20] ARC: reset: " Nick Alcock
` (5 subsequent siblings)
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Michael Walle,
Thomas Gleixner, Marc Zyngier
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Michael Walle <michael@walle.cc>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <maz@kernel.org>
---
drivers/irqchip/irq-sl28cpld.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/irqchip/irq-sl28cpld.c b/drivers/irqchip/irq-sl28cpld.c
index f2172240172c4..e50f9eaba4cd9 100644
--- a/drivers/irqchip/irq-sl28cpld.c
+++ b/drivers/irqchip/irq-sl28cpld.c
@@ -92,4 +92,3 @@ module_platform_driver(sl28cpld_intc_driver);
MODULE_DESCRIPTION("sl28cpld Interrupt Controller Driver");
MODULE_AUTHOR("Michael Walle <michael@walle.cc>");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 16/20] irqchip/irq-sl28cpld: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 16/20] irqchip/irq-sl28cpld: " Nick Alcock
@ 2023-02-28 16:12 ` Michael Walle
0 siblings, 0 replies; 40+ messages in thread
From: Michael Walle @ 2023-02-28 16:12 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Thomas Gleixner, Marc Zyngier
Am 2023-02-28 14:02, schrieb Nick Alcock:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Acked-by: Michael Walle <michael@walle.cc>
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 17/20] ARC: reset: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (15 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 16/20] irqchip/irq-sl28cpld: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:02 ` [PATCH 18/20] " Nick Alcock
` (4 subsequent siblings)
21 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Eugeniy Paltsev,
Philipp Zabel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/reset-axs10x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/reset/reset-axs10x.c b/drivers/reset/reset-axs10x.c
index a854ef41364d6..4cb25b0af8d82 100644
--- a/drivers/reset/reset-axs10x.c
+++ b/drivers/reset/reset-axs10x.c
@@ -81,4 +81,3 @@ builtin_platform_driver(axs10x_reset_driver);
MODULE_AUTHOR("Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>");
MODULE_DESCRIPTION("Synopsys AXS10x reset driver");
-MODULE_LICENSE("GPL v2");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 18/20] ARC: reset: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (16 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 17/20] ARC: reset: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:02 ` [PATCH 19/20] power: " Nick Alcock
` (3 subsequent siblings)
21 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Eugeniy Paltsev,
Philipp Zabel
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/reset-hsdk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/reset/reset-hsdk.c b/drivers/reset/reset-hsdk.c
index 4c7b8647b49ca..92a37f30bd817 100644
--- a/drivers/reset/reset-hsdk.c
+++ b/drivers/reset/reset-hsdk.c
@@ -135,4 +135,3 @@ builtin_platform_driver(hsdk_reset_driver);
MODULE_AUTHOR("Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>");
MODULE_DESCRIPTION("Synopsys HSDK SDP reset driver");
-MODULE_LICENSE("GPL v2");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 19/20] power: reset: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (17 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 18/20] " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:02 ` [PATCH 20/20] soc/tegra: cbb: " Nick Alcock
` (2 subsequent siblings)
21 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Sebastian Reichel,
linux-pm
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org
---
drivers/power/reset/as3722-poweroff.c | 1 -
drivers/power/reset/gpio-poweroff.c | 1 -
drivers/power/reset/gpio-restart.c | 1 -
drivers/power/reset/ltc2952-poweroff.c | 1 -
drivers/power/reset/regulator-poweroff.c | 1 -
drivers/power/reset/restart-poweroff.c | 1 -
drivers/power/reset/tps65086-restart.c | 1 -
7 files changed, 7 deletions(-)
diff --git a/drivers/power/reset/as3722-poweroff.c b/drivers/power/reset/as3722-poweroff.c
index 661e1c67f82ee..80edff1a556f8 100644
--- a/drivers/power/reset/as3722-poweroff.c
+++ b/drivers/power/reset/as3722-poweroff.c
@@ -84,4 +84,3 @@ module_platform_driver(as3722_poweroff_driver);
MODULE_DESCRIPTION("Power off driver for ams AS3722 PMIC Device");
MODULE_ALIAS("platform:as3722-power-off");
MODULE_AUTHOR("Laxman Dewangan <ldewangan@nvidia.com>");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/power/reset/gpio-poweroff.c b/drivers/power/reset/gpio-poweroff.c
index 1c5af2fef1423..84b3c3528afa1 100644
--- a/drivers/power/reset/gpio-poweroff.c
+++ b/drivers/power/reset/gpio-poweroff.c
@@ -105,5 +105,4 @@ module_platform_driver(gpio_poweroff_driver);
MODULE_AUTHOR("Jamie Lentin <jm@lentin.co.uk>");
MODULE_DESCRIPTION("GPIO poweroff driver");
-MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:poweroff-gpio");
diff --git a/drivers/power/reset/gpio-restart.c b/drivers/power/reset/gpio-restart.c
index 5466eeea261cd..35d981d5e6c8f 100644
--- a/drivers/power/reset/gpio-restart.c
+++ b/drivers/power/reset/gpio-restart.c
@@ -139,4 +139,3 @@ module_platform_driver(gpio_restart_driver);
MODULE_AUTHOR("David Riley <davidriley@chromium.org>");
MODULE_DESCRIPTION("GPIO restart driver");
-MODULE_LICENSE("GPL");
diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/ltc2952-poweroff.c
index 65d9528cc9899..eea05921a054b 100644
--- a/drivers/power/reset/ltc2952-poweroff.c
+++ b/drivers/power/reset/ltc2952-poweroff.c
@@ -317,4 +317,3 @@ module_platform_driver(ltc2952_poweroff_driver);
MODULE_AUTHOR("René Moll <rene.moll@xsens.com>");
MODULE_DESCRIPTION("LTC PowerPath power-off driver");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/power/reset/regulator-poweroff.c b/drivers/power/reset/regulator-poweroff.c
index 20701203935f0..7f87fbb8b051e 100644
--- a/drivers/power/reset/regulator-poweroff.c
+++ b/drivers/power/reset/regulator-poweroff.c
@@ -79,5 +79,4 @@ module_platform_driver(regulator_poweroff_driver);
MODULE_AUTHOR("Michael Klein <michael@fossekall.de>");
MODULE_DESCRIPTION("Regulator poweroff driver");
-MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:poweroff-regulator");
diff --git a/drivers/power/reset/restart-poweroff.c b/drivers/power/reset/restart-poweroff.c
index 04d4228119b2c..28f1822db1626 100644
--- a/drivers/power/reset/restart-poweroff.c
+++ b/drivers/power/reset/restart-poweroff.c
@@ -59,5 +59,4 @@ module_platform_driver(restart_poweroff_driver);
MODULE_AUTHOR("Andrew Lunn <andrew@lunn.ch");
MODULE_DESCRIPTION("restart poweroff driver");
-MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:poweroff-restart");
diff --git a/drivers/power/reset/tps65086-restart.c b/drivers/power/reset/tps65086-restart.c
index 78b89f745a3de..5ec819eac7da4 100644
--- a/drivers/power/reset/tps65086-restart.c
+++ b/drivers/power/reset/tps65086-restart.c
@@ -95,4 +95,3 @@ module_platform_driver(tps65086_restart_driver);
MODULE_AUTHOR("Emil Renner Berthing <kernel@esmil.dk>");
MODULE_DESCRIPTION("TPS65086 restart driver");
-MODULE_LICENSE("GPL v2");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 20/20] soc/tegra: cbb: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (18 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 19/20] power: " Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-04-05 13:09 ` (subset) " Thierry Reding
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
2023-03-09 16:14 ` Greg KH
21 siblings, 1 reply; 40+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Thierry Reding,
Jonathan Hunter, linux-tegra
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org
---
drivers/soc/tegra/cbb/tegra194-cbb.c | 1 -
drivers/soc/tegra/cbb/tegra234-cbb.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c
index d4112b683f00f..a2347e5b7c00a 100644
--- a/drivers/soc/tegra/cbb/tegra194-cbb.c
+++ b/drivers/soc/tegra/cbb/tegra194-cbb.c
@@ -2359,4 +2359,3 @@ module_exit(tegra194_cbb_exit);
MODULE_AUTHOR("Sumit Gupta <sumitg@nvidia.com>");
MODULE_DESCRIPTION("Control Backbone error handling driver for Tegra194");
-MODULE_LICENSE("GPL");
diff --git a/drivers/soc/tegra/cbb/tegra234-cbb.c b/drivers/soc/tegra/cbb/tegra234-cbb.c
index f33d094e5ea60..7268bb7ef448f 100644
--- a/drivers/soc/tegra/cbb/tegra234-cbb.c
+++ b/drivers/soc/tegra/cbb/tegra234-cbb.c
@@ -1218,4 +1218,3 @@ static void __exit tegra234_cbb_exit(void)
module_exit(tegra234_cbb_exit);
MODULE_DESCRIPTION("Control Backbone 2.0 error handling driver for Tegra234");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: (subset) [PATCH 20/20] soc/tegra: cbb: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 20/20] soc/tegra: cbb: " Nick Alcock
@ 2023-04-05 13:09 ` Thierry Reding
0 siblings, 0 replies; 40+ messages in thread
From: Thierry Reding @ 2023-04-05 13:09 UTC (permalink / raw)
To: Nick Alcock, mcgrof
Cc: Hitomi Hasegawa, Jonathan Hunter, linux-kernel, linux-modules,
Thierry Reding, linux-tegra
From: Thierry Reding <treding@nvidia.com>
On Tue, 28 Feb 2023 13:02:15 +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> [...]
Applied, thanks!
[20/20] soc/tegra: cbb: remove MODULE_LICENSE in non-modules
(no commit info)
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (19 preceding siblings ...)
2023-02-28 13:02 ` [PATCH 20/20] soc/tegra: cbb: " Nick Alcock
@ 2023-02-28 13:47 ` Geert Uytterhoeven
2023-03-20 11:06 ` Nick Alcock
2023-03-09 16:14 ` Greg KH
21 siblings, 1 reply; 40+ messages in thread
From: Geert Uytterhoeven @ 2023-02-28 13:47 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-clk, linux-gpio, linux-kernel, linux-modules,
linux-perf-users, linux-pm, linux-remoteproc, linux-renesas-soc,
linux-riscv, linux-serial, linux-tegra, linux-trace-devel,
linux-trace-kernel
Hi Nick,
On Tue, Feb 28, 2023 at 2:05 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> This series, based on current modules-next, is part of a treewide cleanup
> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> files/objects that are not tristate. Due to recent changes to kbuild, these
> uses are now problematic. See the commit logs for more details.
Does this mean you expect us to queue them for v6.3?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
@ 2023-03-20 11:06 ` Nick Alcock
0 siblings, 0 replies; 40+ messages in thread
From: Nick Alcock @ 2023-03-20 11:06 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Nick Alcock, mcgrof, linux-clk, linux-gpio, linux-kernel,
linux-modules, linux-perf-users, linux-pm, linux-remoteproc,
linux-renesas-soc, linux-riscv, linux-serial, linux-tegra,
linux-trace-devel, linux-trace-kernel
On 28 Feb 2023, Geert Uytterhoeven outgrape:
> On Tue, Feb 28, 2023 at 2:05 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>> This series, based on current modules-next, is part of a treewide cleanup
>> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
>> files/objects that are not tristate. Due to recent changes to kbuild, these
>> uses are now problematic. See the commit logs for more details.
>
> Does this mean you expect us to queue them for v6.3?
> Thanks!
I believe Luis is planning to pull them in around -rc3, hence my
freshening the series up now, getting everyone's tags in, etc.
--
NULL && (void)
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (20 preceding siblings ...)
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
@ 2023-03-09 16:14 ` Greg KH
21 siblings, 0 replies; 40+ messages in thread
From: Greg KH @ 2023-03-09 16:14 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-clk, linux-gpio, linux-kernel, linux-modules,
linux-perf-users, linux-pm, linux-remoteproc, linux-renesas-soc,
linux-riscv, linux-serial, linux-tegra, linux-trace-devel,
linux-trace-kernel
On Tue, Feb 28, 2023 at 01:01:55PM +0000, Nick Alcock wrote:
> This series, based on current modules-next, is part of a treewide cleanup
> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> files/objects that are not tristate. Due to recent changes to kbuild, these
> uses are now problematic. See the commit logs for more details.
Why isn't kbuild fixed instead? These files can have MODULE_AUTHOR()
and other macros when built into the kernel, what is so special about
MODULE_LICENSE() that prevents this from working properly?
There should not be a need to remove these markings in my opinion, why
treat one MODULE_* macro more special than others?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 40+ messages in thread