Linux-mtd Archive on lore.kernel.org
 help / Atom feed
* [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS
@ 2019-02-07 13:46 Bean Huo (beanhuo)
  2019-02-08 10:26 ` Tudor.Ambarus
  0 siblings, 1 reply; 4+ messages in thread
From: Bean Huo (beanhuo) @ 2019-02-07 13:46 UTC (permalink / raw)
  To: tudor.ambarus, Marek Vasut, David Woodhouse, Brian Norris,
	Boris Brezillon, richard
  Cc: linux-mtd, linux-kernel


Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS.

Signed-off-by: Bean Huo <beanhuo@micron.com>
---
 include/linux/mtd/spi-nor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
index fa2d89e..5e12bf9 100644
--- a/include/linux/mtd/spi-nor.h
+++ b/include/linux/mtd/spi-nor.h
@@ -479,7 +479,7 @@ struct spi_nor_hwcaps {
 #define SNOR_HWCAPS_READ_4_4_4		BIT(9)
 #define SNOR_HWCAPS_READ_1_4_4_DTR	BIT(10)
 
-#define SNOR_HWCPAS_READ_OCTO		GENMASK(14, 11)
+#define SNOR_HWCAPS_READ_OCTO		GENMASK(14, 11)
 #define SNOR_HWCAPS_READ_1_1_8		BIT(11)
 #define SNOR_HWCAPS_READ_1_8_8		BIT(12)
 #define SNOR_HWCAPS_READ_8_8_8		BIT(13)
-- 
2.7.4

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS
  2019-02-07 13:46 [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS Bean Huo (beanhuo)
@ 2019-02-08 10:26 ` Tudor.Ambarus
  2019-02-08 11:39   ` [EXT] " Bean Huo (beanhuo)
  0 siblings, 1 reply; 4+ messages in thread
From: Tudor.Ambarus @ 2019-02-08 10:26 UTC (permalink / raw)
  To: beanhuo, marek.vasut, dwmw2, computersforpeace, bbrezillon, richard
  Cc: linux-mtd, linux-kernel, bbrezillon

Hi, Bean,

SNOR_HWCPAS_READ_OCTO was renamed to SNOR_HWCPAS_READ_OCTAL please update your
remote and send a new patch.

The patch prefix is wrong, it should be prefixed with "mtd: spi-nor:". When in
doubt, you can check how were prefixed previous patches on the same file by
running something like:

git log --oneline include/linux/mtd/spi-nor.h

On 02/07/2019 03:46 PM, Bean Huo (beanhuo) wrote:
> 

This looks like a blank line, it's not needed, remove it please.
> Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS.

Indeed, it is, use imperative, something like: "Fix wrong abbreviation,
s/HWCPAS/HWCAPS"
> 
> Signed-off-by: Bean Huo <beanhuo@micron.com>

Your S-o-b tag doesn't match the author name, please fix this as well.

Cheers,
ta

> ---
>  include/linux/mtd/spi-nor.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index fa2d89e..5e12bf9 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -479,7 +479,7 @@ struct spi_nor_hwcaps {
>  #define SNOR_HWCAPS_READ_4_4_4		BIT(9)
>  #define SNOR_HWCAPS_READ_1_4_4_DTR	BIT(10)
>  
> -#define SNOR_HWCPAS_READ_OCTO		GENMASK(14, 11)
> +#define SNOR_HWCAPS_READ_OCTO		GENMASK(14, 11)
>  #define SNOR_HWCAPS_READ_1_1_8		BIT(11)
>  #define SNOR_HWCAPS_READ_1_8_8		BIT(12)
>  #define SNOR_HWCAPS_READ_8_8_8		BIT(13)
> 
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [EXT] Re: [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS
  2019-02-08 10:26 ` Tudor.Ambarus
@ 2019-02-08 11:39   ` " Bean Huo (beanhuo)
  2019-02-08 12:27     ` Tudor.Ambarus
  0 siblings, 1 reply; 4+ messages in thread
From: Bean Huo (beanhuo) @ 2019-02-08 11:39 UTC (permalink / raw)
  To: Tudor.Ambarus, marek.vasut, dwmw2, computersforpeace, bbrezillon,
	richard
  Cc: linux-mtd, linux-kernel, bbrezillon

Hi, Tudor

>SNOR_HWCPAS_READ_OCTO was renamed to SNOR_HWCPAS_READ_OCTAL
>please update your remote and send a new patch.
>
Which branch do you mean? I checked linux-mtd, not renamed yet.

>The patch prefix is wrong, it should be prefixed with "mtd: spi-nor:". When in
>doubt, you can check how were prefixed previous patches on the same file by
>running something like:
>
>git log --oneline include/linux/mtd/spi-nor.h
>
>On 02/07/2019 03:46 PM, Bean Huo (beanhuo) wrote:
>>
>
>This looks like a blank line, it's not needed, remove it please.
>> Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS.
>
>Indeed, it is, use imperative, something like: "Fix wrong abbreviation,
>s/HWCPAS/HWCAPS"
>>
>> Signed-off-by: Bean Huo <beanhuo@micron.com>
>
>Your S-o-b tag doesn't match the author name, please fix this as well.

It is automatically added by git, what is correct way? 
Thanks,
//Bean

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [EXT] Re: [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS
  2019-02-08 11:39   ` [EXT] " Bean Huo (beanhuo)
@ 2019-02-08 12:27     ` Tudor.Ambarus
  0 siblings, 0 replies; 4+ messages in thread
From: Tudor.Ambarus @ 2019-02-08 12:27 UTC (permalink / raw)
  To: beanhuo, marek.vasut, dwmw2, computersforpeace, bbrezillon, richard
  Cc: linux-mtd, linux-kernel



On 02/08/2019 01:39 PM, Bean Huo (beanhuo) wrote:
> Hi, Tudor
> 
>> SNOR_HWCPAS_READ_OCTO was renamed to SNOR_HWCPAS_READ_OCTAL
>> please update your remote and send a new patch.
>>
> Which branch do you mean? I checked linux-mtd, not renamed yet.

spi-nor/next

> 
>> The patch prefix is wrong, it should be prefixed with "mtd: spi-nor:". When in
>> doubt, you can check how were prefixed previous patches on the same file by
>> running something like:
>>
>> git log --oneline include/linux/mtd/spi-nor.h
>>
>> On 02/07/2019 03:46 PM, Bean Huo (beanhuo) wrote:
>>>
>>
>> This looks like a blank line, it's not needed, remove it please.
>>> Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS.
>>
>> Indeed, it is, use imperative, something like: "Fix wrong abbreviation,
>> s/HWCPAS/HWCAPS"
>>>
>>> Signed-off-by: Bean Huo <beanhuo@micron.com>
>>
>> Your S-o-b tag doesn't match the author name, please fix this as well.
> 
> It is automatically added by git, what is correct way?

Your author name "Bean Huo (beanhuo)" is different than your S-o-b name, "Bean
Huo". Did you add your S-o-b tag by hand? The author name is automatically added
by git, it looks into your ~/.gitconfig file, at [user] name. S-o-b tag can also
be added by git, just use the "-s" option when committing the change: "git
commit -s".

Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-07 13:46 [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS Bean Huo (beanhuo)
2019-02-08 10:26 ` Tudor.Ambarus
2019-02-08 11:39   ` [EXT] " Bean Huo (beanhuo)
2019-02-08 12:27     ` Tudor.Ambarus

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org linux-mtd@archiver.kernel.org
	public-inbox-index linux-mtd


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/ public-inbox