From: Richard Weinberger <richard@nod.at>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Johan Jonker <jbx6244@gmail.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
heiko@sntech.de, linux-mtd <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-rockchip@lists.infradead.org,
yifeng zhao <yifeng.zhao@rock-chips.com>
Subject: Re: [PATCH v3 3/3] mtd: rawnand: rockchip-nand-controller: add skipbbt option
Date: Thu, 13 Jul 2023 17:17:15 +0200 (CEST) [thread overview]
Message-ID: <1618382560.2326931.1689261435022.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20230712154142.3c49d782@xps-13>
----- Ursprüngliche Mail -----
>
>> > For the boot I think I proposed a DT property. I don't remember how far
>> > the discussion went.
>>
>> Is there a web link of that discussion?
>
> https://lore.kernel.org/linux-mtd/20230609104426.3901df54@xps-13/
>
> Maybe the term "DT property" did not appear but that's what I had in
> mind :-) I don't know if it must be a chip or a partition property.
>
> Richard, here is where I would like your feedback, I am kind of opposed
> to a "skip_bbt" module parameter. It's not a strong opinion, if you
> think it's fine I'm open.
>
> I would rather prefer a DT property which says "do not use the
> standard pattern".
Yes, please no new module parameters. A module parameter should only affect
the behavior of the driver itself (e.g. debug mode) but not be device specific.
We made this mistake in the past too often. :-(
A single driver can serve more devices. Therefore IMHO controlling this via DT
makes perfectly sense.
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2023-07-13 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 17:32 [PATCH v3 0/3] Fixes for Rockchip NAND controller driver Johan Jonker
2023-06-15 17:34 ` [PATCH v3 1/3] mtd: rawnand: rockchip-nand-controller: fix oobfree offset and description Johan Jonker
2023-07-04 15:03 ` Miquel Raynal
2023-06-15 17:34 ` [PATCH v3 2/3] mtd: rawnand: rockchip-nand-controller: copy hwecc PA data to oob_poi buffer Johan Jonker
2023-07-04 15:08 ` Miquel Raynal
2023-07-05 18:20 ` Johan Jonker
2023-06-15 17:34 ` [PATCH v3 3/3] mtd: rawnand: rockchip-nand-controller: add skipbbt option Johan Jonker
2023-07-04 15:13 ` Miquel Raynal
2023-07-07 15:27 ` Johan Jonker
2023-07-12 13:57 ` Miquel Raynal
2023-07-13 15:17 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1618382560.2326931.1689261435022.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).