From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com
Subject: Re: [PATCH v3 3/3] mtd: rawnand: rockchip-nand-controller: add skipbbt option
Date: Tue, 4 Jul 2023 17:13:48 +0200 [thread overview]
Message-ID: <20230704171348.5eee98f7@xps-13> (raw)
In-Reply-To: <457c1da7-61dc-2a56-4f86-47413795138c@gmail.com>
Hi Johan,
jbx6244@gmail.com wrote on Thu, 15 Jun 2023 19:34:26 +0200:
> On Rockchip SoCs the first boot stages are written on NAND
> with help of manufacturer software that uses a different format
> then the MTD framework. Skip the automatic BBT scan with the
> NAND_SKIP_BBTSCAN option so that the original content is unchanged
> during the driver probe.
> The NAND_NO_BBM_QUIRK option allows us to erase bad blocks with
> the nand_erase_nand() function and the flash_erase command.
> With these options the user has the "freedom of choice" by neutral
> access mode to read and write in whatever format is needed.
Can the boot_rom_mode thing help?
For writing this part you can disable the bad block protection using
debugfs and then write an externally processed file in raw mode I guess.
For the boot I think I proposed a DT property. I don't remember how far
the discussion went.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>
> Changes V3:
> Change prefixes
>
> Changed V2:
> reword
>
> ---
>
> I'm aware that the maintainer finds it "awful",
> but it's absolute necessary to:
> 1: read/write boot blocks in user space without touching original content
> 2: format a NAND for MTD either with built in or external driver module
>
> So we keep it include in this serie.
> ---
> drivers/mtd/nand/raw/rockchip-nand-controller.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> index 5a0468034..fcda4c760 100644
> --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c
> +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> @@ -188,6 +188,10 @@ struct rk_nfc {
> unsigned long assigned_cs;
> };
>
> +static int skipbbt;
> +module_param(skipbbt, int, 0644);
> +MODULE_PARM_DESC(skipbbt, "Skip BBT scan if data on the NAND chip is not in MTD format.");
> +
> static inline struct rk_nfc_nand_chip *rk_nfc_to_rknand(struct nand_chip *chip)
> {
> return container_of(chip, struct rk_nfc_nand_chip, chip);
> @@ -1153,6 +1157,9 @@ static int rk_nfc_nand_chip_init(struct device *dev, struct rk_nfc *nfc,
>
> nand_set_controller_data(chip, nfc);
>
> + if (skipbbt)
> + chip->options |= NAND_SKIP_BBTSCAN | NAND_NO_BBM_QUIRK;
> +
> chip->options |= NAND_USES_DMA | NAND_NO_SUBPAGE_WRITE;
> chip->bbt_options = NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB;
>
> --
> 2.30.2
>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-07-04 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 17:32 [PATCH v3 0/3] Fixes for Rockchip NAND controller driver Johan Jonker
2023-06-15 17:34 ` [PATCH v3 1/3] mtd: rawnand: rockchip-nand-controller: fix oobfree offset and description Johan Jonker
2023-07-04 15:03 ` Miquel Raynal
2023-06-15 17:34 ` [PATCH v3 2/3] mtd: rawnand: rockchip-nand-controller: copy hwecc PA data to oob_poi buffer Johan Jonker
2023-07-04 15:08 ` Miquel Raynal
2023-07-05 18:20 ` Johan Jonker
2023-06-15 17:34 ` [PATCH v3 3/3] mtd: rawnand: rockchip-nand-controller: add skipbbt option Johan Jonker
2023-07-04 15:13 ` Miquel Raynal [this message]
2023-07-07 15:27 ` Johan Jonker
2023-07-12 13:57 ` Miquel Raynal
2023-07-13 15:17 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704171348.5eee98f7@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).