From: Boris Brezillon <boris.brezillon@collabora.com>
To: masonccyang@mxic.com.tw
Cc: mark.rutland@arm.com, christophe.kerello@st.com,
marcel.ziswiler@toradex.com, stefan@agner.ch,
liang.yang@amlogic.com, linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
lee.jones@linaro.org, richard@nod.at, marek.vasut@gmail.com,
geert@linux-m68k.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, bbrezillon@kernel.org, juliensu@mxic.com.tw,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
paul.burton@mips.com, broonie@kernel.org,
computersforpeace@gmail.com, dwmw2@infradead.org,
zhengxunli@mxic.com.tw
Subject: Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller
Date: Tue, 18 Jun 2019 09:29:01 +0200 [thread overview]
Message-ID: <20190618092901.3bdd9f61@collabora.com> (raw)
In-Reply-To: <20190618081436.5d488320@collabora.com>
On Tue, 18 Jun 2019 08:14:36 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> > > > > >
> > > > > > How to make all #CS keep high for NAND to enter
> > > > > > low-power standby mode if driver don't use "legacy.select_chip()"
> > ?
> > > > >
> > > > > See commit 02b4a52604a4 ("mtd: rawnand: Make ->select_chip()
> > optional
> > > > > when ->exec_op() is implemented") which states:
> > > > >
> > > > > "When [->select_chip() is] not implemented, the core is
> > assuming
> > > > > the CS line is automatically asserted/deasserted by the driver
> > > > > ->exec_op() implementation."
> > > > >
> > > > > Of course, the above is right only when the controller driver
> > supports
> > > > > the ->exec_op() interface.
> > > >
> > > > Currently, it seems that we will get the incorrect data and error
> > > > operation due to CS in error toggling if CS line is controlled in
> > > > ->exec_op().
Oh, and please provide the modifications you added on top of this patch.
Right now we're speculating on what you've done which is definitely not
an efficient way to debug this sort of issues.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-18 7:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 9:23 [PATCH v3 0/4] Add Macronix MX25F0A MFD driver for raw nand and spi Mason Yang
2019-04-15 9:23 ` [PATCH v3 1/4] mfd: Add Macronix MX25F0A MFD controller driver Mason Yang
2019-05-12 13:08 ` Miquel Raynal
2019-05-15 6:46 ` masonccyang
2019-04-15 9:23 ` [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller Mason Yang
2019-05-12 13:18 ` Miquel Raynal
2019-05-15 8:48 ` masonccyang
2019-05-15 12:08 ` Miquel Raynal
[not found] ` <OF8A566F14.A2F0F576-ON482583FB.002E7E32-482583FB.003068B1@LocalDomain>
2019-05-15 9:18 ` masonccyang
2019-05-17 9:30 ` masonccyang
2019-05-20 12:23 ` Miquel Raynal
2019-05-23 8:58 ` masonccyang
2019-05-27 12:42 ` Miquel Raynal
2019-05-29 3:12 ` masonccyang
2019-06-17 12:35 ` Miquel Raynal
2019-06-18 1:24 ` masonccyang
2019-06-18 6:14 ` Boris Brezillon
2019-06-18 7:29 ` Boris Brezillon [this message]
2019-06-19 8:04 ` masonccyang
2019-06-19 8:09 ` Miquel Raynal
2019-06-19 8:48 ` masonccyang
2019-06-24 9:05 ` masonccyang
2019-06-19 8:15 ` Boris Brezillon
2019-06-19 8:55 ` masonccyang
2019-06-19 9:06 ` Boris Brezillon
2019-06-24 8:55 ` masonccyang
2019-04-15 9:23 ` [PATCH v3 3/4] spi: Patch Macronix SPI controller driver according to MX25F0A MFD driver Mason Yang
2019-04-19 14:51 ` Mark Brown
[not found] ` <OF7742B4A9.445066F6-ON482583EC.0037E377-482583EC.0039125B@mxic.com.tw>
2019-05-02 2:41 ` Mark Brown
2019-04-15 9:23 ` [PATCH v3 4/4] dt-bindings: mfd: Document Macronix MX25F0A controller bindings Mason Yang
2019-04-26 22:41 ` Rob Herring
2019-05-12 13:23 ` Miquel Raynal
2019-05-15 7:36 ` masonccyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618092901.3bdd9f61@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=christophe.kerello@st.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=geert@linux-m68k.org \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=liang.yang@amlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=paul.burton@mips.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).