* [PATCH] mtd: rawnand: meson: Add of_node_put() before return
@ 2019-07-09 17:16 Nishka Dasgupta
2019-07-18 3:58 ` Liang Yang
2019-07-25 7:55 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Nishka Dasgupta @ 2019-07-09 17:16 UTC (permalink / raw)
To: miquel.raynal, richard, dwmw2, computersforpeace, marek.vasut,
vigneshr, linux-mtd, linux-amlogic, linux-arm-kernel, khilman,
liang.yang
Cc: Nishka Dasgupta
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/mtd/nand/raw/meson_nand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
index ea57ddcec41e..1b82b687e5a5 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -1320,6 +1320,7 @@ static int meson_nfc_nand_chips_init(struct device *dev,
ret = meson_nfc_nand_chip_init(dev, nfc, nand_np);
if (ret) {
meson_nfc_nand_chip_cleanup(nfc);
+ of_node_put(nand_np);
return ret;
}
}
--
2.19.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: rawnand: meson: Add of_node_put() before return
2019-07-09 17:16 [PATCH] mtd: rawnand: meson: Add of_node_put() before return Nishka Dasgupta
@ 2019-07-18 3:58 ` Liang Yang
2019-07-25 7:55 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Liang Yang @ 2019-07-18 3:58 UTC (permalink / raw)
To: Nishka Dasgupta, miquel.raynal, richard, dwmw2,
computersforpeace, marek.vasut, vigneshr, linux-mtd,
linux-amlogic, linux-arm-kernel, khilman
Hi Nishka,
On 2019/7/10 1:16, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/mtd/nand/raw/meson_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index ea57ddcec41e..1b82b687e5a5 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -1320,6 +1320,7 @@ static int meson_nfc_nand_chips_init(struct device *dev,
> ret = meson_nfc_nand_chip_init(dev, nfc, nand_np);
> if (ret) {
> meson_nfc_nand_chip_cleanup(nfc);
> + of_node_put(nand_np);
Thank you. Looks good to me:
Acked-by: Liang Yang <liang.yang@amlogic.com>
> return ret;
> }
> }
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: rawnand: meson: Add of_node_put() before return
2019-07-09 17:16 [PATCH] mtd: rawnand: meson: Add of_node_put() before return Nishka Dasgupta
2019-07-18 3:58 ` Liang Yang
@ 2019-07-25 7:55 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2019-07-25 7:55 UTC (permalink / raw)
To: Nishka Dasgupta, miquel.raynal, richard, dwmw2,
computersforpeace, marek.vasut, vigneshr, linux-mtd,
linux-amlogic, linux-arm-kernel, khilman, liang.yang
On Tue, 2019-07-09 at 17:16:40 UTC, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> Acked-by: Liang Yang <liang.yang@amlogic.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-25 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09 17:16 [PATCH] mtd: rawnand: meson: Add of_node_put() before return Nishka Dasgupta
2019-07-18 3:58 ` Liang Yang
2019-07-25 7:55 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).