From: Krzysztof Kozlowski <krzk@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Arnd Bergmann <arnd@arndb.de>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org,
Harvey Hunt <harveyhuntnexus@gmail.com>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to architecture only
Date: Fri, 24 Jul 2020 17:54:36 +0200 [thread overview]
Message-ID: <20200724155436.GA7460@kozik-lap> (raw)
In-Reply-To: <IBDZDQ.K28R5FAI0BXI2@crapouillou.net>
On Fri, Jul 24, 2020 at 05:50:06PM +0200, Paul Cercueil wrote:
>
>
> Le ven. 24 juil. 2020 à 17:33, Krzysztof Kozlowski <krzk@kernel.org> a écrit
> :
> > On Fri, 24 Jul 2020 at 17:19, Paul Cercueil <paul@crapouillou.net>
> > wrote:
> > >
> > > Hi Krzysztof,
> > >
> > >
> > > Le ven. 24 juil. 2020 à 16:54, Krzysztof Kozlowski
> > > <krzk@kernel.org> a
> > > écrit :
> > > > Enabling the MTD_NAND_JZ4780 driver makes sense only for specific
> > > > hardware - the Ingenic SoC architecture. Set it's dependency to
> > > > MACH_INGENIC so it will not appear on unrelated architectures
> > > (easier
> > > > job for downstream/distro kernel engineers).
> > >
> > > Disagreed. It was done this way so that distro kernels can support
> > > multiple SoCs.
> >
> > They will still be able to support multiple SoCs. Nothing changed
> > here. The same we do for all ARM drivers (SoCs are multiplatform)...
> > Unless you want to say that it is possible to support Ingenic SoC
> > without MACH_INGENIC?
>
> On MIPS, the SoC selection is a Kconfig "choice", so you can only support
> one SoC family, unfortunately.
Let's say someone selected then some other architecture (MIPS_ALCHEMY).
They could select this MTD driver.
Does it mean they would be able to run it on Ingenic hardware?
> I'm the one to blame for using "depends on
> MIPS || COMPILE_TEST" on ingenic drivers, maybe it should depend on
> MACH_INGENIC indeed, but then it should be made possible to support more
> than one SoC family.
>
> That's something that should be pointed out to the MIPS mailing list, I
> believe.
Somehow JZ4780 entries in Maintainers do not mention MIPS list...
>
> Btw: Does that mean you are the new maintainer for drivers/memory/?
Yes, that's the coming change.
https://lore.kernel.org/lkml/20200724140345.GB13472@kozik-lap/T/#m91ca20920a7ec5f228a595f1816c15b6c85b6a09
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-07-24 15:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 14:53 [PATCH v3 0/2] mips: jz4780: Kconfig cleanup Krzysztof Kozlowski
2020-07-24 14:54 ` [PATCH v3 1/2] memory: jz4780-nemc: Limit dependency and compile testing to Ingenic architecture only Krzysztof Kozlowski
2020-07-24 14:54 ` [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to " Krzysztof Kozlowski
2020-07-24 15:19 ` Paul Cercueil
2020-07-24 15:33 ` Krzysztof Kozlowski
2020-07-24 15:50 ` Paul Cercueil
2020-07-24 15:54 ` Krzysztof Kozlowski [this message]
2020-07-25 12:17 ` Paul Cercueil
2020-07-25 18:30 ` Arnd Bergmann
2020-07-26 16:06 ` Paul Cercueil
2020-07-26 16:06 ` Krzysztof Kozlowski
2020-07-26 16:12 ` Paul Cercueil
2020-07-26 16:15 ` Krzysztof Kozlowski
2020-07-26 16:20 ` Paul Cercueil
2020-07-27 7:55 ` Arnd Bergmann
2020-07-27 17:03 ` Krzysztof Kozlowski
2020-07-27 17:12 ` Paul Cercueil
2020-07-27 17:28 ` Arnd Bergmann
2020-08-03 8:36 ` Miquel Raynal
2020-08-03 8:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724155436.GA7460@kozik-lap \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=harveyhuntnexus@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).