Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Richard Weinberger <richard@nod.at>,
	linux-kernel@vger.kernel.org,
	Harvey Hunt <harveyhuntnexus@gmail.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to architecture only
Date: Sun, 26 Jul 2020 18:20:35 +0200
Message-ID: <B243EQ.VEXGA7ZL5JAE2@crapouillou.net> (raw)
In-Reply-To: <20200726161545.GA6058@kozik-lap>



Le dim. 26 juil. 2020 à 18:15, Krzysztof Kozlowski <krzk@kernel.org> a 
écrit :
> On Sun, Jul 26, 2020 at 06:12:27PM +0200, Paul Cercueil wrote:
>> 
>> 
>>  Le dim. 26 juil. 2020 à 18:06, Krzysztof Kozlowski 
>> <krzk@kernel.org> a écrit
>>  :
>>  > On Sat, Jul 25, 2020 at 08:30:56PM +0200, Arnd Bergmann wrote:
>>  > >  On Sat, Jul 25, 2020 at 2:17 PM Paul Cercueil
>>  > > <paul@crapouillou.net> wrote:
>>  > >  > Le ven. 24 juil. 2020 à 17:54, Krzysztof Kozlowski
>>  > > <krzk@kernel.org> a
>>  > >  > écrit :
>>  > >  > > On Fri, Jul 24, 2020 at 05:50:06PM +0200, Paul Cercueil 
>> wrote:
>>  > >  > >>  Le ven. 24 juil. 2020 à 17:33, Krzysztof Kozlowski
>>  > >  > >> <krzk@kernel.org> a écrit:
>>  > >  > >>  > On Fri, 24 Jul 2020 at 17:19, Paul Cercueil
>>  > > <paul@crapouillou.net>
>>  > >  > >>  > wrote:
>>  > >  > >>
>>  > >  > >>  On MIPS, the SoC selection is a Kconfig "choice", so you 
>> can
>>  > > only
>>  > >  > >> support
>>  > >  > >>  one SoC family, unfortunately.
>>  > >  > >
>>  > >  > > Let's say someone selected then some other architecture
>>  > >  > > (MIPS_ALCHEMY).
>>  > >  > > They could select this MTD driver.
>>  > >  > >
>>  > >  > > Does it mean they would be able to run it on Ingenic 
>> hardware?
>>  > >  >
>>  > >  > In *theory* yes, as long as the Kconfig options that 
>> MACH_INGENIC
>>  > >  > selects are enabled, the kernel should boot and work on 
>> Ingenic
>>  > > SoCs.
>>  > >
>>  > >  Right now, this won't work yet, because there are platform 
>> specific
>>  > >  functions that are implemented by each of the platforms in
>>  > > arch/mips,
>>  > >  e.g. arch/mips/generic/init.c and arch/mips/jz4740/setup.c.
>>  >
>>  > I would say even more - no DTS would be provided for such 
>> configuration.
>>  > All Ingenic DTSes are included only with MACH_INGENIC.  You 
>> cannot build
>>  > a kernel working on Ingenic without MACH_INGENIC. Even in theory.
>> 
>>  But the devicetree doesn't have to be built-in.
>> 
> 
> OK, that's true. Anyway, I don't have strong opinion on any of this. I
> just followed Arnd's hint.
> 
> For the memory driver (and MTD NAND as well) which one you prefer:
> 1. https://lore.kernel.org/lkml/20200724074038.5597-6-krzk@kernel.org/
> 2. depends on MACH_INGENIC || MIPS_GENERIC || COMPILE_TEST
> 
> ?

I'd say a slightly modified #1. The driver shouldn't be "default y" in 
the first place, so the patch could be to disable it by default. And 
when the Ingenic code is merged into the MIPS generic framework, I'll 
send a set of patches to change all driver dependencies on MIPS to 
MIPS_GENERIC.

-Paul



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 14:53 [PATCH v3 0/2] mips: jz4780: Kconfig cleanup Krzysztof Kozlowski
2020-07-24 14:54 ` [PATCH v3 1/2] memory: jz4780-nemc: Limit dependency and compile testing to Ingenic architecture only Krzysztof Kozlowski
2020-07-24 14:54 ` [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to " Krzysztof Kozlowski
2020-07-24 15:19   ` Paul Cercueil
2020-07-24 15:33     ` Krzysztof Kozlowski
2020-07-24 15:50       ` Paul Cercueil
2020-07-24 15:54         ` Krzysztof Kozlowski
2020-07-25 12:17           ` Paul Cercueil
2020-07-25 18:30             ` Arnd Bergmann
2020-07-26 16:06               ` Paul Cercueil
2020-07-26 16:06               ` Krzysztof Kozlowski
2020-07-26 16:12                 ` Paul Cercueil
2020-07-26 16:15                   ` Krzysztof Kozlowski
2020-07-26 16:20                     ` Paul Cercueil [this message]
2020-07-27  7:55                       ` Arnd Bergmann
2020-07-27 17:03                         ` Krzysztof Kozlowski
2020-07-27 17:12                           ` Paul Cercueil
2020-07-27 17:28                           ` Arnd Bergmann
2020-08-03  8:36                             ` Miquel Raynal
2020-08-03  8:39                               ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B243EQ.VEXGA7ZL5JAE2@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=arnd@arndb.de \
    --cc=harveyhuntnexus@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git