[PATCH] mtd: remove unneeded break

[PATCH] mtd: remove unneeded break

[trix]

From: Tom Rix <trix@redhat.com>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/mtd/mtdchar.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index b40f46a43fc6..323035d4f2d0 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -881,7 +881,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
 		if (copy_from_user(&offs, argp, sizeof(loff_t)))
 			return -EFAULT;
 		return mtd_block_isbad(mtd, offs);
-		break;
 	}
 
 	case MEMSETBADBLOCK:
@@ -891,7 +890,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
 		if (copy_from_user(&offs, argp, sizeof(loff_t)))
 			return -EFAULT;
 		return mtd_block_markbad(mtd, offs);
-		break;
 	}
 
 	case OTPSELECT:
-- 
2.18.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: remove unneeded break

[Richard Weinberger]

On Mon, Oct 19, 2020 at 9:23 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/mtd/mtdchar.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
> index b40f46a43fc6..323035d4f2d0 100644
> --- a/drivers/mtd/mtdchar.c
> +++ b/drivers/mtd/mtdchar.c
> @@ -881,7 +881,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
>                         return -EFAULT;
>                 return mtd_block_isbad(mtd, offs);
> -               break;
>         }
>
>         case MEMSETBADBLOCK:
> @@ -891,7 +890,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
>                         return -EFAULT;
>                 return mtd_block_markbad(mtd, offs);
> -               break;

Acked-by: Richard Weinberger <richard@nod.at>

Do you want to route this patch through mtd or do you carry it?

-- 
Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: remove unneeded break

[Tom Rix]

On 10/19/20 1:04 PM, Richard Weinberger wrote:
> On Mon, Oct 19, 2020 at 9:23 PM <trix@redhat.com> wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> A break is not needed if it is preceded by a return
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>  drivers/mtd/mtdchar.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
>> index b40f46a43fc6..323035d4f2d0 100644
>> --- a/drivers/mtd/mtdchar.c
>> +++ b/drivers/mtd/mtdchar.c
>> @@ -881,7 +881,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>>                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
>>                         return -EFAULT;
>>                 return mtd_block_isbad(mtd, offs);
>> -               break;
>>         }
>>
>>         case MEMSETBADBLOCK:
>> @@ -891,7 +890,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>>                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
>>                         return -EFAULT;
>>                 return mtd_block_markbad(mtd, offs);
>> -               break;
> Acked-by: Richard Weinberger <richard@nod.at>
>
> Do you want to route this patch through mtd or do you carry it?

Not sure if this question is for me.

I do not maintain a subsystem/branch, so through mtd is what i was assuming.

Tom

>


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: remove unneeded break

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Tom Rix" <trix@redhat.com>
> An: "Richard Weinberger" <richard.weinberger@gmail.com>
> CC: "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>,
> "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>
> Gesendet: Dienstag, 20. Oktober 2020 16:00:37
> Betreff: Re: [PATCH] mtd: remove unneeded break
>> Acked-by: Richard Weinberger <richard@nod.at>
>>
>> Do you want to route this patch through mtd or do you carry it?
> 
> Not sure if this question is for me.

It was. :-)
 
> I do not maintain a subsystem/branch, so through mtd is what i was assuming.

Okay, then let's carry this one through mtd.
Global cleanups go sometimes in a dedicated tree directly to Linus.

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: remove unneeded break

[Miquel Raynal]

On Mon, 2020-10-19 at 19:16:31 UTC, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> A break is not needed if it is preceded by a return
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> Acked-by: Richard Weinberger <richard@nod.at>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/