* [PATCH] mtd: remove unneeded break
@ 2020-10-19 19:16 trix
2020-10-19 20:04 ` Richard Weinberger
2020-10-28 10:58 ` Miquel Raynal
0 siblings, 2 replies; 5+ messages in thread
From: trix @ 2020-10-19 19:16 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr; +Cc: Tom Rix, linux-mtd, linux-kernel
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/mtd/mtdchar.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index b40f46a43fc6..323035d4f2d0 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -881,7 +881,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
if (copy_from_user(&offs, argp, sizeof(loff_t)))
return -EFAULT;
return mtd_block_isbad(mtd, offs);
- break;
}
case MEMSETBADBLOCK:
@@ -891,7 +890,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
if (copy_from_user(&offs, argp, sizeof(loff_t)))
return -EFAULT;
return mtd_block_markbad(mtd, offs);
- break;
}
case OTPSELECT:
--
2.18.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: remove unneeded break
2020-10-19 19:16 [PATCH] mtd: remove unneeded break trix
@ 2020-10-19 20:04 ` Richard Weinberger
2020-10-20 14:00 ` Tom Rix
2020-10-28 10:58 ` Miquel Raynal
1 sibling, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2020-10-19 20:04 UTC (permalink / raw)
To: trix
Cc: Richard Weinberger, linux-mtd, Vignesh Raghavendra, LKML, Miquel Raynal
On Mon, Oct 19, 2020 at 9:23 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/mtd/mtdchar.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
> index b40f46a43fc6..323035d4f2d0 100644
> --- a/drivers/mtd/mtdchar.c
> +++ b/drivers/mtd/mtdchar.c
> @@ -881,7 +881,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
> if (copy_from_user(&offs, argp, sizeof(loff_t)))
> return -EFAULT;
> return mtd_block_isbad(mtd, offs);
> - break;
> }
>
> case MEMSETBADBLOCK:
> @@ -891,7 +890,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
> if (copy_from_user(&offs, argp, sizeof(loff_t)))
> return -EFAULT;
> return mtd_block_markbad(mtd, offs);
> - break;
Acked-by: Richard Weinberger <richard@nod.at>
Do you want to route this patch through mtd or do you carry it?
--
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: remove unneeded break
2020-10-19 20:04 ` Richard Weinberger
@ 2020-10-20 14:00 ` Tom Rix
2020-10-20 14:20 ` Richard Weinberger
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2020-10-20 14:00 UTC (permalink / raw)
To: Richard Weinberger
Cc: Richard Weinberger, linux-mtd, Vignesh Raghavendra, LKML, Miquel Raynal
On 10/19/20 1:04 PM, Richard Weinberger wrote:
> On Mon, Oct 19, 2020 at 9:23 PM <trix@redhat.com> wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> A break is not needed if it is preceded by a return
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/mtd/mtdchar.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
>> index b40f46a43fc6..323035d4f2d0 100644
>> --- a/drivers/mtd/mtdchar.c
>> +++ b/drivers/mtd/mtdchar.c
>> @@ -881,7 +881,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>> if (copy_from_user(&offs, argp, sizeof(loff_t)))
>> return -EFAULT;
>> return mtd_block_isbad(mtd, offs);
>> - break;
>> }
>>
>> case MEMSETBADBLOCK:
>> @@ -891,7 +890,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>> if (copy_from_user(&offs, argp, sizeof(loff_t)))
>> return -EFAULT;
>> return mtd_block_markbad(mtd, offs);
>> - break;
> Acked-by: Richard Weinberger <richard@nod.at>
>
> Do you want to route this patch through mtd or do you carry it?
Not sure if this question is for me.
I do not maintain a subsystem/branch, so through mtd is what i was assuming.
Tom
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: remove unneeded break
2020-10-20 14:00 ` Tom Rix
@ 2020-10-20 14:20 ` Richard Weinberger
0 siblings, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2020-10-20 14:20 UTC (permalink / raw)
To: Tom Rix
Cc: Richard Weinberger, linux-kernel, linux-mtd, Vignesh Raghavendra,
Miquel Raynal
----- Ursprüngliche Mail -----
> Von: "Tom Rix" <trix@redhat.com>
> An: "Richard Weinberger" <richard.weinberger@gmail.com>
> CC: "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>,
> "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>
> Gesendet: Dienstag, 20. Oktober 2020 16:00:37
> Betreff: Re: [PATCH] mtd: remove unneeded break
>> Acked-by: Richard Weinberger <richard@nod.at>
>>
>> Do you want to route this patch through mtd or do you carry it?
>
> Not sure if this question is for me.
It was. :-)
> I do not maintain a subsystem/branch, so through mtd is what i was assuming.
Okay, then let's carry this one through mtd.
Global cleanups go sometimes in a dedicated tree directly to Linus.
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: remove unneeded break
2020-10-19 19:16 [PATCH] mtd: remove unneeded break trix
2020-10-19 20:04 ` Richard Weinberger
@ 2020-10-28 10:58 ` Miquel Raynal
1 sibling, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2020-10-28 10:58 UTC (permalink / raw)
To: trix, miquel.raynal, richard, vigneshr; +Cc: linux-mtd, linux-kernel
On Mon, 2020-10-19 at 19:16:31 UTC, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> Acked-by: Richard Weinberger <richard@nod.at>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-28 10:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 19:16 [PATCH] mtd: remove unneeded break trix
2020-10-19 20:04 ` Richard Weinberger
2020-10-20 14:00 ` Tom Rix
2020-10-20 14:20 ` Richard Weinberger
2020-10-28 10:58 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).