From: "Marty E. Plummer" <hanetzer@startmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: arnd@arndb.de, cai.huoqing@linux.dev, christian.koenig@amd.com,
devicetree@vger.kernel.org, gengdongjiu@huawei.com,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux@armlinux.org.uk, michael@walle.cc,
miquel.raynal@bootlin.com, mturquette@baylibre.com,
novikov@ispras.ru, olof@lixom.net, p.yadav@ti.com,
rdunlap@infradead.org, richard@nod.at, robh+dt@kernel.org,
sboyd@kernel.org, soc@kernel.org, sumit.semwal@linaro.org,
tudor.ambarus@microchip.com, vigneshr@ti.com,
xuwei5@hisilicon.com
Subject: Re: [RFC v2 1/2] clk: hisilicon: add CRG driver Hi3521a SoC
Date: Wed, 1 Jun 2022 13:24:18 -0500 [thread overview]
Message-ID: <20220601182418.okoofgannw6vbcxo@proprietary-killer> (raw)
In-Reply-To: <a2a98c6d-2ff7-89f6-0711-c8f8b99e85c2@linaro.org>
On Wed, Jun 01, 2022 at 01:09:28PM +0200, Krzysztof Kozlowski wrote:
> On 01/06/2022 13:06, Marty E. Plummer wrote:
> > On Wed, Jun 01, 2022 at 01:00:38PM +0200, Krzysztof Kozlowski wrote:
> >> On 01/06/2022 12:58, Marty E. Plummer wrote:
> >>> On Tue, May 03, 2022 at 01:37:42PM +0200, Krzysztof Kozlowski wrote:
> >>>> On 01/05/2022 19:34, Marty E. Plummer wrote:
> >>>>> Add CRG driver for Hi3521A SoC. CRG (Clock and Reset Generator) module
> >>>>> generates clock and reset signals used by other module blocks on SoC.
> >>>>>
> >>>>> Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
> >>>>> ---
> >>>>> drivers/clk/hisilicon/Kconfig | 8 ++
> >>>>> drivers/clk/hisilicon/Makefile | 1 +
> >>>>> drivers/clk/hisilicon/crg-hi3521a.c | 141 ++++++++++++++++++++++
> >>>>> include/dt-bindings/clock/hi3521a-clock.h | 34 ++++++
> >>>>
> >>>> Bindings go to separate patch. Your patchset is unmerge'able.
> >>>>
> >>> So, assuming I have the following patches:
> >>> 1: +include/dt-bindings/clock/hi3521a-clock.h
> >>> 2: +drivers/clk/hisilicon/crg-hi3521a.c
> >>> 3: +Documentation/devicetree/bindings/whatever
> >>>
> >>> In what order should they be applied?
> >>
> >> Applied or sent? The maintainer will apply them in proper order, this is
> >> bisectable.
> >>
> >>
> > Either or. Whatever makes the workload easier is what I'm looking for.
>
> Sorry, you need to be more specific. Apply is not a job for you, for the
> patch submitter.
>
> Then you miss here important piece - which is the first patch. DTS goes
> always via separate branch (or even tree) from driver changes. That's
> why bindings are always separate first patches.
>
So, add a 4: arch/arm/boot/dts/soc.dtsi and 5: arch/arm/boot/dts/board.dts
to the above list, or should those be the same patch as well?
> Best regards,
> Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-06-01 18:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 5:44 [PATCH 0/2] Hi3521a support Marty E. Plummer
[not found] ` <20220501173423.2473093-1-hanetzer@startmail.com>
2022-05-03 11:37 ` [RFC v2 " Krzysztof Kozlowski
[not found] ` <20220501173423.2473093-2-hanetzer@startmail.com>
2022-05-03 11:37 ` [RFC v2 1/2] clk: hisilicon: add CRG driver Hi3521a SoC Krzysztof Kozlowski
2022-06-01 10:58 ` Marty E. Plummer
2022-06-01 11:00 ` Krzysztof Kozlowski
2022-06-01 11:06 ` Marty E. Plummer
2022-06-01 11:09 ` Krzysztof Kozlowski
2022-06-01 18:24 ` Marty E. Plummer [this message]
2022-06-02 6:37 ` Krzysztof Kozlowski
2022-06-03 11:22 ` Marty E. Plummer
2022-06-05 14:54 ` Krzysztof Kozlowski
2022-06-06 7:29 ` Krzysztof Kozlowski
2022-06-06 11:34 ` Marty E. Plummer
[not found] ` <20220501173423.2473093-3-hanetzer@startmail.com>
2022-05-03 11:47 ` [RFC v2 2/2] arm: hisi: enable Hi3521a soc Krzysztof Kozlowski
2022-05-03 13:44 ` Marty E. Plummer
2022-05-03 14:55 ` Krzysztof Kozlowski
2022-05-03 15:51 ` Marty E. Plummer
2022-05-03 15:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601182418.okoofgannw6vbcxo@proprietary-killer \
--to=hanetzer@startmail.com \
--cc=arnd@arndb.de \
--cc=cai.huoqing@linux.dev \
--cc=christian.koenig@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=gengdongjiu@huawei.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=novikov@ispras.ru \
--cc=olof@lixom.net \
--cc=p.yadav@ti.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).