From: <Tudor.Ambarus@microchip.com> To: <boris.brezillon@collabora.com> Cc: vigneshr@ti.com, richard@nod.at, linux-kernel@vger.kernel.org, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com, dwmw2@infradead.org Subject: Re: [PATCH 4/6] mtd: spi_nor: Add nor->setup() method Date: Mon, 5 Aug 2019 06:37:42 +0000 Message-ID: <a3a41a83-0726-0aea-bb92-db6ef1a465b2@microchip.com> (raw) In-Reply-To: <20190801083652.52bffef5@collabora.com> On 08/01/2019 09:36 AM, Boris Brezillon wrote: > On Wed, 31 Jul 2019 09:12:14 +0000 > <Tudor.Ambarus@microchip.com> wrote: > > >> static inline bool spi_nor_protocol_is_dtr(enum spi_nor_protocol proto) >> { >> return !!(proto & SNOR_PROTO_IS_DTR); >> @@ -384,6 +522,7 @@ struct flash_info; >> * useful when pagesize is not a power-of-2 >> * @disable_write_protection: [FLASH-SPECIFIC] disable write protection during >> * power-up >> + * @setup: [FLASH-SPECIFIC] configure the spi-nor memory > > Might be worth giving a example of the type of configuration that can > be done here. will do > > The patch looks good otherwise. > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > >> * completely locked > > Looks like this 'completely locked' is a leftover from a previous move > (lock functions were move to a separate _ops struct IIRC). Can you fix > that? there's already a patch on ML for this, I'll apply it. Thanks, ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply index Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-31 9:12 [PATCH 0/6] mtd: spi-nor: move manuf out of the core - batch 2 Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 1/6] mtd: spi-nor: Add post_sfdp() hook to tweak flash config Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 2/6] mtd: spi-nor: Add spansion_post_sfdp_fixups() Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 3/6] mtd: spi-nor: Add a ->convert_addr() method Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 4/6] mtd: spi_nor: Add nor->setup() method Tudor.Ambarus 2019-08-01 6:36 ` Boris Brezillon 2019-08-05 6:37 ` Tudor.Ambarus [this message] 2019-07-31 9:12 ` [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() Tudor.Ambarus 2019-07-31 12:31 ` Naga Sureshkumar Relli 2019-07-31 12:38 ` Boris Brezillon 2019-08-01 4:47 ` Naga Sureshkumar Relli 2019-07-31 13:06 ` Tudor.Ambarus 2019-08-01 4:47 ` Naga Sureshkumar Relli 2019-08-01 6:42 ` Boris Brezillon 2019-08-05 6:40 ` Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 6/6] mtd: spi-nor: Add the SPI_NOR_XSR_RDY flag Tudor.Ambarus 2019-08-05 5:14 ` Vignesh Raghavendra 2019-08-05 7:32 ` Tudor.Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a3a41a83-0726-0aea-bb92-db6ef1a465b2@microchip.com \ --to=tudor.ambarus@microchip.com \ --cc=boris.brezillon@collabora.com \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mtd Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \ linux-mtd@lists.infradead.org public-inbox-index linux-mtd Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd AGPL code for this site: git clone https://public-inbox.org/public-inbox.git