* [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa
@ 2021-06-20 8:56 Sungbo Eo
2021-07-16 16:11 ` Michael Walle
2021-07-19 15:20 ` [PATCH v2] " Sungbo Eo
0 siblings, 2 replies; 8+ messages in thread
From: Sungbo Eo @ 2021-06-20 8:56 UTC (permalink / raw)
To: linux-mtd
Cc: Tudor Ambarus, Michael Walle, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Sungbo Eo
The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn bits
are non-volatile, unlike its older version.
References: https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA.pdf
References: https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA_1(2S).pdf
Signed-off-by: Sungbo Eo <mans0n@gorani.run>
---
At first I was going to send a new support patch of F25L16PA(2S),
but before that, I wanted to make sure if "(2s)" suffix is okay or unnecessary.
---
drivers/mtd/spi-nor/esmt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
index cfc9218c1053..51b3ff764ef6 100644
--- a/drivers/mtd/spi-nor/esmt.c
+++ b/drivers/mtd/spi-nor/esmt.c
@@ -12,8 +12,8 @@ static const struct flash_info esmt_parts[] = {
/* ESMT */
{ "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) },
- { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
- SECT_4K | SPI_NOR_HAS_LOCK) },
+ { "f25l32qa(2s)", INFO(0x8c4116, 0, 64 * 1024, 64,
+ SECT_4K | SPI_NOR_HAS_LOCK) },
{ "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128,
SECT_4K | SPI_NOR_HAS_LOCK) },
};
--
2.32.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa
2021-06-20 8:56 [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa Sungbo Eo
@ 2021-07-16 16:11 ` Michael Walle
2021-07-19 15:19 ` Sungbo Eo
2021-07-19 15:20 ` [PATCH v2] " Sungbo Eo
1 sibling, 1 reply; 8+ messages in thread
From: Michael Walle @ 2021-07-16 16:11 UTC (permalink / raw)
To: Sungbo Eo
Cc: linux-mtd, Tudor Ambarus, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Am 2021-06-20 10:56, schrieb Sungbo Eo:
> The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
> 0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn
> bits
> are non-volatile, unlike its older version.
>
> References:
> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA.pdf
> References:
> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA_1(2S).pdf
"Datasheet:" please
> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
> ---
> At first I was going to send a new support patch of F25L16PA(2S),
> but before that, I wanted to make sure if "(2s)" suffix is okay or
> unnecessary.
> ---
> drivers/mtd/spi-nor/esmt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
> index cfc9218c1053..51b3ff764ef6 100644
> --- a/drivers/mtd/spi-nor/esmt.c
> +++ b/drivers/mtd/spi-nor/esmt.c
> @@ -12,8 +12,8 @@ static const struct flash_info esmt_parts[] = {
> /* ESMT */
> { "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
> SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) },
> - { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
> - SECT_4K | SPI_NOR_HAS_LOCK) },
> + { "f25l32qa(2s)", INFO(0x8c4116, 0, 64 * 1024, 64,
> + SECT_4K | SPI_NOR_HAS_LOCK) },
> { "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128,
> SECT_4K | SPI_NOR_HAS_LOCK) },
> };
Tudor has decide on that name - or the use of parentheses. I don't have
a
strong opinion on it.
FWIW,
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa
2021-07-16 16:11 ` Michael Walle
@ 2021-07-19 15:19 ` Sungbo Eo
2021-07-21 7:32 ` Michael Walle
0 siblings, 1 reply; 8+ messages in thread
From: Sungbo Eo @ 2021-07-19 15:19 UTC (permalink / raw)
To: Michael Walle
Cc: linux-mtd, Tudor Ambarus, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
On 2021-07-17 01:11, Michael Walle wrote:
> Am 2021-06-20 10:56, schrieb Sungbo Eo:
>> The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
>> 0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn bits
>> are non-volatile, unlike its older version.
>>
>> References:
>> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA.pdf
>> References:
>> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA_1(2S).pdf
>
> "Datasheet:" please
>
>> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
>> ---
>> At first I was going to send a new support patch of F25L16PA(2S),
>> but before that, I wanted to make sure if "(2s)" suffix is okay or
>> unnecessary.
>> ---
>> drivers/mtd/spi-nor/esmt.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
>> index cfc9218c1053..51b3ff764ef6 100644
>> --- a/drivers/mtd/spi-nor/esmt.c
>> +++ b/drivers/mtd/spi-nor/esmt.c
>> @@ -12,8 +12,8 @@ static const struct flash_info esmt_parts[] = {
>> /* ESMT */
>> { "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
>> SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) },
>> - { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
>> - SECT_4K | SPI_NOR_HAS_LOCK) },
>> + { "f25l32qa(2s)", INFO(0x8c4116, 0, 64 * 1024, 64,
>> + SECT_4K | SPI_NOR_HAS_LOCK) },
>> { "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128,
>> SECT_4K | SPI_NOR_HAS_LOCK) },
>> };
>
> Tudor has decide on that name - or the use of parentheses. I don't have a
> strong opinion on it.
I'm concerned that any other devices do not contain parentheses in their
model names... I'm fine with "f25l32qa-2s" if preferred.
>
> FWIW,
> Reviewed-by: Michael Walle <michael@walle.cc>
Thanks for your review!
>
> -michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa
2021-07-19 15:19 ` Sungbo Eo
@ 2021-07-21 7:32 ` Michael Walle
2021-07-23 14:10 ` Sungbo Eo
0 siblings, 1 reply; 8+ messages in thread
From: Michael Walle @ 2021-07-21 7:32 UTC (permalink / raw)
To: Sungbo Eo
Cc: linux-mtd, Tudor Ambarus, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Hi,
Am 2021-07-19 17:19, schrieb Sungbo Eo:
> On 2021-07-17 01:11, Michael Walle wrote:
>> Am 2021-06-20 10:56, schrieb Sungbo Eo:
>>> The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
>>> 0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn
>>> bits
>>> are non-volatile, unlike its older version.
>>>
>>> References:
>>> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA.pdf
>>> References:
>>> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA_1(2S).pdf
>>
>> "Datasheet:" please
>>
>>> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
>>> ---
>>> At first I was going to send a new support patch of F25L16PA(2S),
>>> but before that, I wanted to make sure if "(2s)" suffix is okay or
>>> unnecessary.
>>> ---
>>> drivers/mtd/spi-nor/esmt.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
>>> index cfc9218c1053..51b3ff764ef6 100644
>>> --- a/drivers/mtd/spi-nor/esmt.c
>>> +++ b/drivers/mtd/spi-nor/esmt.c
>>> @@ -12,8 +12,8 @@ static const struct flash_info esmt_parts[] = {
>>> /* ESMT */
>>> { "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
>>> SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
>>> },
>>> - { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
>>> - SECT_4K | SPI_NOR_HAS_LOCK) },
>>> + { "f25l32qa(2s)", INFO(0x8c4116, 0, 64 * 1024, 64,
>>> + SECT_4K | SPI_NOR_HAS_LOCK) },
>>> { "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128,
>>> SECT_4K | SPI_NOR_HAS_LOCK) },
>>> };
>>
>> Tudor has decide on that name - or the use of parentheses. I don't
>> have a
>> strong opinion on it.
>
> I'm concerned that any other devices do not contain parentheses in
> their model names... I'm fine with "f25l32qa-2s" if preferred.
Having another look at the datasheet there are different product
IDs: F25L32QA-50PG2S, F25L32QA-86PG2S, .. where you can also find
the "-2s".
Thus I'd actually prefer "f25l32qa-2s".
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa
2021-07-21 7:32 ` Michael Walle
@ 2021-07-23 14:10 ` Sungbo Eo
0 siblings, 0 replies; 8+ messages in thread
From: Sungbo Eo @ 2021-07-23 14:10 UTC (permalink / raw)
To: Michael Walle
Cc: linux-mtd, Tudor Ambarus, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
On 2021-07-21 16:32, Michael Walle wrote:
> Hi,
>
> Am 2021-07-19 17:19, schrieb Sungbo Eo:
>> On 2021-07-17 01:11, Michael Walle wrote:
>>> Am 2021-06-20 10:56, schrieb Sungbo Eo:
>>>> The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
>>>> 0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn
>>>> bits
>>>> are non-volatile, unlike its older version.
>>>>
>>>> References:
>>>> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA.pdf
>>>> References:
>>>> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA_1(2S).pdf
>>>
>>> "Datasheet:" please
>>>
>>>> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
>>>> ---
>>>> At first I was going to send a new support patch of F25L16PA(2S),
>>>> but before that, I wanted to make sure if "(2s)" suffix is okay or
>>>> unnecessary.
>>>> ---
>>>> drivers/mtd/spi-nor/esmt.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
>>>> index cfc9218c1053..51b3ff764ef6 100644
>>>> --- a/drivers/mtd/spi-nor/esmt.c
>>>> +++ b/drivers/mtd/spi-nor/esmt.c
>>>> @@ -12,8 +12,8 @@ static const struct flash_info esmt_parts[] = {
>>>> /* ESMT */
>>>> { "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
>>>> SECT_4K | SPI_NOR_HAS_LOCK |
>>>> SPI_NOR_SWP_IS_VOLATILE) },
>>>> - { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
>>>> - SECT_4K | SPI_NOR_HAS_LOCK) },
>>>> + { "f25l32qa(2s)", INFO(0x8c4116, 0, 64 * 1024, 64,
>>>> + SECT_4K | SPI_NOR_HAS_LOCK) },
>>>> { "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128,
>>>> SECT_4K | SPI_NOR_HAS_LOCK) },
>>>> };
>>>
>>> Tudor has decide on that name - or the use of parentheses. I don't
>>> have a
>>> strong opinion on it.
>>
>> I'm concerned that any other devices do not contain parentheses in
>> their model names... I'm fine with "f25l32qa-2s" if preferred.
>
> Having another look at the datasheet there are different product
> IDs: F25L32QA-50PG2S, F25L32QA-86PG2S, .. where you can also find
> the "-2s".
>
> Thus I'd actually prefer "f25l32qa-2s".
Oh, you're right. So the "2S" suffix was a indicator for a class of
devices, not for a single device... I didn't even notice there was a
product ID table. xD
I'll follow your suggestion. Thanks!
>
> -michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] mtd: spi-nor: esmt: Use correct name of f25l32qa
2021-06-20 8:56 [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa Sungbo Eo
2021-07-16 16:11 ` Michael Walle
@ 2021-07-19 15:20 ` Sungbo Eo
2021-07-23 14:12 ` [PATCH v3] " Sungbo Eo
1 sibling, 1 reply; 8+ messages in thread
From: Sungbo Eo @ 2021-07-19 15:20 UTC (permalink / raw)
To: linux-mtd
Cc: Tudor Ambarus, Michael Walle, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Sungbo Eo
The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn bits
are non-volatile, unlike its older version.
Datasheet: https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA.pdf
Datasheet: https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA_1(2S).pdf
Signed-off-by: Sungbo Eo <mans0n@gorani.run>
Reviewed-by: Michael Walle <michael@walle.cc>
---
v2:
* revised tags in the commit message
v1:
At first I was going to send a new support patch of F25L16PA(2S),
but before that, I wanted to make sure if "(2s)" suffix is okay or unnecessary.
---
drivers/mtd/spi-nor/esmt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
index cfc9218c1053..51b3ff764ef6 100644
--- a/drivers/mtd/spi-nor/esmt.c
+++ b/drivers/mtd/spi-nor/esmt.c
@@ -12,8 +12,8 @@ static const struct flash_info esmt_parts[] = {
/* ESMT */
{ "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) },
- { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
- SECT_4K | SPI_NOR_HAS_LOCK) },
+ { "f25l32qa(2s)", INFO(0x8c4116, 0, 64 * 1024, 64,
+ SECT_4K | SPI_NOR_HAS_LOCK) },
{ "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128,
SECT_4K | SPI_NOR_HAS_LOCK) },
};
--
2.32.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3] mtd: spi-nor: esmt: Use correct name of f25l32qa
2021-07-19 15:20 ` [PATCH v2] " Sungbo Eo
@ 2021-07-23 14:12 ` Sungbo Eo
2022-07-19 10:11 ` Tudor Ambarus
0 siblings, 1 reply; 8+ messages in thread
From: Sungbo Eo @ 2021-07-23 14:12 UTC (permalink / raw)
To: linux-mtd
Cc: Tudor Ambarus, Michael Walle, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Sungbo Eo
The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn bits
are non-volatile, unlike its older version.
Datasheet: https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA.pdf
Datasheet: https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA_1(2S).pdf
Signed-off-by: Sungbo Eo <mans0n@gorani.run>
Reviewed-by: Michael Walle <michael@walle.cc>
---
v3:
* replaced "(2s)" with "-2s"
v2:
* revised tags in the commit message
v1:
At first I was going to send a new support patch of F25L16PA(2S),
but before that, I wanted to make sure if "(2s)" suffix is okay or unnecessary.
---
drivers/mtd/spi-nor/esmt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
index cfc9218c1053..364de711b80e 100644
--- a/drivers/mtd/spi-nor/esmt.c
+++ b/drivers/mtd/spi-nor/esmt.c
@@ -12,8 +12,8 @@ static const struct flash_info esmt_parts[] = {
/* ESMT */
{ "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) },
- { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
- SECT_4K | SPI_NOR_HAS_LOCK) },
+ { "f25l32qa-2s", INFO(0x8c4116, 0, 64 * 1024, 64,
+ SECT_4K | SPI_NOR_HAS_LOCK) },
{ "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128,
SECT_4K | SPI_NOR_HAS_LOCK) },
};
--
2.32.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3] mtd: spi-nor: esmt: Use correct name of f25l32qa
2021-07-23 14:12 ` [PATCH v3] " Sungbo Eo
@ 2022-07-19 10:11 ` Tudor Ambarus
0 siblings, 0 replies; 8+ messages in thread
From: Tudor Ambarus @ 2022-07-19 10:11 UTC (permalink / raw)
To: mans0n, linux-mtd
Cc: Tudor Ambarus, miquel.raynal, vigneshr, richard, p.yadav, michael
On Fri, 23 Jul 2021 23:12:32 +0900, Sungbo Eo wrote:
> The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
> 0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn bits
> are non-volatile, unlike its older version.
>
>
Applied to spi-nor/next, thanks!
[1/1] mtd: spi-nor: esmt: Use correct name of f25l32qa
https://git.kernel.org/mtd/c/41e4f15f02af
Best regards,
--
Tudor Ambarus <tudor.ambarus@microchip.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-19 10:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-20 8:56 [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa Sungbo Eo
2021-07-16 16:11 ` Michael Walle
2021-07-19 15:19 ` Sungbo Eo
2021-07-21 7:32 ` Michael Walle
2021-07-23 14:10 ` Sungbo Eo
2021-07-19 15:20 ` [PATCH v2] " Sungbo Eo
2021-07-23 14:12 ` [PATCH v3] " Sungbo Eo
2022-07-19 10:11 ` Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).