Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the hid tree
@ 2020-02-12 20:49 Stephen Rothwell
  2020-02-13  6:28 ` Johan Korsnes (jkorsnes)
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-02-12 20:49 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Johan Korsnes

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Hi all,

In commit

  5ebdffd25098 ("HID: core: fix off-by-one memset in hid_report_raw_event()")

Fixes tag

  Fixes: 966922f26c7f ("HID: fix a crash in hid_report_raw_event()

has these problem(s):

  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Fixes tag needs some work in the hid tree
  2020-02-12 20:49 linux-next: Fixes tag needs some work in the hid tree Stephen Rothwell
@ 2020-02-13  6:28 ` Johan Korsnes (jkorsnes)
  0 siblings, 0 replies; 4+ messages in thread
From: Johan Korsnes (jkorsnes) @ 2020-02-13  6:28 UTC (permalink / raw)
  To: Stephen Rothwell, Jiri Kosina, Benjamin Tissoires
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 2/12/20 9:49 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5ebdffd25098 ("HID: core: fix off-by-one memset in hid_report_raw_event()")
> 
> Fixes tag
> 
>   Fixes: 966922f26c7f ("HID: fix a crash in hid_report_raw_event()
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.
>

Sorry about this. The checkpatch.pl script initially did complain
about the format of my commit references in v1:

"ERROR: Please use git commit description style"

But it only complained about number of characters in SHA, it did not
mention anything about line break. I will take care not to introduce
these line breaks in future commits, but it would be nice if
checkpatch.pl could check for this.

Johan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* linux-next: Fixes tag needs some work in the hid tree
@ 2019-11-06 20:56 Stephen Rothwell
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2019-11-06 20:56 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jason Gerecke

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

In commit

  ff479731c385 ("HID: wacom: generic: Treat serial number and related fields as unsigned")

Fixes tag

  Fixes: f85c9dc678 ("HID: wacom: generic: Support tool ID and additional tool types")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* linux-next: Fixes tag needs some work in the hid tree
@ 2019-08-19 15:19 Stephen Rothwell
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2019-08-19 15:19 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jason Gerecke

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi all,

In commit

  b72fb1dcd2ea ("HID: wacom: Correct distance scale for 2nd-gen Intuos devices")

Fixes tag

  Fixes: eda01dab53 ("HID: wacom: Add four new Intuos devices")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 20:49 linux-next: Fixes tag needs some work in the hid tree Stephen Rothwell
2020-02-13  6:28 ` Johan Korsnes (jkorsnes)
  -- strict thread matches above, loose matches on Subject: below --
2019-11-06 20:56 Stephen Rothwell
2019-08-19 15:19 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git