* linux-next: build failure after merge of the final tree (ubi tree related)
@ 2011-03-16 6:50 Stephen Rothwell
2011-03-16 7:22 ` Artem Bityutskiy
2011-03-16 11:48 ` Artem Bityutskiy
0 siblings, 2 replies; 5+ messages in thread
From: Stephen Rothwell @ 2011-03-16 6:50 UTC (permalink / raw)
To: Artem Bityutskiy
Cc: linux-next, linux-kernel, Benjamin Herrenschmidt, Paul Mackerras,
linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
I don't know how to fix this, so I have left it for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the final tree (ubi tree related)
2011-03-16 6:50 linux-next: build failure after merge of the final tree (ubi tree related) Stephen Rothwell
@ 2011-03-16 7:22 ` Artem Bityutskiy
2011-03-16 10:15 ` Benjamin Herrenschmidt
2011-03-16 11:48 ` Artem Bityutskiy
1 sibling, 1 reply; 5+ messages in thread
From: Artem Bityutskiy @ 2011-03-16 7:22 UTC (permalink / raw)
To: ext Stephen Rothwell
Cc: linux-next, linux-kernel, Benjamin Herrenschmidt, Paul Mackerras,
linuxppc-dev
On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
>
> Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
>
> I don't know how to fix this, so I have left it for today.
Hmm, strange, include <linux/vmalloc.h> should be enough to use
__vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'll
try to look better.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the final tree (ubi tree related)
2011-03-16 7:22 ` Artem Bityutskiy
@ 2011-03-16 10:15 ` Benjamin Herrenschmidt
2011-03-16 10:27 ` Artem Bityutskiy
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2011-03-16 10:15 UTC (permalink / raw)
To: Artem.Bityutskiy
Cc: ext Stephen Rothwell, linux-next, linux-kernel, Paul Mackerras,
linuxppc-dev
On Wed, 2011-03-16 at 09:22 +0200, Artem Bityutskiy wrote:
> On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> > drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> > drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
> >
> > Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
> >
> > I don't know how to fix this, so I have left it for today.
>
> Hmm, strange, include <linux/vmalloc.h> should be enough to use
> __vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'll
> try to look better.
Try adding asm/pgtable.h
Cheers,
Ben.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the final tree (ubi tree related)
2011-03-16 10:15 ` Benjamin Herrenschmidt
@ 2011-03-16 10:27 ` Artem Bityutskiy
0 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2011-03-16 10:27 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: ext Stephen Rothwell, linux-next, linux-kernel, Paul Mackerras,
linuxppc-dev
On Wed, 2011-03-16 at 21:15 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2011-03-16 at 09:22 +0200, Artem Bityutskiy wrote:
> > On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > >
> > > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> > > drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> > > drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > >
> > > Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
> > >
> > > I don't know how to fix this, so I have left it for today.
> >
> > Hmm, strange, include <linux/vmalloc.h> should be enough to use
> > __vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'll
> > try to look better.
>
> Try adding asm/pgtable.h
Thanks, that's what I was thinking about as well.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the final tree (ubi tree related)
2011-03-16 6:50 linux-next: build failure after merge of the final tree (ubi tree related) Stephen Rothwell
2011-03-16 7:22 ` Artem Bityutskiy
@ 2011-03-16 11:48 ` Artem Bityutskiy
1 sibling, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2011-03-16 11:48 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Benjamin Herrenschmidt, Paul Mackerras,
linuxppc-dev
On Wed, 2011-03-16 at 17:50 +1100, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
>
> Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
>
> I don't know how to fix this, so I have left it for today.
Fixed, sorry for the hassle and thank you!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-16 11:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-16 6:50 linux-next: build failure after merge of the final tree (ubi tree related) Stephen Rothwell
2011-03-16 7:22 ` Artem Bityutskiy
2011-03-16 10:15 ` Benjamin Herrenschmidt
2011-03-16 10:27 ` Artem Bityutskiy
2011-03-16 11:48 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).