Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: wen.yang99@zte.com.cn
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the pm tree
Date: Thu, 11 Jul 2019 14:26:18 +0200
Message-ID: <16643843.udE4Cbaid0@kreacher> (raw)
In-Reply-To: <201907111346291954773@zte.com.cn>

On Thursday, July 11, 2019 7:46:29 AM CEST wen.yang99@zte.com.cn wrote:
> > Hi all,
> > 
> > After merging the pm tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > drivers/cpufreq/pasemi-cpufreq.c: In function 'pas_cpufreq_cpu_init':
> > drivers/cpufreq/pasemi-cpufreq.c:199:1: warning: label 'out_unmap_sdcpwr' defined but not used [-Wunused-label]
> > out_unmap_sdcpwr:
> > ^~~~~~~~~~~~~~~~
> > 
> > Introduced by commit
> > 
> > f43e075f7252 ("cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init()")
> 
> Thank you very much.
> 
> We need to delete the useless code here:
> diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c
> index 1f0beb7..624c34a 100644
> --- a/drivers/cpufreq/pasemi-cpufreq.c
> +++ b/drivers/cpufreq/pasemi-cpufreq.c
> @@ -195,9 +195,6 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
> 
>         return cpufreq_generic_init(policy, pas_freqs, get_gizmo_latency());
> 
> -out_unmap_sdcpwr:
> -       iounmap(sdcpwr_mapbase);
> -
>  out_unmap_sdcasr:
>         iounmap(sdcasr_mapbase);
>  out:

I'm dropping commit f43e075f7252 from my linux-next branch, so please send a new version
of that patch with the issue fixed.

If you consider alternatives to the patch, please describe them in the message section between
the patch and the changelog.




       reply index

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201907111346291954773@zte.com.cn>
2019-07-11 12:26 ` Rafael J. Wysocki [this message]
2020-01-19 23:40 Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2019-10-14 23:08 Stephen Rothwell
2019-10-15  8:23 ` Andy Shevchenko
2019-10-15  9:41   ` Rafael J. Wysocki
2019-07-11  1:31 Stephen Rothwell
2019-01-23 23:45 Stephen Rothwell
2018-07-30  2:00 Stephen Rothwell
2018-07-30  7:24 ` Sakari Ailus
2018-07-30  7:30   ` jacopo mondi
2018-07-31  0:39   ` Stephen Rothwell
2018-06-08  0:30 Stephen Rothwell
2018-06-08  9:14 ` Rafael J. Wysocki
2018-04-09  1:24 Stephen Rothwell
2018-04-10  7:05 ` Rafael J. Wysocki
2016-11-13 23:40 Stephen Rothwell
2016-11-14  0:03 ` Rafael J. Wysocki
2016-11-14  8:49   ` Akshay Adiga
2014-11-17  2:44 Stephen Rothwell
2014-11-17 11:31 ` Paul Bolle
2014-11-17 23:14   ` Rafael J. Wysocki
2014-11-17 23:45     ` Paul Bolle
2014-11-18  0:34       ` Rafael J. Wysocki
2014-10-29  2:51 Stephen Rothwell
2014-10-29 14:55 ` Rafael J. Wysocki
2014-10-29 15:23   ` Fengguang Wu
2014-10-29 15:56     ` Rafael J. Wysocki

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16643843.udE4Cbaid0@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=wen.yang99@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git