From: Zhang Rui <rui.zhang@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the pm tree
Date: Wed, 27 Jan 2021 11:54:50 +0800 [thread overview]
Message-ID: <e1fcf35b21e7e4af67621bd4f037e3f07af756e1.camel@intel.com> (raw)
In-Reply-To: <20210127124324.29b7c4d4@canb.auug.org.au>
Hi, Stephen,
Sorry that I missed this build warning in the first place, thanks for
reporting.
The patch below fixes it.
BTW, Rafael, I think acpi_fpdt_init() also needs to be fixed to have
proper return value.
Do you prefer an incremental patch or a V2 of 208757d71098 ("ACPI:
tables: introduce support for FPDT table"), which includes all these
fixes?
thanks,
rui
From 2b8ed148351875b4bf227602a97edba12d08af7e Mon Sep 17 00:00:00 2001
From: Zhang Rui <rui.zhang@intel.com>
Date: Wed, 27 Jan 2021 11:33:33 +0800
Subject: [PATCH] ACPI: FPDT: fix build warning
Fix a build warning,
In file included from ./include/linux/printk.h:7:0,
from ./include/linux/kernel.h:16,
from ./include/linux/list.h:9,
from ./include/linux/kobject.h:19,
from ./include/linux/of.h:17,
from ./include/linux/irqdomain.h:35,
from ./include/linux/acpi.h:13,
from drivers/acpi/acpi_fpdt.c:11:
drivers/acpi/acpi_fpdt.c: In function ‘acpi_init_fpdt’:
./include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
./include/linux/kern_levels.h:14:19: note: in expansion of macro ‘KERN_SOH’
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
./include/linux/printk.h:373:9: note: in expansion of macro ‘KERN_INFO’
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~
drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro ‘pr_info’
pr_info(FW_BUG, "Invalid subtable type %d found.\n",
^~~~~~~
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/acpi/acpi_fpdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c
index b8108117262a..64d5733dca0b 100644
--- a/drivers/acpi/acpi_fpdt.c
+++ b/drivers/acpi/acpi_fpdt.c
@@ -252,7 +252,7 @@ void acpi_init_fpdt(void)
subtable->type);
break;
default:
- pr_info(FW_BUG, "Invalid subtable type %d found.\n",
+ pr_info(FW_BUG "Invalid subtable type %d found.\n",
subtable->type);
return;
}
--
2.17.1
On Wed, 2021-01-27 at 12:43 +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pm tree, today's linux-next build (x86_64
> allmodconfig)
> produced this warning:
>
> In file included from include/linux/printk.h:7,
> from include/linux/kernel.h:16,
> from include/linux/list.h:9,
> from include/linux/kobject.h:19,
> from include/linux/of.h:17,
> from include/linux/irqdomain.h:35,
> from include/linux/acpi.h:13,
> from drivers/acpi/acpi_fpdt.c:11:
> drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
> include/linux/kern_levels.h:5:18: warning: too many arguments for
> format [-Wformat-extra-args]
> 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
> | ^~~~~~
> include/linux/kern_levels.h:14:19: note: in expansion of macro
> 'KERN_SOH'
> 14 | #define KERN_INFO KERN_SOH "6" /* informational */
> | ^~~~~~~~
> include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO'
> 373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> | ^~~~~~~~~
> drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro 'pr_info'
> 255 | pr_info(FW_BUG, "Invalid subtable type %d found.\n",
> | ^~~~~~~
>
> Introduced by commit
>
> 208757d71098 ("ACPI: tables: introduce support for FPDT table")
>
next prev parent reply other threads:[~2021-01-27 5:59 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 1:43 linux-next: build warning after merge of the pm tree Stephen Rothwell
2021-01-27 3:54 ` Zhang Rui [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-05 5:00 Stephen Rothwell
2024-02-05 5:30 ` Meng, Li (Jassmine)
2022-02-06 22:40 Stephen Rothwell
2021-10-13 6:28 Stephen Rothwell
2022-01-17 22:02 ` Stephen Rothwell
2021-03-31 0:29 Stephen Rothwell
2021-03-31 6:22 ` Vitaly Kuznetsov
2021-04-02 17:18 ` Rafael J. Wysocki
2021-02-15 0:39 Stephen Rothwell
2021-02-15 10:23 ` Andy Shevchenko
2021-02-15 10:24 ` Andy Shevchenko
2021-02-22 8:34 ` Stephen Rothwell
2020-11-19 0:09 Stephen Rothwell
2020-11-19 16:22 ` Andy Shevchenko
2020-09-22 8:11 Stephen Rothwell
2020-10-01 9:43 ` Stephen Rothwell
2020-10-08 9:35 ` Stephen Rothwell
2020-10-15 7:20 ` Stephen Rothwell
2020-07-30 2:55 Stephen Rothwell
2020-07-30 3:10 ` Neal Liu
2020-01-19 23:40 Stephen Rothwell
2019-10-14 23:08 Stephen Rothwell
2019-10-15 8:23 ` Andy Shevchenko
2019-10-15 9:41 ` Rafael J. Wysocki
[not found] <201907111346291954773@zte.com.cn>
2019-07-11 12:26 ` Rafael J. Wysocki
2019-07-11 1:31 Stephen Rothwell
2019-01-23 23:45 Stephen Rothwell
2018-07-30 2:00 Stephen Rothwell
2018-07-30 7:24 ` Sakari Ailus
2018-07-30 7:30 ` jacopo mondi
2018-07-31 0:39 ` Stephen Rothwell
2018-06-08 0:30 Stephen Rothwell
2018-06-08 9:14 ` Rafael J. Wysocki
2018-04-09 1:24 Stephen Rothwell
2018-04-10 7:05 ` Rafael J. Wysocki
2016-11-13 23:40 Stephen Rothwell
2016-11-14 0:03 ` Rafael J. Wysocki
2016-11-14 8:49 ` Akshay Adiga
2014-11-17 2:44 Stephen Rothwell
2014-11-17 11:31 ` Paul Bolle
2014-11-17 23:14 ` Rafael J. Wysocki
2014-11-17 23:45 ` Paul Bolle
2014-11-18 0:34 ` Rafael J. Wysocki
2014-10-29 2:51 Stephen Rothwell
2014-10-29 14:55 ` Rafael J. Wysocki
2014-10-29 15:23 ` Fengguang Wu
2014-10-29 15:56 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1fcf35b21e7e4af67621bd4f037e3f07af756e1.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).