Re: linux-next: semaphore-removal build breakage

Re: linux-next: semaphore-removal build breakage

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

Hi Willy,

On Mon, 28 Apr 2008 13:46:09 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) broke like this:
> 
> In file included from net/9p/trans_virtio.c:34:
> include/linux/idr.h:60: error: syntax error before 'spinlock_t'
> include/linux/idr.h:60: warning: no semicolon at end of struct or union
> include/linux/idr.h:104: error: field 'idr' has incomplete type
> 
> Caused by commit 2c77d192c68a95a188dd326db1315b3492487c41 ("9p: Convert
> from semaphore to spinlock") in the semaphore-removal tree.  The
> following patch fixes it but may well not be correct.

In fact, it would be also fixed (or hidden) if you put the includes back
in the order they were before that patch ....

It would be good for this to be fixed - its been there too long now.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: linux-next: semaphore-removal build breakage

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hi Willy,

On Thu, 15 May 2008 03:05:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In fact, it would be also fixed (or hidden) if you put the includes back
> in the order they were before that patch ....
> 
> It would be good for this to be fixed - its been there too long now.

So, for now, I have reverted commit
2c77d192c68a95a188dd326db1315b3492487c41 ("9p: Convert from semaphore to
spinlock") instead of applying the patch that added apinlock.h to idr.h.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]