linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: usb.current tree build failure
@ 2009-04-08  0:10 Stephen Rothwell
  2009-04-08  1:48 ` Greg KH
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2009-04-08  0:10 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, David Vrabel

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/block/ub.c: In function 'ub_scsi_urb_compl':
drivers/block/ub.c:1052: error: implicit declaration of function 'usb_settoggle'

Caused by commit 876d77e4521ff2b4f937bf7104bf70d2d105b0c2 ("USB: add
reset endpoint operations") from the usb.current tree.

I have used the version of that tree from next-20090407. (Which means I
need to do the same for the driver-core, usb and staring trees that
depend on the usb.current tree.)
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
* linux-next: usb.current tree build failure
@ 2008-08-07  0:53 Stephen Rothwell
  2008-08-07  1:56 ` Kevin Lloyd
  2008-08-07  4:23 ` Greg KH
  0 siblings, 2 replies; 12+ messages in thread
From: Stephen Rothwell @ 2008-08-07  0:53 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Kevin Lloyd

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

In file included from drivers/usb/storage/usb.c:177:
drivers/usb/storage/unusual_devs.h:1577: error: 'sierra_ms_init' undeclared here (not in a function)

Caused by commit ff28a24426410aa193b47a5e9ec091d46eaa66d1 ("USB Storage
Sierra: TRU-Install feature update").

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 7 Aug 2008 10:51:49 +1000
Subject: [PATCH] usb: build fix for sierra_ms unusual device

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/storage/unusual_devs.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 0547853..564999c 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1569,6 +1569,7 @@ UNUSUAL_DEV(  0x10d6, 0x2200, 0x0100, 0x0100,
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		0),
 
+#ifdef CONFIG_USB_STORAGE_SIERRA
 /* Reported by Kevin Lloyd <linux@sierrawireless.com>
  * Entry is needed for the initializer function override,
  * which instructs the device to load as a modem
@@ -1579,6 +1580,7 @@ UNUSUAL_DEV(  0x1199, 0x0fff, 0x0000, 0x9999,
 		"USB MMC Storage",
 		US_SC_DEVICE, US_PR_DEVICE, sierra_ms_init,
 		0),
+#endif
 
 /* Reported by Jaco Kroon <jaco@kroon.co.za>
  * The usb-storage module found on the Digitech GNX4 (and supposedly other
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* linux-next: usb.current tree build failure
@ 2008-08-01  1:20 Stephen Rothwell
  2008-08-01  6:12 ` Greg KH
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2008-08-01  1:20 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Alan Stern

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/built-in.o: In function `.usb_reset_device':
(.text+0x1bfeb4): undefined reference to `.usb_forced_unbind_intf'
drivers/built-in.o: In function `.usb_reset_device':
(.text+0x1c03b8): undefined reference to `.usb_rebind_intf'

Caused by commit 78d9a487ee961c356e1a934d9a92eca38ffb3a70 ("USB: Force
unbinding of drivers lacking reset_resume or other methods").

The above config has CONFIG_USB=y and CONFIG_PM not set.

I applied the following (probably incorrect) patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 1 Aug 2008 11:17:39 +1000
Subject: [PATCH] usb: two more functions are needed when CONFIG_PM is not set

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/core/driver.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 6618bc8..2be37fe 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -774,8 +774,6 @@ void usb_deregister(struct usb_driver *driver)
 }
 EXPORT_SYMBOL_GPL(usb_deregister);
 
-#ifdef CONFIG_PM
-
 /* Forced unbinding of a USB interface driver, either because
  * it doesn't support pre_reset/post_reset/reset_resume or
  * because it doesn't support suspend/resume.
@@ -822,6 +820,8 @@ void usb_rebind_intf(struct usb_interface *intf)
 		dev_warn(&intf->dev, "rebind failed: %d\n", rc);
 }
 
+#ifdef CONFIG_PM
+
 #define DO_UNBIND	0
 #define DO_REBIND	1
 
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2009-04-08  2:22 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-08  0:10 linux-next: usb.current tree build failure Stephen Rothwell
2009-04-08  1:48 ` Greg KH
2009-04-08  2:20   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2008-08-07  0:53 Stephen Rothwell
2008-08-07  1:56 ` Kevin Lloyd
2008-08-07  4:23 ` Greg KH
2008-08-07  6:25   ` Stephen Rothwell
2008-08-01  1:20 Stephen Rothwell
2008-08-01  6:12 ` Greg KH
2008-08-01  6:43   ` Stephen Rothwell
2008-08-07  0:56   ` Stephen Rothwell
2008-08-07  4:24     ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).