linux-next: usb.current tree build failure

linux-next: usb.current tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/block/ub.c: In function 'ub_scsi_urb_compl':
drivers/block/ub.c:1052: error: implicit declaration of function 'usb_settoggle'

Caused by commit 876d77e4521ff2b4f937bf7104bf70d2d105b0c2 ("USB: add
reset endpoint operations") from the usb.current tree.

I have used the version of that tree from next-20090407. (Which means I
need to do the same for the driver-core, usb and staring trees that
depend on the usb.current tree.)
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: usb.current tree build failure

[Greg KH]

On Wed, Apr 08, 2009 at 10:10:07AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/block/ub.c: In function 'ub_scsi_urb_compl':
> drivers/block/ub.c:1052: error: implicit declaration of function 'usb_settoggle'
> 
> Caused by commit 876d77e4521ff2b4f937bf7104bf70d2d105b0c2 ("USB: add
> reset endpoint operations") from the usb.current tree.
> 
> I have used the version of that tree from next-20090407. (Which means I
> need to do the same for the driver-core, usb and staring trees that
> depend on the usb.current tree.)

I think I'll just drop these patches, as this isn't ok.

David, care to respin these and resend them to me?  I'll have to drop
your whole series :(

thanks,

greg k-h

Re: linux-next: usb.current tree build failure

[Greg KH]

On Tue, Apr 07, 2009 at 06:48:30PM -0700, Greg KH wrote:
> On Wed, Apr 08, 2009 at 10:10:07AM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > drivers/block/ub.c: In function 'ub_scsi_urb_compl':
> > drivers/block/ub.c:1052: error: implicit declaration of function 'usb_settoggle'
> > 
> > Caused by commit 876d77e4521ff2b4f937bf7104bf70d2d105b0c2 ("USB: add
> > reset endpoint operations") from the usb.current tree.
> > 
> > I have used the version of that tree from next-20090407. (Which means I
> > need to do the same for the driver-core, usb and staring trees that
> > depend on the usb.current tree.)
> 
> I think I'll just drop these patches, as this isn't ok.
> 
> David, care to respin these and resend them to me?  I'll have to drop
> your whole series :(

I've now dropped your 6 patches and pushed out a new series so that
linux-next will build properly with the usb tree in it tomorrow.

Stephen, sorry for the trouble.

greg k-h

Re: linux-next: usb.current tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Hi Greg,

On Wed, 6 Aug 2008 21:23:53 -0700 Greg KH <greg@kroah.com> wrote:
>
> On Thu, Aug 07, 2008 at 10:53:21AM +1000, Stephen Rothwell wrote:
> > 
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > 
> > In file included from drivers/usb/storage/usb.c:177:
> > drivers/usb/storage/unusual_devs.h:1577: error: 'sierra_ms_init' undeclared here (not in a function)
> > 
> > Caused by commit ff28a24426410aa193b47a5e9ec091d46eaa66d1 ("USB Storage
> > Sierra: TRU-Install feature update").
> > 
> > I applied the following patch.
> 
> Thanks, now merged in.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: usb.current tree build failure

[Greg KH]

On Thu, Aug 07, 2008 at 10:56:00AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Thu, 31 Jul 2008 23:12:50 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > On Fri, Aug 01, 2008 at 11:20:21AM +1000, Stephen Rothwell wrote:
> > > 
> > > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > > 
> > > drivers/built-in.o: In function `.usb_reset_device':
> > > (.text+0x1bfeb4): undefined reference to `.usb_forced_unbind_intf'
> > > drivers/built-in.o: In function `.usb_reset_device':
> > > (.text+0x1c03b8): undefined reference to `.usb_rebind_intf'
> > > 
> > > Caused by commit 78d9a487ee961c356e1a934d9a92eca38ffb3a70 ("USB: Force
> > > unbinding of drivers lacking reset_resume or other methods").
> > > 
> > > The above config has CONFIG_USB=y and CONFIG_PM not set.
> > > 
> > > I applied the following (probably incorrect) patch.
> > 
> > Thanks, this is my fault, I applied the wrong patch from Alan (he sent
> > me a later more correct version.)  Should be fixed in the tree for
> > tomorrow.
> 
> This is still no fixed ...

Yeah, trying to figure it out...

greg k-h

Re: linux-next: usb.current tree build failure

[Greg KH]

On Thu, Aug 07, 2008 at 10:53:21AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> In file included from drivers/usb/storage/usb.c:177:
> drivers/usb/storage/unusual_devs.h:1577: error: 'sierra_ms_init' undeclared here (not in a function)
> 
> Caused by commit ff28a24426410aa193b47a5e9ec091d46eaa66d1 ("USB Storage
> Sierra: TRU-Install feature update").
> 
> I applied the following patch.

Thanks, now merged in.

greg k-h

RE: linux-next: usb.current tree build failure

[Kevin Lloyd]

Hi Stephen,

Good catch, my apologies.

-Kevin

-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
Sent: Wednesday, August 06, 2008 5:53 PM
To: Greg KH
Cc: linux-next@vger.kernel.org; Kevin Lloyd
Subject: linux-next: usb.current tree build failure

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

In file included from drivers/usb/storage/usb.c:177:
drivers/usb/storage/unusual_devs.h:1577: error: 'sierra_ms_init' undeclared here (not in a function)

Caused by commit ff28a24426410aa193b47a5e9ec091d46eaa66d1 ("USB Storage
Sierra: TRU-Install feature update").

I applied the following patch.
--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 7 Aug 2008 10:51:49 +1000
Subject: [PATCH] usb: build fix for sierra_ms unusual device

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/storage/unusual_devs.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 0547853..564999c 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1569,6 +1569,7 @@ UNUSUAL_DEV(  0x10d6, 0x2200, 0x0100, 0x0100,
                US_SC_DEVICE, US_PR_DEVICE, NULL,
                0),

+#ifdef CONFIG_USB_STORAGE_SIERRA
 /* Reported by Kevin Lloyd <linux@sierrawireless.com>
  * Entry is needed for the initializer function override,
  * which instructs the device to load as a modem
@@ -1579,6 +1580,7 @@ UNUSUAL_DEV(  0x1199, 0x0fff, 0x0000, 0x9999,
                "USB MMC Storage",
                US_SC_DEVICE, US_PR_DEVICE, sierra_ms_init,
                0),
+#endif

 /* Reported by Jaco Kroon <jaco@kroon.co.za>
  * The usb-storage module found on the Digitech GNX4 (and supposedly other
--
1.5.6.3

Re: linux-next: usb.current tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

Hi Greg,

On Thu, 31 Jul 2008 23:12:50 -0700 Greg KH <greg@kroah.com> wrote:
>
> On Fri, Aug 01, 2008 at 11:20:21AM +1000, Stephen Rothwell wrote:
> > 
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > 
> > drivers/built-in.o: In function `.usb_reset_device':
> > (.text+0x1bfeb4): undefined reference to `.usb_forced_unbind_intf'
> > drivers/built-in.o: In function `.usb_reset_device':
> > (.text+0x1c03b8): undefined reference to `.usb_rebind_intf'
> > 
> > Caused by commit 78d9a487ee961c356e1a934d9a92eca38ffb3a70 ("USB: Force
> > unbinding of drivers lacking reset_resume or other methods").
> > 
> > The above config has CONFIG_USB=y and CONFIG_PM not set.
> > 
> > I applied the following (probably incorrect) patch.
> 
> Thanks, this is my fault, I applied the wrong patch from Alan (he sent
> me a later more correct version.)  Should be fixed in the tree for
> tomorrow.

This is still no fixed ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: usb.current tree build failure

[Stephen Rothwell]

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

In file included from drivers/usb/storage/usb.c:177:
drivers/usb/storage/unusual_devs.h:1577: error: 'sierra_ms_init' undeclared here (not in a function)

Caused by commit ff28a24426410aa193b47a5e9ec091d46eaa66d1 ("USB Storage
Sierra: TRU-Install feature update").

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 7 Aug 2008 10:51:49 +1000
Subject: [PATCH] usb: build fix for sierra_ms unusual device

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/storage/unusual_devs.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 0547853..564999c 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1569,6 +1569,7 @@ UNUSUAL_DEV(  0x10d6, 0x2200, 0x0100, 0x0100,
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		0),
 
+#ifdef CONFIG_USB_STORAGE_SIERRA
 /* Reported by Kevin Lloyd <linux@sierrawireless.com>
  * Entry is needed for the initializer function override,
  * which instructs the device to load as a modem
@@ -1579,6 +1580,7 @@ UNUSUAL_DEV(  0x1199, 0x0fff, 0x0000, 0x9999,
 		"USB MMC Storage",
 		US_SC_DEVICE, US_PR_DEVICE, sierra_ms_init,
 		0),
+#endif
 
 /* Reported by Jaco Kroon <jaco@kroon.co.za>
  * The usb-storage module found on the Digitech GNX4 (and supposedly other
-- 
1.5.6.3

Re: linux-next: usb.current tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi Greg,

On Thu, 31 Jul 2008 23:12:50 -0700 Greg KH <greg@kroah.com> wrote:
>
> Thanks, this is my fault, I applied the wrong patch from Alan (he sent
> me a later more correct version.)  Should be fixed in the tree for
> tomorrow.

OK, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: usb.current tree build failure

[Greg KH]

On Fri, Aug 01, 2008 at 11:20:21AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/built-in.o: In function `.usb_reset_device':
> (.text+0x1bfeb4): undefined reference to `.usb_forced_unbind_intf'
> drivers/built-in.o: In function `.usb_reset_device':
> (.text+0x1c03b8): undefined reference to `.usb_rebind_intf'
> 
> Caused by commit 78d9a487ee961c356e1a934d9a92eca38ffb3a70 ("USB: Force
> unbinding of drivers lacking reset_resume or other methods").
> 
> The above config has CONFIG_USB=y and CONFIG_PM not set.
> 
> I applied the following (probably incorrect) patch.

Thanks, this is my fault, I applied the wrong patch from Alan (he sent
me a later more correct version.)  Should be fixed in the tree for
tomorrow.

greg k-h

linux-next: usb.current tree build failure

[Stephen Rothwell]

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/built-in.o: In function `.usb_reset_device':
(.text+0x1bfeb4): undefined reference to `.usb_forced_unbind_intf'
drivers/built-in.o: In function `.usb_reset_device':
(.text+0x1c03b8): undefined reference to `.usb_rebind_intf'

Caused by commit 78d9a487ee961c356e1a934d9a92eca38ffb3a70 ("USB: Force
unbinding of drivers lacking reset_resume or other methods").

The above config has CONFIG_USB=y and CONFIG_PM not set.

I applied the following (probably incorrect) patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 1 Aug 2008 11:17:39 +1000
Subject: [PATCH] usb: two more functions are needed when CONFIG_PM is not set

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/core/driver.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 6618bc8..2be37fe 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -774,8 +774,6 @@ void usb_deregister(struct usb_driver *driver)
 }
 EXPORT_SYMBOL_GPL(usb_deregister);
 
-#ifdef CONFIG_PM
-
 /* Forced unbinding of a USB interface driver, either because
  * it doesn't support pre_reset/post_reset/reset_resume or
  * because it doesn't support suspend/resume.
@@ -822,6 +820,8 @@ void usb_rebind_intf(struct usb_interface *intf)
 		dev_warn(&intf->dev, "rebind failed: %d\n", rc);
 }
 
+#ifdef CONFIG_PM
+
 #define DO_UNBIND	0
 #define DO_REBIND	1
 
-- 
1.5.6.3