linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org
Subject: Re: linux-next: driver-core tree build warning
Date: Thu, 30 Apr 2009 23:11:18 -0700	[thread overview]
Message-ID: <20090501061118.GA19234@kroah.com> (raw)
In-Reply-To: <20090501054727.GB19020@kroah.com>

On Thu, Apr 30, 2009 at 10:47:27PM -0700, Greg KH wrote:
> On Fri, May 01, 2009 at 03:21:44PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > 
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_cfg':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3491: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_status':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3500: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_capability':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3509: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_rf_kill':
> > drivers/net/wireless/ipw2x00/ipw2100.c:4227: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > 
> > Introduced by commit 73119f5e60e3b16577e99e2f035039bed0d2dcca ("Wireless:
> > remove driver_data direct access of struct device").
> 
> Ah crap, my bad.  I'll go fix this up, it passed my build tests, I
> wonder why this isn't an error, I missed the warning.

I've sent an updated version of the patch that fixes this to John and
the wireless mailing list and updated my tree as well.

thanks,

greg k-h

  reply	other threads:[~2009-05-01  6:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-01  5:21 linux-next: driver-core tree build warning Stephen Rothwell
     [not found] ` <20090501152144.500e619a.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-05-01  5:47   ` Greg KH
2009-05-01  6:11     ` Greg KH [this message]
2009-05-01  7:11       ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2010-01-19  6:27 Stephen Rothwell
2010-01-19 21:04 ` Greg KH
2010-01-19 23:45   ` Stephen Rothwell
2010-01-20  6:25     ` Stephen Rothwell
2010-01-20  6:44       ` Stephen Rothwell
2010-01-21 23:10         ` Greg KH
2010-01-21 23:20           ` Stephen Rothwell
2010-01-29  7:21           ` Stephen Rothwell
2010-02-03  2:22             ` Greg KH
2010-02-03  3:29               ` Stephen Rothwell
2010-02-04  7:10               ` Stephen Rothwell
2009-07-13  7:26 Stephen Rothwell
2009-07-13  7:28 ` Stephen Rothwell
2009-07-13  7:51   ` Stephen Rothwell
2009-07-13 17:18     ` Greg KH
2009-07-13 21:23       ` David Brownell
2009-07-13 21:27         ` Greg KH
2009-07-13 21:36         ` Greg KH
2009-07-14  0:44           ` Stephen Rothwell
2008-08-15  2:59 Stephen Rothwell
2008-08-16  5:34 ` Greg KH
2008-08-18 19:09   ` Jason Baron
2008-08-18 22:35     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090501061118.GA19234@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).