From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <andi@firstfloor.org>
Subject: Re: linux-next: driver-core tree build warning
Date: Tue, 2 Feb 2010 18:22:47 -0800 [thread overview]
Message-ID: <20100203022247.GA11904@kroah.com> (raw)
In-Reply-To: <20100129182115.99918a0e.sfr@canb.auug.org.au>
On Fri, Jan 29, 2010 at 06:21:15PM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> On Thu, 21 Jan 2010 15:10:10 -0800 Greg KH <greg@kroah.com> wrote:
> >
> > Here's a patch that I just applied to my tree to hopefully resolve this
> > issue.
>
> I still get the warnings.
>
> > -static CLASS_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);
> > -static CLASS_ATTR(release, S_IWUSR, NULL, cpu_release_store);
> > +static SYSDEV_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);
>
> This defines attr_probe as a "struct sysdev_attribute" whose attr element
> is a "struct attribute".
>
> > +static SYSDEV_ATTR(release, S_IWUSR, NULL, cpu_release_store);
> > #endif /* CONFIG_ARCH_CPU_PROBE_RELEASE */
> >
> > #else /* ... !CONFIG_HOTPLUG_CPU */
> > @@ -261,8 +261,8 @@ int __init cpu_dev_init(void)
> >
> > static struct sysdev_class_attribute *cpu_sysdev_class_attrs[] = {
> > #ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
> > - &class_attr_probe.attr,
> > - &class_attr_release.attr,
> > + &attr_probe.attr,
>
> so here we are initialising a "struct sysdev_class_attribute *" with a
> "struct attribute *". Thus the warning.
Doh, sorry about that. I've fixed it up now and pushed it out.
thanks,
greg k-h
next prev parent reply other threads:[~2010-02-03 3:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 6:27 linux-next: driver-core tree build warning Stephen Rothwell
2010-01-19 21:04 ` Greg KH
2010-01-19 23:45 ` Stephen Rothwell
2010-01-20 6:25 ` Stephen Rothwell
2010-01-20 6:44 ` Stephen Rothwell
2010-01-21 23:10 ` Greg KH
2010-01-21 23:20 ` Stephen Rothwell
2010-01-29 7:21 ` Stephen Rothwell
2010-02-03 2:22 ` Greg KH [this message]
2010-02-03 3:29 ` Stephen Rothwell
2010-02-04 7:10 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-07-13 7:26 Stephen Rothwell
2009-07-13 7:28 ` Stephen Rothwell
2009-07-13 7:51 ` Stephen Rothwell
2009-07-13 17:18 ` Greg KH
2009-07-13 21:23 ` David Brownell
2009-07-13 21:27 ` Greg KH
2009-07-13 21:36 ` Greg KH
2009-07-14 0:44 ` Stephen Rothwell
2009-05-01 5:21 Stephen Rothwell
[not found] ` <20090501152144.500e619a.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-05-01 5:47 ` Greg KH
2009-05-01 6:11 ` Greg KH
2009-05-01 7:11 ` Stephen Rothwell
2008-08-15 2:59 Stephen Rothwell
2008-08-16 5:34 ` Greg KH
2008-08-18 19:09 ` Jason Baron
2008-08-18 22:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203022247.GA11904@kroah.com \
--to=greg@kroah.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).