Re: linux-next: driver-core tree build warning

From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Greg KH <greg@kroah.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: linux-next: driver-core tree build warning
Date: Fri, 29 Jan 2010 18:21:15 +1100	[thread overview]
Message-ID: <20100129182115.99918a0e.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20100121231010.GB29796@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

Hi Greg,

On Thu, 21 Jan 2010 15:10:10 -0800 Greg KH <greg@kroah.com> wrote:
>
> Here's a patch that I just applied to my tree to hopefully resolve this
> issue.

I still get the warnings.

> -static CLASS_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);
> -static CLASS_ATTR(release, S_IWUSR, NULL, cpu_release_store);
> +static SYSDEV_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);

This defines attr_probe as a "struct sysdev_attribute" whose attr element
is a "struct attribute".

> +static SYSDEV_ATTR(release, S_IWUSR, NULL, cpu_release_store);
>  #endif /* CONFIG_ARCH_CPU_PROBE_RELEASE */
>  
>  #else /* ... !CONFIG_HOTPLUG_CPU */
> @@ -261,8 +261,8 @@ int __init cpu_dev_init(void)
>  
>  static struct sysdev_class_attribute *cpu_sysdev_class_attrs[] = {
>  #ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
> -	&class_attr_probe.attr,
> -	&class_attr_release.attr,
> +	&attr_probe.attr,

so here we are initialising a "struct sysdev_class_attribute *" with a
"struct attribute *".  Thus the warning.

> +	&attr_release.attr,

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]