linux-next: build failure after merge of the final tree (tip tree related)

linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

Hi all,

After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:

kernel/sched.c:7140: error: 'cpu_coregroup_mask' undeclared here (not in a function)

Caused by commit 2c402dc3bb50 ("sched: Unify the sched_domain build
functions").  On sparc64, cpu_coregroup_mask is a #define, not a function.

I applied tha patch below (idea stolen from s390) whcih could probably be
better.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 12 Apr 2011 13:51:32 +1000
Subject: [PATCH] sched: fix sparc64 for sched_domain changes

Fixes this compile error:

kernel/sched.c:7140: error: 'cpu_coregroup_mask' undeclared here (not in a function)

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/sparc/include/asm/topology_64.h |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
index 1c79f32..16f477d 100644
--- a/arch/sparc/include/asm/topology_64.h
+++ b/arch/sparc/include/asm/topology_64.h
@@ -65,6 +65,10 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
 #define smt_capable()				(sparc64_multi_core)
 #endif /* CONFIG_SMP */
 
-#define cpu_coregroup_mask(cpu)			(&cpu_core_map[cpu])
+extern cpumask_t cpu_core_map[NR_CPUS];
+static inline const struct cpumask *cpu_coregroup_mask(int cpu)
+{
+        return &cpu_core_map[cpu];
+}
 
 #endif /* _ASM_SPARC64_TOPOLOGY_H */
-- 
1.7.4.1


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Ingo Molnar]

* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
> 
> kernel/sched.c:7140: error: 'cpu_coregroup_mask' undeclared here (not in a function)
> 
> Caused by commit 2c402dc3bb50 ("sched: Unify the sched_domain build
> functions").  On sparc64, cpu_coregroup_mask is a #define, not a function.
> 
> I applied tha patch below (idea stolen from s390) whcih could probably be
> better.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 12 Apr 2011 13:51:32 +1000
> Subject: [PATCH] sched: fix sparc64 for sched_domain changes
> 
> Fixes this compile error:
> 
> kernel/sched.c:7140: error: 'cpu_coregroup_mask' undeclared here (not in a function)
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  arch/sparc/include/asm/topology_64.h |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
> index 1c79f32..16f477d 100644
> --- a/arch/sparc/include/asm/topology_64.h
> +++ b/arch/sparc/include/asm/topology_64.h
> @@ -65,6 +65,10 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
>  #define smt_capable()				(sparc64_multi_core)
>  #endif /* CONFIG_SMP */
>  
> -#define cpu_coregroup_mask(cpu)			(&cpu_core_map[cpu])
> +extern cpumask_t cpu_core_map[NR_CPUS];
> +static inline const struct cpumask *cpu_coregroup_mask(int cpu)
> +{
> +        return &cpu_core_map[cpu];
> +}

Dave, if this change is fine with you i'd like to queue it up in 
tip:sched/domains.

Thanks,

	Ingo

Re: linux-next: build failure after merge of the final tree (tip tree related)

[David Miller]

From: Ingo Molnar <mingo@elte.hu>
Date: Tue, 12 Apr 2011 08:20:02 +0200

> 
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
>> Hi all,
>> 
>> After merging the final tree, today's linux-next build (sparc64 defconfig)
>> failed like this:
>> 
>> kernel/sched.c:7140: error: 'cpu_coregroup_mask' undeclared here (not in a function)
>> 
>> Caused by commit 2c402dc3bb50 ("sched: Unify the sched_domain build
>> functions").  On sparc64, cpu_coregroup_mask is a #define, not a function.
>> 
>> I applied tha patch below (idea stolen from s390) whcih could probably be
>> better.
>> 
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Tue, 12 Apr 2011 13:51:32 +1000
>> Subject: [PATCH] sched: fix sparc64 for sched_domain changes
>> 
>> Fixes this compile error:
>> 
>> kernel/sched.c:7140: error: 'cpu_coregroup_mask' undeclared here (not in a function)
>> 
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> ---
>>  arch/sparc/include/asm/topology_64.h |    6 +++++-
>>  1 files changed, 5 insertions(+), 1 deletions(-)
>> 
>> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
>> index 1c79f32..16f477d 100644
>> --- a/arch/sparc/include/asm/topology_64.h
>> +++ b/arch/sparc/include/asm/topology_64.h
>> @@ -65,6 +65,10 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
>>  #define smt_capable()				(sparc64_multi_core)
>>  #endif /* CONFIG_SMP */
>>  
>> -#define cpu_coregroup_mask(cpu)			(&cpu_core_map[cpu])
>> +extern cpumask_t cpu_core_map[NR_CPUS];
>> +static inline const struct cpumask *cpu_coregroup_mask(int cpu)
>> +{
>> +        return &cpu_core_map[cpu];
>> +}
> 
> Dave, if this change is fine with you i'd like to queue it up in 
> tip:sched/domains.

Yep, it's fine:

Acked-by: David S. Miller <davem@davemloft.net>

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Don Zickus]

On Tue, Dec 07, 2010 at 12:58:22PM +1100, Stephen Rothwell wrote:
> > > Don, have you got a fix for that?
> > 
> > I do.  I posted it last week, but you wanted me to post something
> > incremental instead.  I'll get that out today.
> 
> I am still reverting those 2 commits.

I posted the patch to fix it last week, not sure if Ingo needs something
else from me.

http://thread.gmane.org/gmane.linux.kernel/1069682/focus=1069960

Cheers,
Don

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

On Mon, 29 Nov 2010 09:30:47 -0500 Don Zickus <dzickus@redhat.com> wrote:
>
> On Mon, Nov 29, 2010 at 09:29:16AM +0100, Ingo Molnar wrote:
> > 
> > * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > > On Mon, 22 Nov 2010 13:39:49 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the final tree, today's linux-next build (sparc64 defconfig)
> > > > failed like this:
> > > > 
> > > > arch/sparc/kernel/nmi.c:54: error: redefinition of 'touch_nmi_watchdog'
> > > > include/linux/nmi.h:21: note: previous definition of 'touch_nmi_watchdog' was here
> > > > 
> > > > Caused (or, at least exposed) by commit
> > > > 5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a ("x86, nmi_watchdog: Remove the
> > > > old nmi_watchdog").  Sparc appears to have a touch_nmi_watchdog() and
> > > > defines ARCH_HAS_NMI_WATCHDOG but not CONFIG_HARDLOCKUP_DETECTOR.
> > > > 
> > > > I have reverted that commit for today (as well as commit
> > > > 072b198a4ad48bd722ec6d203d65422a4698eae7 "x86, nmi_watchdog: Remove all
> > > > stub function calls from old nmi_watchdog" that depends on it).
> > > 
> > > This build failure is back, so I have reverted the above commits again.
> > 
> > Don, have you got a fix for that?
> 
> I do.  I posted it last week, but you wanted me to post something
> incremental instead.  I'll get that out today.

I am still reverting those 2 commits.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

On Mon, 29 Nov 2010 13:50:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
> 
> arch/sparc/kernel/perf_event.c:1326: error: 'init_hw_perf_event' undeclared here (not in a function)
> 
> Caused by commit 004417a6d468e24399e383645c068b498eed84ad ("perf, arch:
> Cleanup perf-pmu init vs lockup-detector").
> 
> I reverted that commit for today.

I am still reverting that commit.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Peter Zijlstra]

On Mon, 2010-11-29 at 13:50 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
> 
> arch/sparc/kernel/perf_event.c:1326: error: 'init_hw_perf_event' undeclared here (not in a function)
> 
> Caused by commit 004417a6d468e24399e383645c068b498eed84ad ("perf, arch:
> Cleanup perf-pmu init vs lockup-detector").
> 
> I reverted that commit for today.

Ingo, can we back-merge this?

---
 arch/sparc/kernel/perf_event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/sparc/kernel/perf_event.c b/arch/sparc/kernel/perf_event.c
index 75c5b12..39348b1 100644
--- a/arch/sparc/kernel/perf_event.c
+++ b/arch/sparc/kernel/perf_event.c
@@ -1323,7 +1323,7 @@ int __init init_hw_perf_events(void)
 
 	return 0;
 }
-early_initcall(init_hw_perf_event);
+early_initcall(init_hw_perf_events);
 
 void perf_callchain_kernel(struct perf_callchain_entry *entry,
 			   struct pt_regs *regs)

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Don Zickus]

On Mon, Nov 29, 2010 at 09:29:16AM +0100, Ingo Molnar wrote:
> 
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi all,
> > 
> > On Mon, 22 Nov 2010 13:39:49 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the final tree, today's linux-next build (sparc64 defconfig)
> > > failed like this:
> > > 
> > > arch/sparc/kernel/nmi.c:54: error: redefinition of 'touch_nmi_watchdog'
> > > include/linux/nmi.h:21: note: previous definition of 'touch_nmi_watchdog' was here
> > > 
> > > Caused (or, at least exposed) by commit
> > > 5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a ("x86, nmi_watchdog: Remove the
> > > old nmi_watchdog").  Sparc appears to have a touch_nmi_watchdog() and
> > > defines ARCH_HAS_NMI_WATCHDOG but not CONFIG_HARDLOCKUP_DETECTOR.
> > > 
> > > I have reverted that commit for today (as well as commit
> > > 072b198a4ad48bd722ec6d203d65422a4698eae7 "x86, nmi_watchdog: Remove all
> > > stub function calls from old nmi_watchdog" that depends on it).
> > 
> > This build failure is back, so I have reverted the above commits again.
> 
> Don, have you got a fix for that?

I do.  I posted it last week, but you wanted me to post something
incremental instead.  I'll get that out today.

Cheers,
Don

> 
> Thanks,
> 
> 	Ingo

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Ingo Molnar]

* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> On Mon, 22 Nov 2010 13:39:49 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the final tree, today's linux-next build (sparc64 defconfig)
> > failed like this:
> > 
> > arch/sparc/kernel/nmi.c:54: error: redefinition of 'touch_nmi_watchdog'
> > include/linux/nmi.h:21: note: previous definition of 'touch_nmi_watchdog' was here
> > 
> > Caused (or, at least exposed) by commit
> > 5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a ("x86, nmi_watchdog: Remove the
> > old nmi_watchdog").  Sparc appears to have a touch_nmi_watchdog() and
> > defines ARCH_HAS_NMI_WATCHDOG but not CONFIG_HARDLOCKUP_DETECTOR.
> > 
> > I have reverted that commit for today (as well as commit
> > 072b198a4ad48bd722ec6d203d65422a4698eae7 "x86, nmi_watchdog: Remove all
> > stub function calls from old nmi_watchdog" that depends on it).
> 
> This build failure is back, so I have reverted the above commits again.

Don, have you got a fix for that?

Thanks,

	Ingo

linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:

arch/sparc/kernel/perf_event.c:1326: error: 'init_hw_perf_event' undeclared here (not in a function)

Caused by commit 004417a6d468e24399e383645c068b498eed84ad ("perf, arch:
Cleanup perf-pmu init vs lockup-detector").

I reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

Hi all,

On Mon, 22 Nov 2010 13:39:49 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
> 
> arch/sparc/kernel/nmi.c:54: error: redefinition of 'touch_nmi_watchdog'
> include/linux/nmi.h:21: note: previous definition of 'touch_nmi_watchdog' was here
> 
> Caused (or, at least exposed) by commit
> 5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a ("x86, nmi_watchdog: Remove the
> old nmi_watchdog").  Sparc appears to have a touch_nmi_watchdog() and
> defines ARCH_HAS_NMI_WATCHDOG but not CONFIG_HARDLOCKUP_DETECTOR.
> 
> I have reverted that commit for today (as well as commit
> 072b198a4ad48bd722ec6d203d65422a4698eae7 "x86, nmi_watchdog: Remove all
> stub function calls from old nmi_watchdog" that depends on it).

This build failure is back, so I have reverted the above commits again.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Don Zickus]

On Mon, Nov 22, 2010 at 01:39:49PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
> 
> arch/sparc/kernel/nmi.c:54: error: redefinition of 'touch_nmi_watchdog'
> include/linux/nmi.h:21: note: previous definition of 'touch_nmi_watchdog' was here
> 
> Caused (or, at least exposed) by commit
> 5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a ("x86, nmi_watchdog: Remove the
> old nmi_watchdog").  Sparc appears to have a touch_nmi_watchdog() and
> defines ARCH_HAS_NMI_WATCHDOG but not CONFIG_HARDLOCKUP_DETECTOR.

Sorry about that.  I'll push another patch to Ingo to fix this.

Cheers,
Don

linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:

arch/sparc/kernel/nmi.c:54: error: redefinition of 'touch_nmi_watchdog'
include/linux/nmi.h:21: note: previous definition of 'touch_nmi_watchdog' was here

Caused (or, at least exposed) by commit
5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a ("x86, nmi_watchdog: Remove the
old nmi_watchdog").  Sparc appears to have a touch_nmi_watchdog() and
defines ARCH_HAS_NMI_WATCHDOG but not CONFIG_HARDLOCKUP_DETECTOR.


I have reverted that commit for today (as well as commit
072b198a4ad48bd722ec6d203d65422a4698eae7 "x86, nmi_watchdog: Remove all
stub function calls from old nmi_watchdog" that depends on it).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Ingo Molnar]

* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the final tree, linux-next builds (arm corgi_defconfig,
> spitz_defconfig) fail like this:
> 
> arch/arm/kernel/perf_event.c: In function 'armpmu_event_init':
> arch/arm/kernel/perf_event.c:543: error: request for member 'num_events' in something
 not a structure or union
> 
> Caused by commit 15ac9a395a753cb28c674e7ea80386ffdff21785 ("perf: Remove
> the sysfs bits").

Thanks, fixed.

> This seems to have broken in next-20100913 and noone has noticed/bothered
> to fix it.

What appears to have happened is the following: the build bug depends on 
CONFIG_HW_PERF_EVENTS=y, which is off by default on ARM (which default 
to a v5 CPU type - while hw pmu support is for v6+ cpus).

So the regular ARM defconfig built fine both in -next and here in the 
latest perf/core tree:

  testing        arm:  -git:  pass (    0),  -tip:  pass (    4)

Some new change in linux-next appears to have turned on HW_PERF_EVENTS 
elsewhere which you thus tested for the first time - which triggered the 
build bug.

Thanks,

	Ingo

linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

Hi all,

After merging the final tree, linux-next builds (arm corgi_defconfig,
spitz_defconfig) fail like this:

arch/arm/kernel/perf_event.c: In function 'armpmu_event_init':
arch/arm/kernel/perf_event.c:543: error: request for member 'num_events' in something not a structure or union

Caused by commit 15ac9a395a753cb28c674e7ea80386ffdff21785 ("perf: Remove
the sysfs bits").

This seems to have broken in next-20100913 and noone has noticed/bothered
to fix it.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Russell King - ARM Linux]

On Thu, Sep 16, 2010 at 09:34:33AM +0200, Ingo Molnar wrote:
> 
> * Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> 
> > On Thu, Sep 16, 2010 at 08:39:22AM +0200, Ingo Molnar wrote:
> > > 
> > > * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > 
> > > > Hi all,
> > > > 
> > > > On Tue, 14 Sep 2010 00:29:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > > >
> > > > > After merging the final tree, today's linux-next build (arm
> > > > > assabet_defconfig and serveral other arm configs) failed like this:
> > > > > 
> > > > > arch/arm/mm/init.c: In function 'arm_memory_present':
> > > > > arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
> > > > > arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area'
> > > > > arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap'
> > > > > arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap'
> > > > > arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup'
> > > > > arch/arm/mm/init.c:606: error: initializer element is not constant
> > > > > arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func')
> > > > > arch/arm/mm/init.c:606: error: expected declaration or statement at end of input
> > > > > arch/arm/mm/init.c:252: warning: unused variable 'i'
> > > > > 
> > > > > Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm:
> > > > > Use new accessors") which forgot a closing brace on a new
> > > > > for_each_memblock() in arm_memory_present().
> > > > 
> > > > So this commit is back in tip and the error is back in the builds ...
> > > 
> > > The ARM defconfig build doesnt fail here:
> > > 
> > >   WARNING: modpost: Found 5 section mismatch(es).
> > >   To see full details build your kernel with:
> > >   'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> > 
> > It probably passes because that configuration doesn't result in the
> > failing code being built (maybe the failing code is only used for
> > sparsemem ?)
> 
> Yeah. If sparsemem is important then it would be helpful if you could 
> enable it in the ARM defconfig if possible - that's what most people 
> build.

But then so is flatmem too - and it's the same story for lots of other
combinations.  If we had sparsemem enabled then a similar bug could
have crept into the !SPARSEMEM code just a few lines above.

There's no correct answer here - the only answer is technologies such
as linux-next and kautobuild to build a range of configs to get the
build coverage.

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Ingo Molnar]

* Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> On Thu, Sep 16, 2010 at 08:39:22AM +0200, Ingo Molnar wrote:
> > 
> > * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > > Hi all,
> > > 
> > > On Tue, 14 Sep 2010 00:29:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the final tree, today's linux-next build (arm
> > > > assabet_defconfig and serveral other arm configs) failed like this:
> > > > 
> > > > arch/arm/mm/init.c: In function 'arm_memory_present':
> > > > arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
> > > > arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area'
> > > > arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap'
> > > > arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap'
> > > > arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup'
> > > > arch/arm/mm/init.c:606: error: initializer element is not constant
> > > > arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func')
> > > > arch/arm/mm/init.c:606: error: expected declaration or statement at end of input
> > > > arch/arm/mm/init.c:252: warning: unused variable 'i'
> > > > 
> > > > Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm:
> > > > Use new accessors") which forgot a closing brace on a new
> > > > for_each_memblock() in arm_memory_present().
> > > 
> > > So this commit is back in tip and the error is back in the builds ...
> > 
> > The ARM defconfig build doesnt fail here:
> > 
> >   WARNING: modpost: Found 5 section mismatch(es).
> >   To see full details build your kernel with:
> >   'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> 
> It probably passes because that configuration doesn't result in the
> failing code being built (maybe the failing code is only used for
> sparsemem ?)

Yeah. If sparsemem is important then it would be helpful if you could 
enable it in the ARM defconfig if possible - that's what most people 
build.

Thanks,

	Ingo

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

Hi Yinghai,

On Thu, 16 Sep 2010 00:20:36 -0700 Yinghai Lu <yinghai@kernel.org> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>

I did not write this patch ...

> @@ -249,9 +249,8 @@ static void arm_memory_present(void)
>  static void arm_memory_present(void)
>  {
>  	struct memblock_region *reg;
> -	int i;
>  
> -	for_each_memblock(memory, reg) {
> +	for_each_memblock(memory, reg)
>  		memory_present(0, memblock_region_base_pfn(reg),
>  			       memblock_region_end_pfn(reg));
>  }

That looks good (but I have not tested it).  Thanks

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Yinghai Lu]

From: Stephen Rothwell <sfr@canb.auug.org.au>

[PATCH] arm,memblock: Fix compiling with sparsemem

Stephen Rothwell found:

> > > arch/arm/mm/init.c: In function 'arm_memory_present':
> > > arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
> > > arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area'
> > > arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap'
> > > arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap'
> > > arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup'
> > > arch/arm/mm/init.c:606: error: initializer element is not constant
> > > arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func')
> > > arch/arm/mm/init.c:606: error: expected declaration or statement at end of input
> > > arch/arm/mm/init.c:252: warning: unused variable 'i'
> > >
> > > Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm:
> > > Use new accessors") which forgot a closing brace on a new
> > > for_each_memblock() in arm_memory_present().

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/arm/mm/init.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6/arch/arm/mm/init.c
===================================================================
--- linux-2.6.orig/arch/arm/mm/init.c
+++ linux-2.6/arch/arm/mm/init.c
@@ -249,9 +249,8 @@ static void arm_memory_present(void)
 static void arm_memory_present(void)
 {
 	struct memblock_region *reg;
-	int i;
 
-	for_each_memblock(memory, reg) {
+	for_each_memblock(memory, reg)
 		memory_present(0, memblock_region_base_pfn(reg),
 			       memblock_region_end_pfn(reg));
 }

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2213 bytes --]

Hi Ingo,

On Thu, 16 Sep 2010 08:39:22 +0200 Ingo Molnar <mingo@elte.hu> wrote:
>
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > On Tue, 14 Sep 2010 00:29:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the final tree, today's linux-next build (arm
> > > assabet_defconfig and serveral other arm configs) failed like this:
> > > 
> > > arch/arm/mm/init.c: In function 'arm_memory_present':
> > > arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
> > > arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area'
> > > arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap'
> > > arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap'
> > > arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup'
> > > arch/arm/mm/init.c:606: error: initializer element is not constant
> > > arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func')
> > > arch/arm/mm/init.c:606: error: expected declaration or statement at end of input
> > > arch/arm/mm/init.c:252: warning: unused variable 'i'
> > > 
> > > Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm:
> > > Use new accessors") which forgot a closing brace on a new
> > > for_each_memblock() in arm_memory_present().
> > 
> > So this commit is back in tip and the error is back in the builds ...
> 
> The ARM defconfig build doesnt fail here:
> 
>   WARNING: modpost: Found 5 section mismatch(es).
>   To see full details build your kernel with:
>   'make CONFIG_DEBUG_SECTION_MISMATCH=y'

This is not a "defconfig" build, it is just some of the other arm
"_defconfig" builds (like the one I specified above - assabet_defconfig).

> Is there some integration artifact here perhaps? If yes then linux-next 
> needs to resolve the integration artifact. If not then benh, Yinghai, 
> hpa, please have a look ...

It is clear from the patch that a closing brace was missed (see above) ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Russell King - ARM Linux]

On Thu, Sep 16, 2010 at 08:39:22AM +0200, Ingo Molnar wrote:
> 
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi all,
> > 
> > On Tue, 14 Sep 2010 00:29:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the final tree, today's linux-next build (arm
> > > assabet_defconfig and serveral other arm configs) failed like this:
> > > 
> > > arch/arm/mm/init.c: In function 'arm_memory_present':
> > > arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
> > > arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area'
> > > arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap'
> > > arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap'
> > > arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup'
> > > arch/arm/mm/init.c:606: error: initializer element is not constant
> > > arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func')
> > > arch/arm/mm/init.c:606: error: expected declaration or statement at end of input
> > > arch/arm/mm/init.c:252: warning: unused variable 'i'
> > > 
> > > Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm:
> > > Use new accessors") which forgot a closing brace on a new
> > > for_each_memblock() in arm_memory_present().
> > 
> > So this commit is back in tip and the error is back in the builds ...
> 
> The ARM defconfig build doesnt fail here:
> 
>   WARNING: modpost: Found 5 section mismatch(es).
>   To see full details build your kernel with:
>   'make CONFIG_DEBUG_SECTION_MISMATCH=y'

It probably passes because that configuration doesn't result in the
failing code being built (maybe the failing code is only used for
sparsemem ?)

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Ingo Molnar]

* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> On Tue, 14 Sep 2010 00:29:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the final tree, today's linux-next build (arm
> > assabet_defconfig and serveral other arm configs) failed like this:
> > 
> > arch/arm/mm/init.c: In function 'arm_memory_present':
> > arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
> > arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area'
> > arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap'
> > arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap'
> > arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup'
> > arch/arm/mm/init.c:606: error: initializer element is not constant
> > arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func')
> > arch/arm/mm/init.c:606: error: expected declaration or statement at end of input
> > arch/arm/mm/init.c:252: warning: unused variable 'i'
> > 
> > Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm:
> > Use new accessors") which forgot a closing brace on a new
> > for_each_memblock() in arm_memory_present().
> 
> So this commit is back in tip and the error is back in the builds ...

The ARM defconfig build doesnt fail here:

  WARNING: modpost: Found 5 section mismatch(es).
  To see full details build your kernel with:
  'make CONFIG_DEBUG_SECTION_MISMATCH=y'

Is there some integration artifact here perhaps? If yes then linux-next 
needs to resolve the integration artifact. If not then benh, Yinghai, 
hpa, please have a look ...

Thanks,

	Ingo

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

Hi all,

On Tue, 14 Sep 2010 00:29:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (arm
> assabet_defconfig and serveral other arm configs) failed like this:
> 
> arch/arm/mm/init.c: In function 'arm_memory_present':
> arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
> arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area'
> arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap'
> arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap'
> arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup'
> arch/arm/mm/init.c:606: error: initializer element is not constant
> arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func')
> arch/arm/mm/init.c:606: error: expected declaration or statement at end of input
> arch/arm/mm/init.c:252: warning: unused variable 'i'
> 
> Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm:
> Use new accessors") which forgot a closing brace on a new
> for_each_memblock() in arm_memory_present().

So this commit is back in tip and the error is back in the builds ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Peter Zijlstra]

On Mon, 2010-09-13 at 20:17 +0100, Matt Fleming wrote:
> 3f6da390 ("perf: Rework and fix the arch CPU-hotplug hooks") introduced
> this breakage. sh_pmu_setup() is missing an opening curly brace, e.g.
> 
> diff --git a/arch/sh/kernel/perf_event.c b/arch/sh/kernel/perf_event.c
> index cf39c48..036f7a9 100644
> --- a/arch/sh/kernel/perf_event.c
> +++ b/arch/sh/kernel/perf_event.c
> @@ -338,7 +338,7 @@ static struct pmu pmu = {
>  };
>  
>  static void sh_pmu_setup(int cpu)
> -
> +{
>         struct cpu_hw_events *cpuhw = &per_cpu(cpu_hw_events, cpu);
>  
>         memset(cpuhw, 0, sizeof(struct cpu_hw_events)); 


Gah, that's actually breakage from b0a873ebbf8 (perf: Register PMU
implementations), which has the below fudge:


+static struct pmu pmu = {
+       .event_init     = sh_pmu_event_init,
+       .enable         = sh_pmu_enable,
+       .disable        = sh_pmu_disable,
+       .read           = sh_pmu_read,
+};
+
 static void sh_pmu_setup(int cpu)
-{
+
        struct cpu_hw_events *cpuhw = &per_cpu(cpu_hw_events, cpu);
 
        memset(cpuhw, 0, sizeof(struct cpu_hw_events));


Ingo, could you back-merge this?

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Matt Fleming]

On Tue, Sep 14, 2010 at 12:06:13AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (many sh configs)
> failed like this:
> 
> arch/sh/kernel/perf_event.c: In function 'sh_pmu_setup':
> arch/sh/kernel/perf_event.c:342: error: parameter 'cpuhw' is initialized
> 
> And it went down hill from there.
> 
> Caused by commit b0a873ebbf87bf38bf70b5e39a7cadc96099fa13 ("perf:
> Register PMU implementations") which removed the opening brace of that
> function.

3f6da390 ("perf: Rework and fix the arch CPU-hotplug hooks") introduced
this breakage. sh_pmu_setup() is missing an opening curly brace, e.g.

diff --git a/arch/sh/kernel/perf_event.c b/arch/sh/kernel/perf_event.c
index cf39c48..036f7a9 100644
--- a/arch/sh/kernel/perf_event.c
+++ b/arch/sh/kernel/perf_event.c
@@ -338,7 +338,7 @@ static struct pmu pmu = {
 };
 
 static void sh_pmu_setup(int cpu)
-
+{
 	struct cpu_hw_events *cpuhw = &per_cpu(cpu_hw_events, cpu);
 
 	memset(cpuhw, 0, sizeof(struct cpu_hw_events));

linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

Hi all,

After merging the final tree, today's linux-next build (arm
assabet_defconfig and serveral other arm configs) failed like this:

arch/arm/mm/init.c: In function 'arm_memory_present':
arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area'
arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap'
arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap'
arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup'
arch/arm/mm/init.c:606: error: initializer element is not constant
arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func')
arch/arm/mm/init.c:606: error: expected declaration or statement at end of input
arch/arm/mm/init.c:252: warning: unused variable 'i'

Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm:
Use new accessors") which forgot a closing brace on a new
for_each_memblock() in arm_memory_present().

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi all,

After merging the final tree, today's linux-next build (many sh configs)
failed like this:

arch/sh/kernel/perf_event.c: In function 'sh_pmu_setup':
arch/sh/kernel/perf_event.c:342: error: parameter 'cpuhw' is initialized

And it went down hill from there.

Caused by commit b0a873ebbf87bf38bf70b5e39a7cadc96099fa13 ("perf:
Register PMU implementations") which removed the opening brace of that
function.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Ingo Molnar]

* Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> > Please, no, don't break the memblock code now.  I'm not reworking the
> > ARM implementation just as the merge window has opened - especially
> > as the ARM implementation has now been pulled into other people's
> > trees.
> > 
> > If there's changes to memblock which haven't been in linux-next (which,
> > as this is a new failure, that is most definitely the case), then they
> > shouldn't be going into this merge window.
> 
> I'm happy to wait and sit on the memblock churn until after ARM's in.
> 
> I can then fixup my patches.

Ok, i've zapped it all from -tip.

Thanks,

	Ingo

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Benjamin Herrenschmidt]

On Mon, 2010-08-02 at 20:13 -0700, H. Peter Anvin wrote:
> I still think that the memblock approach of having a separate data
> structure for all of memory and one for various used blocks is flawed,
> and that it would be a lot better to have a single data structure with
> attributes.  It would definitely make allocation saner.  Given that,
> there is a strong reason to keep as little of the guts exposed as
> possible.

I agree, and in fact, turning the current implementation into a single
list with attributes wouldn't necessarily be that hard as a first step. 

Ben.

Re: linux-next: build failure after merge of the final tree (tip tree related)

[H. Peter Anvin]

On 08/02/2010 06:42 PM, Benjamin Herrenschmidt wrote:
> 
> I'm happy to wait and sit on the memblock churn until after ARM's in.
> 
> I can then fixup my patches.
> 

As far as x86 is concerned, I would like to try to get the whole thing
into -tip fairly early in a kernel cycle, so that it can get -tip/-next
testing for a while before merging.

I would much rather smoke out bugs like the qla2xxx failing to implement
.shutdown and therefore doing DMA on random memory than just paper it
over by functionally re-implementing a bunch of the memblock guts in x86.

I still think that the memblock approach of having a separate data
structure for all of memory and one for various used blocks is flawed,
and that it would be a lot better to have a single data structure with
attributes.  It would definitely make allocation saner.  Given that,
there is a strong reason to keep as little of the guts exposed as possible.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Benjamin Herrenschmidt]

> Please, no, don't break the memblock code now.  I'm not reworking the
> ARM implementation just as the merge window has opened - especially
> as the ARM implementation has now been pulled into other people's
> trees.
> 
> If there's changes to memblock which haven't been in linux-next (which,
> as this is a new failure, that is most definitely the case), then they
> shouldn't be going into this merge window.

I'm happy to wait and sit on the memblock churn until after ARM's in.

I can then fixup my patches.

Cheers,
Ben.

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Benjamin Herrenschmidt]

On Tue, 2010-08-03 at 02:23 +1000, Stephen Rothwell wrote:
> 
> Lots (if not all) of the arm builds failed for next-20100802 with these
> errors:
> 
> arch/arm/mm/init.c: In function 'arm_bootmem_init':
> arch/arm/mm/init.c:184: error: implicit declaration of function 'memblock_start_pfn'
> arch/arm/mm/init.c:186: error: implicit declaration of function 'memblock_end_pfn'
> arch/arm/mm/init.c:188: error: implicit declaration of function 'memblock_size_bytes'
> 
> Caused by commit 53e16bfaf19346f59b3502e207aa66c61332075c ("memblock:
> Introduce for_each_memblock() and new accessors, and use it") interacting
> with commit 2778f62056ada442414392d7ccd41188bb631619 ("ARM: initial LMB
> trial") and some others from the arm tree.
> 
> Ben, is there no way to retain the old APIs while creating the new ones? 

I'll have a second look. It might be doable if it's only those 3
functions.

In any case, I'm happy to delay that, wait for ARM to go in, then sent a
new batch that also fixes ARM up.

Once those patches are in, we get some saner APIs to memblocks which
make it a lot easier to rewrite the core, which I think Peter want to do
(and I like his ideas of using a single list very much too).

Cheers,
Ben.

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Benjamin Herrenschmidt]

On Mon, 2010-08-02 at 09:32 -0700, H. Peter Anvin wrote:
> > Please, no, don't break the memblock code now.  I'm not reworking the
> > ARM implementation just as the merge window has opened - especially
> > as the ARM implementation has now been pulled into other people's
> > trees.
> > 
> > If there's changes to memblock which haven't been in linux-next (which,
> > as this is a new failure, that is most definitely the case), then they
> > shouldn't be going into this merge window.
> > 
> 
> Ben, what's your tack on this?

I'm perfectly happy to wait for the next merge window.. or even delay it
a bit til we can make sure ARM stuff is in, then memblock is updated to
also update ARM.

The latest failure is a bit of a concern... it shows that sh and
microblaze have not tested the series when I asked them to a while back
then, but then, I suppose everybody is short on time.

In any case, I'll fixup those glitches in my memblock branch, and we can
look at the ARM situation then and decide what to do.

Cheers,
Ben.
 

Re: linux-next: build failure after merge of the final tree (tip tree related)

[H. Peter Anvin]

On 08/02/2010 09:28 AM, Russell King wrote:
> On Tue, Aug 03, 2010 at 02:23:10AM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> Lots (if not all) of the arm builds failed for next-20100802 with these
>> errors:
>>
>> arch/arm/mm/init.c: In function 'arm_bootmem_init':
>> arch/arm/mm/init.c:184: error: implicit declaration of function 'memblock_start_pfn'
>> arch/arm/mm/init.c:186: error: implicit declaration of function 'memblock_end_pfn'
>> arch/arm/mm/init.c:188: error: implicit declaration of function 'memblock_size_bytes'
>>
>> Caused by commit 53e16bfaf19346f59b3502e207aa66c61332075c ("memblock:
>> Introduce for_each_memblock() and new accessors, and use it") interacting
>> with commit 2778f62056ada442414392d7ccd41188bb631619 ("ARM: initial LMB
>> trial") and some others from the arm tree.
> 
> Please, no, don't break the memblock code now.  I'm not reworking the
> ARM implementation just as the merge window has opened - especially
> as the ARM implementation has now been pulled into other people's
> trees.
> 
> If there's changes to memblock which haven't been in linux-next (which,
> as this is a new failure, that is most definitely the case), then they
> shouldn't be going into this merge window.
> 

Ben, what's your tack on this?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

Hi all,

On Tue, 3 Aug 2010 02:23:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Caused by commit 53e16bfaf19346f59b3502e207aa66c61332075c ("memblock:
> Introduce for_each_memblock() and new accessors, and use it") interacting
> with commit 2778f62056ada442414392d7ccd41188bb631619 ("ARM: initial LMB
> trial") and some others from the arm tree.

That same memblock commit broke the sh builds like this:

c1: warnings being treated as errors
arch/sh/mm/init.c: In function 'bootmem_init_one_node':
arch/sh/mm/init.c:227: error: unused variable 'i'
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Russell King]

On Tue, Aug 03, 2010 at 02:23:10AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Lots (if not all) of the arm builds failed for next-20100802 with these
> errors:
> 
> arch/arm/mm/init.c: In function 'arm_bootmem_init':
> arch/arm/mm/init.c:184: error: implicit declaration of function 'memblock_start_pfn'
> arch/arm/mm/init.c:186: error: implicit declaration of function 'memblock_end_pfn'
> arch/arm/mm/init.c:188: error: implicit declaration of function 'memblock_size_bytes'
> 
> Caused by commit 53e16bfaf19346f59b3502e207aa66c61332075c ("memblock:
> Introduce for_each_memblock() and new accessors, and use it") interacting
> with commit 2778f62056ada442414392d7ccd41188bb631619 ("ARM: initial LMB
> trial") and some others from the arm tree.

Please, no, don't break the memblock code now.  I'm not reworking the
ARM implementation just as the merge window has opened - especially
as the ARM implementation has now been pulled into other people's
trees.

If there's changes to memblock which haven't been in linux-next (which,
as this is a new failure, that is most definitely the case), then they
shouldn't be going into this merge window.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

Hi all,

Lots (if not all) of the arm builds failed for next-20100802 with these
errors:

arch/arm/mm/init.c: In function 'arm_bootmem_init':
arch/arm/mm/init.c:184: error: implicit declaration of function 'memblock_start_pfn'
arch/arm/mm/init.c:186: error: implicit declaration of function 'memblock_end_pfn'
arch/arm/mm/init.c:188: error: implicit declaration of function 'memblock_size_bytes'

Caused by commit 53e16bfaf19346f59b3502e207aa66c61332075c ("memblock:
Introduce for_each_memblock() and new accessors, and use it") interacting
with commit 2778f62056ada442414392d7ccd41188bb631619 ("ARM: initial LMB
trial") and some others from the arm tree.

Ben, is there no way to retain the old APIs while creating the new ones?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

Hi Frederic,

> On Wed, 23 Jun 2010 18:55:25 +0200 Frederic Weisbecker <fweisbec@gmail.com> wrote:
> >
> > There is a pending fix:
> > 
> > From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > [PATCH] perf: Fix argument of perf_arch_fetch_caller_regs
> > 
> > I'm going to send a pull request to Ingo so that gets fixed soon.

In the mean time, I will apply that patch to linux-next today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi Frederic,

On Wed, 23 Jun 2010 18:55:25 +0200 Frederic Weisbecker <fweisbec@gmail.com> wrote:
>
> There is a pending fix:
> 
> From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> [PATCH] perf: Fix argument of perf_arch_fetch_caller_regs
> 
> I'm going to send a pull request to Ingo so that gets fixed soon.

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the final tree (tip tree related)

[Frederic Weisbecker]

Hi Stephen,


On Thu, Jun 24, 2010 at 02:31:17AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (sh allnoconfig -
> in fact, all the sh configs) failed like this:
> 
> cc1: warnings being treated as errors
> In file included from include/linux/ftrace_event.h:8,
>                  from include/trace/syscall.h:6,
>                  from include/linux/syscalls.h:75,
>                  from arch/sh/kernel/sys_sh32.c:9:
> include/linux/perf_event.h:937: error: 'struct regs' declared inside parameter list
> include/linux/perf_event.h:937: error: its scope is only this definition or declaration, which is probably not what you want
> include/linux/perf_event.h: In function 'perf_fetch_caller_regs':
> include/linux/perf_event.h:952: error: passing argument 1 of 'perf_arch_fetch_caller_regs' from incompatible pointer type
> 
> This started after next-20100618.
> 
> Caused by commit b0f82b81fe6bbcf78d478071f33e44554726bc81 ("perf: Drop
> the skip argument from perf_arch_fetch_regs_caller") which contained a
> typo in the type of the first argument to perf_arch_fetch_caller_regs()
> in the case that the architecture did not define
> perf_arch_fetch_caller_regs.


There is a pending fix:

From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
[PATCH] perf: Fix argument of perf_arch_fetch_caller_regs

I'm going to send a pull request to Ingo so that gets fixed soon.

Thanks.

linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sh allnoconfig -
in fact, all the sh configs) failed like this:

cc1: warnings being treated as errors
In file included from include/linux/ftrace_event.h:8,
                 from include/trace/syscall.h:6,
                 from include/linux/syscalls.h:75,
                 from arch/sh/kernel/sys_sh32.c:9:
include/linux/perf_event.h:937: error: 'struct regs' declared inside parameter list
include/linux/perf_event.h:937: error: its scope is only this definition or declaration, which is probably not what you want
include/linux/perf_event.h: In function 'perf_fetch_caller_regs':
include/linux/perf_event.h:952: error: passing argument 1 of 'perf_arch_fetch_caller_regs' from incompatible pointer type

This started after next-20100618.

Caused by commit b0f82b81fe6bbcf78d478071f33e44554726bc81 ("perf: Drop
the skip argument from perf_arch_fetch_regs_caller") which contained a
typo in the type of the first argument to perf_arch_fetch_caller_regs()
in the case that the architecture did not define
perf_arch_fetch_caller_regs.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build failure after merge of the final tree (tip tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

Hi all,

After merging the  tree, today's linux-next build (i386 allmodconfig)
failed like this:

  VDSO    arch/x86/vdso/vdso32-int80.so.dbg
/scratch/kisskb/src/arch/x86/vdso/checkundef.sh: line 4: ccache /opt/crosstool/gcc-4.4.3-nolibc/i386-linux/bin/i386-linux-nm: No such file or directory
  VDSO    arch/x86/vdso/vdso32-sysenter.so.dbg
/scratch/kisskb/src/arch/x86/vdso/checkundef.sh: line 4: ccache /opt/crosstool/gcc-4.4.3-nolibc/i386-linux/bin/i386-linux-nm: No such file or directory

Caused by commit 05d0b0889ca9d033a960542af7f8a13b3ad4f630 ("x86, vdso:
Error out if the vdso contains external references") interacting with a
cross build that also uses ccache.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]