* linux-next: build failure after merge of the final tree (uprobes tree related)
@ 2011-11-23 4:28 Stephen Rothwell
2011-11-23 9:54 ` Srikar Dronamraju
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2011-11-23 4:28 UTC (permalink / raw)
To: Srikar Dronamraju; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]
Hi Srikar,
After merging the uprobes tree, today's linux-next build (sparc64
defconfig) failed like this:
In file included from include/linux/mm_types.h:15:0,
from include/linux/kmemcheck.h:4,
from include/linux/skbuff.h:18,
from net/8021q/vlan_core.c:1:
include/linux/uprobes.h: In function 'register_uprobe':
include/linux/uprobes.h:148:10: error: 'ENOSYS' undeclared (first use in this function)
And several more.
Caused by commit fb16338b69cd ("register_unregister_uprobe" - "Uprobes:
register/unregister probes").
I have added this patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 23 Nov 2011 15:11:20 +1100
Subject: [PATCH] uprobes: using ENOSYS requires errno.h
Fixes this build problem:
In file included from include/linux/mm_types.h:15:0,
from include/linux/kmemcheck.h:4,
from include/linux/skbuff.h:18,
from net/8021q/vlan_core.c:1:
include/linux/uprobes.h: In function 'register_uprobe':
include/linux/uprobes.h:148:10: error: 'ENOSYS' undeclared (first use in this function)
when CONFIG_UPROBES is not defined.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/linux/uprobes.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 091dfb8..e2e0674 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -23,6 +23,7 @@
* Jim Keniston
*/
+#include <linux/errno.h>
#include <linux/rbtree.h>
struct vm_area_struct;
--
1.7.7.3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the final tree (uprobes tree related)
2011-11-23 4:28 linux-next: build failure after merge of the final tree (uprobes tree related) Stephen Rothwell
@ 2011-11-23 9:54 ` Srikar Dronamraju
0 siblings, 0 replies; 4+ messages in thread
From: Srikar Dronamraju @ 2011-11-23 9:54 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel
Hey Stephen,
> After merging the uprobes tree, today's linux-next build (sparc64
> defconfig) failed like this:
>
> In file included from include/linux/mm_types.h:15:0,
> from include/linux/kmemcheck.h:4,
> from include/linux/skbuff.h:18,
> from net/8021q/vlan_core.c:1:
> include/linux/uprobes.h: In function 'register_uprobe':
> include/linux/uprobes.h:148:10: error: 'ENOSYS' undeclared (first use in this function)
>
Oh sorry for missing this.
> And several more.
>
> Caused by commit fb16338b69cd ("register_unregister_uprobe" - "Uprobes:
> register/unregister probes").
>
> I have added this patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 23 Nov 2011 15:11:20 +1100
> Subject: [PATCH] uprobes: using ENOSYS requires errno.h
>
> Fixes this build problem:
>
> In file included from include/linux/mm_types.h:15:0,
> from include/linux/kmemcheck.h:4,
> from include/linux/skbuff.h:18,
> from net/8021q/vlan_core.c:1:
> include/linux/uprobes.h: In function 'register_uprobe':
> include/linux/uprobes.h:148:10: error: 'ENOSYS' undeclared (first use in this function)
>
> when CONFIG_UPROBES is not defined.
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> include/linux/uprobes.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
> index 091dfb8..e2e0674 100644
> --- a/include/linux/uprobes.h
> +++ b/include/linux/uprobes.h
> @@ -23,6 +23,7 @@
> * Jim Keniston
> */
>
> +#include <linux/errno.h>
> #include <linux/rbtree.h>
>
> struct vm_area_struct;
Yes, this is the right fix. So I will fold this into my patch.
--
Thanks and Regards
Srikar
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the final tree (uprobes tree related)
2011-11-23 3:44 Stephen Rothwell
@ 2011-11-23 10:42 ` Srikar Dronamraju
0 siblings, 0 replies; 4+ messages in thread
From: Srikar Dronamraju @ 2011-11-23 10:42 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
>
> In file included from include/linux/mm_types.h:15:0,
> from include/linux/sched.h:64,
> from arch/powerpc/mm/mem.c:21:
> include/linux/uprobes.h:174:49: error: 'struct mm_struct' declared inside parameter list [-Werror]
> include/linux/uprobes.h:174:49: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
>
> And many more similar.
>
> Caused by commit 61fafad13005 ("uprobes_xol" - "uprobes: slot allocation").
Thanks for reporting this.
I have folded your fix into the patch.
--
Thanks and Regards
Srikar
^ permalink raw reply [flat|nested] 4+ messages in thread
* linux-next: build failure after merge of the final tree (uprobes tree related)
@ 2011-11-23 3:44 Stephen Rothwell
2011-11-23 10:42 ` Srikar Dronamraju
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2011-11-23 3:44 UTC (permalink / raw)
To: Srikar Dronamraju; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]
Hi Srikar,
After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:
In file included from include/linux/mm_types.h:15:0,
from include/linux/sched.h:64,
from arch/powerpc/mm/mem.c:21:
include/linux/uprobes.h:174:49: error: 'struct mm_struct' declared inside parameter list [-Werror]
include/linux/uprobes.h:174:49: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
And many more similar.
Caused by commit 61fafad13005 ("uprobes_xol" - "uprobes: slot allocation").
I have added the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 23 Nov 2011 14:35:01 +1100
Subject: [PATCH] uprobes: declare mm_struct before its use in uprobes.h
Since there is a circular dependency between uprobes.h and mm_type.h
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/linux/uprobes.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 20bdd0a..091dfb8 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -26,6 +26,7 @@
#include <linux/rbtree.h>
struct vm_area_struct;
+struct mm_struct;
#ifdef CONFIG_ARCH_SUPPORTS_UPROBES
#include <asm/uprobes.h>
#else
--
1.7.7.3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-23 10:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-23 4:28 linux-next: build failure after merge of the final tree (uprobes tree related) Stephen Rothwell
2011-11-23 9:54 ` Srikar Dronamraju
-- strict thread matches above, loose matches on Subject: below --
2011-11-23 3:44 Stephen Rothwell
2011-11-23 10:42 ` Srikar Dronamraju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).