linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (net-next tree related)
Date: Wed, 23 Nov 2011 15:02:13 -0800	[thread overview]
Message-ID: <20111123150213.ed7257cb.akpm@linux-foundation.org> (raw)
In-Reply-To: <20111123120937.GB27968@hmsreliant.think-freely.org>

On Wed, 23 Nov 2011 07:09:37 -0500
Neil Horman <nhorman@tuxdriver.com> wrote:

> On Wed, Nov 23, 2011 at 03:00:04PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the final tree, today's linux-next build (powerpc allnoconfig)
> > failed like this:
> > 
> > In file included from include/linux/netdevice.h:53:0,
> >                  from include/linux/icmpv6.h:173,
> >                  from include/linux/ipv6.h:220,
> >                  from include/net/ipv6.h:16,
> >                  from include/linux/sunrpc/clnt.h:26,
> >                  from include/linux/nfs_fs.h:50,
> >                  from init/do_mounts.c:20:
> > include/net/netprio_cgroup.h:23:29: error: field 'css' has incomplete type
>
> ...
>
> FYI, I've got a more appropriate fix building right now getting posted for the
> net-next tree.  I'll cc you on it.

This header looks to be pretty screwed up:

- Extraneous newline after "struct cgroup_netprio_state"

- Weird special-casing of the CONFIG_CGROUPS &&
  !CONFIG_NETPRIO_CGROUP case looks suspicious.

- Unnecessary use of IS_ENABLED - jsut use #ifdef CONFIG_NETPRIO_CGROUP

- Adds code stubs specifically for the CONFIG_CGROUPS &&
  !CONFIG_NETPRIO_CGROUP case.  Doesn't add any for the !CONFIG_CGROUPS
  case.  Seems wrong.

- Uses empty macros for the sock_update_netprioidx() and
  skb_update_prio() which can cause build errors.  Should be changed to
  plain old typechecked inline C functions.  If that causes build
  errors then something else is screwed up.

- Adds a stub for skb_update_prio() but there's no non-stub version
  of it.

also

- doesn't compile


Needs a thorough redo.  Please take a look at the other cgroup
subsystem headers.  The basic pattern is

#ifdef CONFIG_FOO_CGROUP
<definitions and declarations>
#else
<any needed stubs go here>
#endif

And that's it.

  reply	other threads:[~2011-11-23 23:02 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23  4:00 linux-next: build failure after merge of the final tree (net-next tree related) Stephen Rothwell
2011-11-23 12:09 ` Neil Horman
2011-11-23 23:02   ` Andrew Morton [this message]
2011-11-23 23:44     ` David Miller
2011-12-14  7:07 Stephen Rothwell
2011-12-14 18:35 ` David Miller
2012-02-20  5:15 Stephen Rothwell
2012-02-20  5:46 ` David Miller
2012-04-05  3:25 Stephen Rothwell
2012-04-05  3:59 ` David Miller
2012-04-06  7:09   ` Giuseppe CAVALLARO
2012-04-06  7:30     ` Giuseppe CAVALLARO
2012-04-10  5:29 Stephen Rothwell
2012-04-10 13:26 ` David Miller
2012-04-19  6:28 Stephen Rothwell
2012-04-19  6:40 ` David Miller
2012-04-30  5:58 Stephen Rothwell
2012-04-30 17:22 ` David Miller
2012-05-03  6:16 Stephen Rothwell
2012-05-03  6:26 ` David Miller
2012-07-22  6:34 Stephen Rothwell
2012-07-22  7:29 ` Jiri Pirko
2012-09-04  6:58 Stephen Rothwell
2012-09-04 18:20 ` David Miller
2012-09-04 19:50   ` Jerry Chu
2012-09-05  5:39 Stephen Rothwell
2012-09-05 21:46 ` David Miller
2012-09-20  7:36 Stephen Rothwell
2012-09-20  9:10 ` Mika Westerberg
2012-09-20 20:45   ` David Miller
2012-09-20 22:15     ` Stephen Rothwell
2012-09-20 22:22       ` Benjamin Herrenschmidt
2012-09-20 22:53         ` David Miller
2012-09-21 21:46           ` Benjamin Herrenschmidt
2012-09-22 20:00             ` David Miller
2012-09-22 21:20               ` Benjamin Herrenschmidt
2012-09-20 22:28     ` Stephen Rothwell
2012-09-21  1:37 ` Stephen Rothwell
2013-01-03  3:23 Stephen Rothwell
2013-01-03  3:28 ` David Miller
2013-01-03  9:51 ` David Miller
2013-03-28  5:04 Stephen Rothwell
2013-03-28  5:19 ` David Miller
2013-04-12  6:00 Stephen Rothwell
2013-04-12  7:08 ` David Miller
2013-04-23  7:46 Stephen Rothwell
2013-04-23 17:10 ` David Miller
2013-04-23 23:44 ` David Rientjes
2013-06-26  7:56 Stephen Rothwell
2013-06-26  8:07 ` Alexey Brodkin
2013-06-26  8:36   ` David Miller
2013-07-03  7:48 Stephen Rothwell
2013-07-03  7:51 ` Sedat Dilek
2013-07-03  8:45 ` Eliezer Tamir
2013-07-03 19:17 ` David Miller
2013-09-02  9:11 Stephen Rothwell
2013-09-02  9:18 ` Cong Wang
2014-03-17 10:13 Stephen Rothwell
2014-03-17 10:21 Stephen Rothwell
2014-03-19  3:11 ` David Miller
2014-03-18  7:27 Stephen Rothwell
2014-03-19  3:13 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123150213.ed7257cb.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).