linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Deepak SIKRI <deepak.sikri@st.com>,
	Shiraz Hashim <shiraz.hashim@st.com>,
	Vikas Manocha <vikas.manocha@st.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: linux-next: build failure after merge of the final tree (net-next tree related)
Date: Thu, 5 Apr 2012 13:25:15 +1000	[thread overview]
Message-ID: <20120405132515.e61465875407a452c1a6f78e@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c: In function 'stmmac_probe_config_dt':
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:53:7: error: 'struct plat_stmmacenet_data' has no member named 'pbl'

Caused by commit 8327eb65e795 ("stmmac: re-work the internal GMAC DMA
platf parameters").  Clearly I am missing something, because I can't see
how that patch is correct since nothing ever assigns to the new dma_cfg
pointer but it is dereferenced.

I have added this patch to make it build today, but it is obviously not
correct.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 5 Apr 2012 13:19:21 +1000
Subject: [PATCH] stmmac: hack to make it build

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 116529a..1e4d12d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -50,7 +50,7 @@ static int __devinit stmmac_probe_config_dt(struct platform_device *pdev,
 	 * once needed on other platforms.
 	 */
 	if (of_device_is_compatible(np, "st,spear600-gmac")) {
-		plat->pbl = 8;
+/*		plat->pbl = 8; */
 		plat->has_gmac = 1;
 		plat->pmt = 1;
 	}
-- 
1.7.10.rc3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2012-04-05  3:25 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-05  3:25 Stephen Rothwell [this message]
2012-04-05  3:59 ` linux-next: build failure after merge of the final tree (net-next tree related) David Miller
2012-04-06  7:09   ` Giuseppe CAVALLARO
2012-04-06  7:30     ` Giuseppe CAVALLARO
  -- strict thread matches above, loose matches on Subject: below --
2014-03-18  7:27 Stephen Rothwell
2014-03-19  3:13 ` David Miller
2014-03-17 10:21 Stephen Rothwell
2014-03-19  3:11 ` David Miller
2014-03-17 10:13 Stephen Rothwell
2013-09-02  9:11 Stephen Rothwell
2013-09-02  9:18 ` Cong Wang
2013-07-03  7:48 Stephen Rothwell
2013-07-03  7:51 ` Sedat Dilek
2013-07-03  8:45 ` Eliezer Tamir
2013-07-03 19:17 ` David Miller
2013-06-26  7:56 Stephen Rothwell
2013-06-26  8:07 ` Alexey Brodkin
2013-06-26  8:36   ` David Miller
2013-04-23  7:46 Stephen Rothwell
2013-04-23 17:10 ` David Miller
2013-04-23 23:44 ` David Rientjes
2013-04-12  6:00 Stephen Rothwell
2013-04-12  7:08 ` David Miller
2013-03-28  5:04 Stephen Rothwell
2013-03-28  5:19 ` David Miller
2013-01-03  3:23 Stephen Rothwell
2013-01-03  3:28 ` David Miller
2013-01-03  9:51 ` David Miller
2012-09-20  7:36 Stephen Rothwell
2012-09-20  9:10 ` Mika Westerberg
2012-09-20 20:45   ` David Miller
2012-09-20 22:15     ` Stephen Rothwell
2012-09-20 22:22       ` Benjamin Herrenschmidt
2012-09-20 22:53         ` David Miller
2012-09-21 21:46           ` Benjamin Herrenschmidt
2012-09-22 20:00             ` David Miller
2012-09-22 21:20               ` Benjamin Herrenschmidt
2012-09-20 22:28     ` Stephen Rothwell
2012-09-21  1:37 ` Stephen Rothwell
2012-09-05  5:39 Stephen Rothwell
2012-09-05 21:46 ` David Miller
2012-09-04  6:58 Stephen Rothwell
2012-09-04 18:20 ` David Miller
2012-09-04 19:50   ` Jerry Chu
2012-07-22  6:34 Stephen Rothwell
2012-07-22  7:29 ` Jiri Pirko
2012-05-03  6:16 Stephen Rothwell
2012-05-03  6:26 ` David Miller
2012-04-30  5:58 Stephen Rothwell
2012-04-30 17:22 ` David Miller
2012-04-19  6:28 Stephen Rothwell
2012-04-19  6:40 ` David Miller
2012-04-10  5:29 Stephen Rothwell
2012-04-10 13:26 ` David Miller
2012-02-20  5:15 Stephen Rothwell
2012-02-20  5:46 ` David Miller
2011-12-14  7:07 Stephen Rothwell
2011-12-14 18:35 ` David Miller
2011-11-23  4:00 Stephen Rothwell
2011-11-23 12:09 ` Neil Horman
2011-11-23 23:02   ` Andrew Morton
2011-11-23 23:44     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120405132515.e61465875407a452c1a6f78e@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=davem@davemloft.net \
    --cc=deepak.sikri@st.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=shiraz.hashim@st.com \
    --cc=vikas.manocha@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).