* linux-next: manual merge of the virtio tree with the rr-fixes tree
@ 2013-04-02 3:17 Stephen Rothwell
2013-04-02 5:29 ` Amit Shah
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2013-04-02 3:17 UTC (permalink / raw)
To: Rusty Russell; +Cc: linux-next, linux-kernel, Amit Shah
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
Hi Rusty,
Today's linux-next merge of the virtio tree got a conflict in
drivers/char/virtio_console.c between commit 9ba5c80b1aea ("virtio:
console: add locking around c_ovq operations") from the rr-fixes tree and
commit 6797999d9958 ("virtio_console: use simplified virtqueue
accessors") from the virtio tree.
I fixed it up (see below) and can carry the fix as necessary (no action
is required).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc drivers/char/virtio_console.c
index ce5f3fc,6d59f16..0000000
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@@ -570,9 -569,7 +570,9 @@@ static ssize_t __send_control_msg(struc
vq = portdev->c_ovq;
sg_init_one(sg, &cpkt, sizeof(cpkt));
+
+ spin_lock(&portdev->c_ovq_lock);
- if (virtqueue_add_buf(vq, sg, 1, 0, &cpkt, GFP_ATOMIC) == 0) {
+ if (virtqueue_add_outbuf(vq, sg, 1, &cpkt, GFP_ATOMIC) == 0) {
virtqueue_kick(vq);
while (!virtqueue_get_buf(vq, &len))
cpu_relax();
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: manual merge of the virtio tree with the rr-fixes tree
2013-04-02 3:17 linux-next: manual merge of the virtio tree with the rr-fixes tree Stephen Rothwell
@ 2013-04-02 5:29 ` Amit Shah
0 siblings, 0 replies; 2+ messages in thread
From: Amit Shah @ 2013-04-02 5:29 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Rusty Russell, linux-next, linux-kernel
On (Tue) 02 Apr 2013 [14:17:39], Stephen Rothwell wrote:
> Hi Rusty,
>
> Today's linux-next merge of the virtio tree got a conflict in
> drivers/char/virtio_console.c between commit 9ba5c80b1aea ("virtio:
> console: add locking around c_ovq operations") from the rr-fixes tree and
> commit 6797999d9958 ("virtio_console: use simplified virtqueue
> accessors") from the virtio tree.
>
> I fixed it up (see below) and can carry the fix as necessary (no action
> is required).
Looks OK, just a context change.
Thanks,
Amit
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-02 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-02 3:17 linux-next: manual merge of the virtio tree with the rr-fixes tree Stephen Rothwell
2013-04-02 5:29 ` Amit Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).