From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Robert Love <rlove@google.com>
Cc: Shankar Brahadeeswaran <shankoo77@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
Bjorn Bringert <bringert@google.com>,
devel <devel@driverdev.osuosl.org>,
Hugh Dickins <hughd@google.com>,
Anjana V Kumar <anjanavk12@gmail.com>,
Dad <akpm@linux-foundation.org>,
linux-next <linux-next@vger.kernel.org>
Subject: Re: [PATCH -next] ashmem: Fix ashmem_shrink deadlock.
Date: Mon, 13 May 2013 17:42:16 -0400 [thread overview]
Message-ID: <20130513214216.GA23743@kroah.com> (raw)
In-Reply-To: <1367416573-5430-1-git-send-email-rlove@google.com>
On Wed, May 01, 2013 at 09:56:13AM -0400, Robert Love wrote:
> Don't acquire ashmem_mutex in ashmem_shrink if we've somehow recursed into the
> shrinker code from within ashmem. Just bail out, avoiding a deadlock. This is
> fine, as ashmem cache pruning is advisory anyhow.
>
> Signed-off-by: Robert Love <rlove@google.com>
> ---
> drivers/staging/android/ashmem.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Based on Andrew's review comments, I'll drop this from my queue and wait
for a "better" fix for this.
thanks,
greg k-h
next prev parent reply other threads:[~2013-05-13 23:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 13:56 [PATCH -next] ashmem: Fix ashmem_shrink deadlock Robert Love
2013-05-01 15:54 ` David Rientjes
2013-05-02 18:22 ` David Rientjes
2013-05-02 20:39 ` Greg Kroah-Hartman
2013-05-07 20:52 ` Andrew Morton
2013-05-13 21:42 ` Greg Kroah-Hartman [this message]
2013-05-14 3:29 ` Neil Zhang
2013-05-14 3:37 ` Raul Xiong
2013-05-16 8:15 ` Raul Xiong
2013-05-16 13:44 ` Robert Love
2013-05-16 16:45 ` Andrew Morton
2013-05-16 17:08 ` Robert Love
2013-05-16 17:19 ` Andrew Morton
2013-05-16 17:28 ` Robert Love
2013-09-17 5:05 ` Raul Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513214216.GA23743@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=anjanavk12@gmail.com \
--cc=bringert@google.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rlove@google.com \
--cc=shankoo77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).