* next-20150511 / omap2-mcspi: regression for sdp4430 boot
@ 2015-05-11 16:50 Nishanth Menon
2015-05-11 17:07 ` Michael Welling
0 siblings, 1 reply; 10+ messages in thread
From: Nishanth Menon @ 2015-05-11 16:50 UTC (permalink / raw)
To: Mark Brown, Michael Welling, linux-omap, linux-arm-kernel,
linux-next, linux-spi
Hi,
SDP4430 uses a SPI based network chip ks8851.
next-20150508:
https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt
However, next-20150511:
https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt
Generates infinite "ks8851 spi1.0: ks8851_irq: spi bus error" errors
and hangs the platform.
Bisected the issue down to the following two commits when reverted
allows the board to function:
commit b28cb9414db9f8e42ac18c9e360e4e99cda42489
Author: Michael Welling <mwelling@ieee.org>
Date: Thu May 7 18:36:53 2015 -0500
spi: omap2-mcspi: Switch driver to use transfer_one
Switches from transfer_one_message to transfer_one to prepare
driver for
use of GPIO chip selects.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Reverting this alone: http://paste.ubuntu.org.cn/2594735 (did not boot up)
commit bc7f9bbc80bcc77745b3f54ec4e7103e3e142bb9
Author: Michael Welling <mwelling@ieee.org>
Date: Fri May 8 13:31:01 2015 -0500
spi: omap2-mcspi: Add gpio_request and init CS
If GPIO chip select is specified, request the GPIO in the setup
function
and release it in the cleanup function.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Reverting this as well allowed boot.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot 2015-05-11 16:50 next-20150511 / omap2-mcspi: regression for sdp4430 boot Nishanth Menon @ 2015-05-11 17:07 ` Michael Welling 2015-05-11 18:27 ` Nishanth Menon 0 siblings, 1 reply; 10+ messages in thread From: Michael Welling @ 2015-05-11 17:07 UTC (permalink / raw) To: Nishanth Menon Cc: Mark Brown, linux-omap, linux-arm-kernel, linux-next, linux-spi On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote: > Hi, > > SDP4430 uses a SPI based network chip ks8851. > > next-20150508: > https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt > > However, next-20150511: > https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt > I will look into this but it is going to be difficult to debug with access to the hardware. This is what I get for changing a driver that effects so many SoCs. > Generates infinite "ks8851 spi1.0: ks8851_irq: spi bus error" errors > and hangs the platform. > > Bisected the issue down to the following two commits when reverted > allows the board to function: > > > commit b28cb9414db9f8e42ac18c9e360e4e99cda42489 > Author: Michael Welling <mwelling@ieee.org> > Date: Thu May 7 18:36:53 2015 -0500 > > spi: omap2-mcspi: Switch driver to use transfer_one > > Switches from transfer_one_message to transfer_one to prepare > driver for > use of GPIO chip selects. > > Signed-off-by: Michael Welling <mwelling@ieee.org> > Signed-off-by: Mark Brown <broonie@kernel.org> > > Reverting this alone: http://paste.ubuntu.org.cn/2594735 (did not boot up) > > commit bc7f9bbc80bcc77745b3f54ec4e7103e3e142bb9 > Author: Michael Welling <mwelling@ieee.org> > Date: Fri May 8 13:31:01 2015 -0500 > > spi: omap2-mcspi: Add gpio_request and init CS > > If GPIO chip select is specified, request the GPIO in the setup > function > and release it in the cleanup function. > > Signed-off-by: Michael Welling <mwelling@ieee.org> > Signed-off-by: Mark Brown <broonie@kernel.org> > > Reverting this as well allowed boot. > > -- > Regards, > Nishanth Menon ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot 2015-05-11 17:07 ` Michael Welling @ 2015-05-11 18:27 ` Nishanth Menon [not found] ` <5550F47C.1030902-l0cyMroinI0@public.gmane.org> 2015-05-11 18:54 ` Michael Welling 0 siblings, 2 replies; 10+ messages in thread From: Nishanth Menon @ 2015-05-11 18:27 UTC (permalink / raw) To: Michael Welling Cc: Mark Brown, linux-omap, linux-arm-kernel, linux-next, linux-spi On 05/11/2015 12:07 PM, Michael Welling wrote: > On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote: >> Hi, >> >> SDP4430 uses a SPI based network chip ks8851. >> >> next-20150508: >> https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt >> >> However, next-20150511: >> https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt >> > > I will look into this but it is going to be difficult to debug with access to the hardware. > This is what I get for changing a driver that effects so many SoCs. > Let me know if there is any test patch you'd want me to run. The board is on a remote "board farm" which most of TI folks have access to as well.. So, if you need anything run, just send out a debug patch OR a potential fix and we can help try it out and provide logs back for your debug. -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <5550F47C.1030902-l0cyMroinI0@public.gmane.org>]
* Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot [not found] ` <5550F47C.1030902-l0cyMroinI0@public.gmane.org> @ 2015-05-11 18:30 ` Michael Welling 2015-05-11 19:00 ` Nishanth Menon 0 siblings, 1 reply; 10+ messages in thread From: Michael Welling @ 2015-05-11 18:30 UTC (permalink / raw) To: Nishanth Menon Cc: Mark Brown, linux-omap, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-next, linux-spi-u79uwXL29TY76Z2rM5mHXA On Mon, May 11, 2015 at 01:27:08PM -0500, Nishanth Menon wrote: > On 05/11/2015 12:07 PM, Michael Welling wrote: > > On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote: > >> Hi, > >> > >> SDP4430 uses a SPI based network chip ks8851. > >> > >> next-20150508: > >> https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt > >> > >> However, next-20150511: > >> https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt > >> > > > > I will look into this but it is going to be difficult to debug with access to the hardware. > > This is what I get for changing a driver that effects so many SoCs. > > > > Let me know if there is any test patch you'd want me to run. The board > is on a remote "board farm" which most of TI folks have access to as > well.. So, if you need anything run, just send out a debug patch OR a > potential fix and we can help try it out and provide logs back for > your debug. Okay. It looks like you revert the patches in the wrong order above. The GPIO patch should apply after the transfer_one patch so it should logically be reverted in the reverse order. > > > -- > Regards, > Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot 2015-05-11 18:30 ` Michael Welling @ 2015-05-11 19:00 ` Nishanth Menon 2015-05-11 20:16 ` Michael Welling 0 siblings, 1 reply; 10+ messages in thread From: Nishanth Menon @ 2015-05-11 19:00 UTC (permalink / raw) To: Michael Welling Cc: linux-omap, Mark Brown, linux-next, linux-arm-kernel, linux-spi On 05/11/2015 01:30 PM, Michael Welling wrote: > On Mon, May 11, 2015 at 01:27:08PM -0500, Nishanth Menon wrote: >> On 05/11/2015 12:07 PM, Michael Welling wrote: >>> On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote: >>>> Hi, >>>> >>>> SDP4430 uses a SPI based network chip ks8851. >>>> >>>> next-20150508: >>>> https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt >>>> >>>> However, next-20150511: >>>> https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt >>>> >>> >>> I will look into this but it is going to be difficult to debug with access to the hardware. >>> This is what I get for changing a driver that effects so many SoCs. >>> >> >> Let me know if there is any test patch you'd want me to run. The board >> is on a remote "board farm" which most of TI folks have access to as >> well.. So, if you need anything run, just send out a debug patch OR a >> potential fix and we can help try it out and provide logs back for >> your debug. > > Okay. > > It looks like you revert the patches in the wrong order above. > > The GPIO patch should apply after the transfer_one patch so it should > logically be reverted in the reverse order. > Apologies on a slow response, was tracking another LPAE regression down. I did do that -> but logged it in reverse - unfortunately it seems to have caused a little more confusion :(. is there something else you'd like me to do? git log next-20150508..next-20150511 drivers/spi Tells me: commit bc7f9bbc80bcc77745b3f54ec4e7103e3e142bb9 Author: Michael Welling <mwelling@ieee.org> Date: Fri May 8 13:31:01 2015 -0500 spi: omap2-mcspi: Add gpio_request and init CS If GPIO chip select is specified, request the GPIO in the setup function and release it in the cleanup function. Signed-off-by: Michael Welling <mwelling@ieee.org> Signed-off-by: Mark Brown <broonie@kernel.org> commit b28cb9414db9f8e42ac18c9e360e4e99cda42489 Author: Michael Welling <mwelling@ieee.org> Date: Thu May 7 18:36:53 2015 -0500 spi: omap2-mcspi: Switch driver to use transfer_one Switches from transfer_one_message to transfer_one to prepare driver for use of GPIO chip selects. Signed-off-by: Michael Welling <mwelling@ieee.org> Signed-off-by: Mark Brown <broonie@kernel.org> my tested git log looks as follows: (redid it just to be sure): a4617b41e04c Revert "spi: omap2-mcspi: Switch driver to use transfer_one" http://paste.ubuntu.org.cn/2595136 b49011271c7f Revert "spi: omap2-mcspi: Add gpio_request and init CS" http://paste.ubuntu.org.cn/2595142 012034602bd6 HACK: Makefile: Build a uImage with dtb already appended f17107cb8886 Add linux-next specific files for 20150511 012034602bd6 commit is https://github.com/nmenon/linux-2.6-playground/commit/177f5f71b3f2 -> for legacy platforms needing uImage based booting. -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot 2015-05-11 19:00 ` Nishanth Menon @ 2015-05-11 20:16 ` Michael Welling 2015-05-12 17:18 ` Nishanth Menon 0 siblings, 1 reply; 10+ messages in thread From: Michael Welling @ 2015-05-11 20:16 UTC (permalink / raw) To: Nishanth Menon Cc: Mark Brown, linux-omap, linux-arm-kernel, linux-next, linux-spi [-- Attachment #1: Type: text/plain, Size: 3359 bytes --] On Mon, May 11, 2015 at 02:00:08PM -0500, Nishanth Menon wrote: > On 05/11/2015 01:30 PM, Michael Welling wrote: > > On Mon, May 11, 2015 at 01:27:08PM -0500, Nishanth Menon wrote: > >> On 05/11/2015 12:07 PM, Michael Welling wrote: > >>> On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote: > >>>> Hi, > >>>> > >>>> SDP4430 uses a SPI based network chip ks8851. > >>>> > >>>> next-20150508: > >>>> https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt > >>>> > >>>> However, next-20150511: > >>>> https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt > >>>> > >>> > >>> I will look into this but it is going to be difficult to debug with access to the hardware. > >>> This is what I get for changing a driver that effects so many SoCs. > >>> > >> > >> Let me know if there is any test patch you'd want me to run. The board > >> is on a remote "board farm" which most of TI folks have access to as > >> well.. So, if you need anything run, just send out a debug patch OR a > >> potential fix and we can help try it out and provide logs back for > >> your debug. > > > > Okay. > > > > It looks like you revert the patches in the wrong order above. > > > > The GPIO patch should apply after the transfer_one patch so it should > > logically be reverted in the reverse order. > > > Apologies on a slow response, was tracking another LPAE regression down. > > I did do that -> but logged it in reverse - unfortunately it seems to > have caused a little more confusion :(. is there something else you'd > like me to do? Okay I have another patch that appears to fix the issue on my board. Please test the attached patch and see if it fixes the issue on your board. If it does, I will send it upstream. > > git log next-20150508..next-20150511 drivers/spi > Tells me: > > commit bc7f9bbc80bcc77745b3f54ec4e7103e3e142bb9 > Author: Michael Welling <mwelling@ieee.org> > Date: Fri May 8 13:31:01 2015 -0500 > > spi: omap2-mcspi: Add gpio_request and init CS > > If GPIO chip select is specified, request the GPIO in the setup > function > and release it in the cleanup function. > > Signed-off-by: Michael Welling <mwelling@ieee.org> > Signed-off-by: Mark Brown <broonie@kernel.org> > > commit b28cb9414db9f8e42ac18c9e360e4e99cda42489 > Author: Michael Welling <mwelling@ieee.org> > Date: Thu May 7 18:36:53 2015 -0500 > > spi: omap2-mcspi: Switch driver to use transfer_one > > Switches from transfer_one_message to transfer_one to prepare > driver for > use of GPIO chip selects. > > Signed-off-by: Michael Welling <mwelling@ieee.org> > Signed-off-by: Mark Brown <broonie@kernel.org> > > > > my tested git log looks as follows: (redid it just to be sure): > > a4617b41e04c Revert "spi: omap2-mcspi: Switch driver to use transfer_one" > http://paste.ubuntu.org.cn/2595136 > > b49011271c7f Revert "spi: omap2-mcspi: Add gpio_request and init CS" > http://paste.ubuntu.org.cn/2595142 > > > 012034602bd6 HACK: Makefile: Build a uImage with dtb already appended > f17107cb8886 Add linux-next specific files for 20150511 > > 012034602bd6 commit is > https://github.com/nmenon/linux-2.6-playground/commit/177f5f71b3f2 -> > for legacy platforms needing uImage based booting. > > -- > Regards, > Nishanth Menon [-- Attachment #2: omap-mcspi.patch --] [-- Type: text/x-diff, Size: 2909 bytes --] GPIO chip select patch series appears to have broken the native chip select support. This patch pulls the manual native chip select toggling out of the transfer_one routine and adds a set_cs routine. Tested natively on AM3354 with SPI serial flash on spi0cs0. Signed-off-by: Michael Welling <mwelling@ieee.org> --- drivers/spi/spi-omap2-mcspi.c | 33 +++++++++++---------------------- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 90cf7e7..a7d85c5 100644 --- a/drivers/spi/spi-omap2-mcspi.c +++ b/drivers/spi/spi-omap2-mcspi.c @@ -243,17 +243,20 @@ static void omap2_mcspi_set_enable(const struct spi_device *spi, int enable) mcspi_read_cs_reg(spi, OMAP2_MCSPI_CHCTRL0); } -static void omap2_mcspi_force_cs(struct spi_device *spi, int cs_active) +static void omap2_mcspi_set_cs(struct spi_device *spi, bool enable) { u32 l; - l = mcspi_cached_chconf0(spi); - if (cs_active) - l |= OMAP2_MCSPI_CHCONF_FORCE; - else - l &= ~OMAP2_MCSPI_CHCONF_FORCE; + if (spi->controller_state) { + l = mcspi_cached_chconf0(spi); - mcspi_write_chconf0(spi, l); + if (enable) + l &= ~OMAP2_MCSPI_CHCONF_FORCE; + else + l |= OMAP2_MCSPI_CHCONF_FORCE; + + mcspi_write_chconf0(spi, l); + } } static void omap2_mcspi_set_master_mode(struct spi_master *master) @@ -1075,7 +1078,6 @@ static int omap2_mcspi_work_one(struct omap2_mcspi *mcspi, struct spi_master *master; struct omap2_mcspi_dma *mcspi_dma; - int cs_active = 0; struct omap2_mcspi_cs *cs; struct omap2_mcspi_device_config *cd; int par_override = 0; @@ -1118,11 +1120,6 @@ static int omap2_mcspi_work_one(struct omap2_mcspi *mcspi, mcspi_read_cs_reg(spi, OMAP2_MCSPI_MODULCTRL); } - if (!cs_active) { - omap2_mcspi_force_cs(spi, 1); - cs_active = 1; - } - chconf = mcspi_cached_chconf0(spi); chconf &= ~OMAP2_MCSPI_CHCONF_TRM_MASK; chconf &= ~OMAP2_MCSPI_CHCONF_TURBO; @@ -1169,12 +1166,6 @@ static int omap2_mcspi_work_one(struct omap2_mcspi *mcspi, if (t->delay_usecs) udelay(t->delay_usecs); - /* ignore the "leave it on after last xfer" hint */ - if (t->cs_change) { - omap2_mcspi_force_cs(spi, 0); - cs_active = 0; - } - omap2_mcspi_set_enable(spi, 0); if (mcspi->fifo_depth > 0) @@ -1187,9 +1178,6 @@ out: status = omap2_mcspi_setup_transfer(spi, NULL); } - if (cs_active) - omap2_mcspi_force_cs(spi, 0); - if (cd && cd->cs_per_word) { chconf = mcspi->ctx.modulctrl; chconf |= OMAP2_MCSPI_MODULCTRL_SINGLE; @@ -1334,6 +1322,7 @@ static int omap2_mcspi_probe(struct platform_device *pdev) master->setup = omap2_mcspi_setup; master->auto_runtime_pm = true; master->transfer_one = omap2_mcspi_transfer_one; + master->set_cs = omap2_mcspi_set_cs; master->cleanup = omap2_mcspi_cleanup; master->dev.of_node = node; master->max_speed_hz = OMAP2_MCSPI_MAX_FREQ; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot 2015-05-11 20:16 ` Michael Welling @ 2015-05-12 17:18 ` Nishanth Menon 2015-05-12 17:22 ` Michael Welling 0 siblings, 1 reply; 10+ messages in thread From: Nishanth Menon @ 2015-05-12 17:18 UTC (permalink / raw) To: Michael Welling Cc: Mark Brown, linux-omap, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-next, linux-spi-u79uwXL29TY76Z2rM5mHXA On 05/11/2015 03:16 PM, Michael Welling wrote: [...] > Okay I have another patch that appears to fix the issue on my board. > > Please test the attached patch and see if it fixes the issue on your board. > > If it does, I will send it upstream. Tested on: 20150512 http://paste.ubuntu.org.cn/2600365 Works :). Thanks for rootcausing and providing a fix. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot 2015-05-12 17:18 ` Nishanth Menon @ 2015-05-12 17:22 ` Michael Welling 2015-05-12 17:28 ` Nishanth Menon 0 siblings, 1 reply; 10+ messages in thread From: Michael Welling @ 2015-05-12 17:22 UTC (permalink / raw) To: Nishanth Menon Cc: Mark Brown, linux-omap, linux-arm-kernel, linux-next, linux-spi On Tue, May 12, 2015 at 12:18:04PM -0500, Nishanth Menon wrote: > On 05/11/2015 03:16 PM, Michael Welling wrote: > [...] > > Okay I have another patch that appears to fix the issue on my board. > > > > Please test the attached patch and see if it fixes the issue on your board. > > > > If it does, I will send it upstream. > > Tested on: 20150512 http://paste.ubuntu.org.cn/2600365 > Works :). Thanks for rootcausing and providing a fix. Phew. Okay this patch or a revision of it should land upstream soon. > > -- > Regards, > Nishanth Menon ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot 2015-05-12 17:22 ` Michael Welling @ 2015-05-12 17:28 ` Nishanth Menon 0 siblings, 0 replies; 10+ messages in thread From: Nishanth Menon @ 2015-05-12 17:28 UTC (permalink / raw) To: Michael Welling Cc: Mark Brown, linux-omap, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-next, linux-spi-u79uwXL29TY76Z2rM5mHXA On 05/12/2015 12:22 PM, Michael Welling wrote: > On Tue, May 12, 2015 at 12:18:04PM -0500, Nishanth Menon wrote: >> On 05/11/2015 03:16 PM, Michael Welling wrote: >> [...] >>> Okay I have another patch that appears to fix the issue on my board. >>> >>> Please test the attached patch and see if it fixes the issue on your board. >>> >>> If it does, I will send it upstream. >> >> Tested on: 20150512 http://paste.ubuntu.org.cn/2600365 >> Works :). Thanks for rootcausing and providing a fix. > > Phew. > > Okay this patch or a revision of it should land upstream soon. please feel free to cc linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org -> one of us will try and provide a tested-by to the formal patch -> might be good to add a "Fixes:" tag as well if Mark wishes to see something to the effect. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot 2015-05-11 18:27 ` Nishanth Menon [not found] ` <5550F47C.1030902-l0cyMroinI0@public.gmane.org> @ 2015-05-11 18:54 ` Michael Welling 1 sibling, 0 replies; 10+ messages in thread From: Michael Welling @ 2015-05-11 18:54 UTC (permalink / raw) To: Nishanth Menon Cc: Mark Brown, linux-omap, linux-arm-kernel, linux-next, linux-spi On Mon, May 11, 2015 at 01:27:08PM -0500, Nishanth Menon wrote: > On 05/11/2015 12:07 PM, Michael Welling wrote: > > On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote: > >> Hi, > >> > >> SDP4430 uses a SPI based network chip ks8851. > >> > >> next-20150508: > >> https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt > >> > >> However, next-20150511: > >> https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt > >> > > > > I will look into this but it is going to be difficult to debug with access to the hardware. > > This is what I get for changing a driver that effects so many SoCs. > > > > Let me know if there is any test patch you'd want me to run. The board > is on a remote "board farm" which most of TI folks have access to as > well.. So, if you need anything run, just send out a debug patch OR a > potential fix and we can help try it out and provide logs back for > your debug. > So it appears that I have broken the native chip select support. I have a serial flash at spi0cs0 and if I use the GPIO for chip select it detects: m25p80 spi1.0: n25q128a13 (16384 Kbytes) If I use the native chip select it does not: m25p80 spi1.0: unrecognized JEDEC id bytes: ff, ff, ff This allows me to find the issue and provide a follow up patch. I will provide it when I have it ready to see if it fixes your issue. If I cannot find a fix, we may have to revert these changes. > > -- > Regards, > Nishanth Menon ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-05-12 17:28 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-11 16:50 next-20150511 / omap2-mcspi: regression for sdp4430 boot Nishanth Menon
2015-05-11 17:07 ` Michael Welling
2015-05-11 18:27 ` Nishanth Menon
[not found] ` <5550F47C.1030902-l0cyMroinI0@public.gmane.org>
2015-05-11 18:30 ` Michael Welling
2015-05-11 19:00 ` Nishanth Menon
2015-05-11 20:16 ` Michael Welling
2015-05-12 17:18 ` Nishanth Menon
2015-05-12 17:22 ` Michael Welling
2015-05-12 17:28 ` Nishanth Menon
2015-05-11 18:54 ` Michael Welling
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).