[PATCH v5 0/4] Allow ISA-style drivers on modern systems

[PATCH v5 0/4] Allow ISA-style drivers on modern systems

[William Breathitt Gray]

Changes in v5:
  - Add explicit X86 dependency to CONFIG_STX104 and CONFIG_EBC_C384_WDT
    since these drivers were developed with X86 architectures in mind

Changes in v4:
  - Remove unnecessary explicit "default n" from the X86 ISA_BUS Kconfig
    option since Kconfig options are disabled by default

Changes in v3:
  - Remove redundant X86 dependency from the X86 ISA_BUS Kconfig option

Changes in v2:
  - Adjusted preprocessor compilation conditional in include/linux/isa.h
    to use CONFIG_ISA_BUS_API in order to link the correct ISA bus
    driver function definitions when available
  - Move ISA_BUS_API Kconfig option to arch/Kconfig, thus making it
    available to all architectures instead of just X86
  - X86 ISA_BUS Kconfig option should be disabled by default; ISA
    devices typically do not have a way to be probed, so users should
    be required to explicitly enable ISA bus driver support, lest a
    selected driver be loaded with the misguided expectation of a safe
    hardware probe

Several modern devices, such as PC/104 cards, are expected to run on
modern systems via an ISA bus interface. Since ISA is a legacy interface
for most modern architectures, ISA support should remain disabled in
general. Support for ISA-style drivers should be enabled on a per driver
basis.

To allow ISA-style drivers on modern systems, this patchset introduces
the ISA_BUS_API and ISA_BUS Kconfig options. The ISA bus driver will now
build conditionally on the ISA_BUS_API Kconfig option, which defaults to
the legacy ISA Kconfig option. The ISA_BUS Kconfig option allows the
ISA_BUS_API Kconfig option to be selected on architectures which do not
enable ISA (e.g. X86_64).

The ISA_BUS Kconfig option is currently only implemented for X86
architectures. Other architectures may have their own ISA_BUS Kconfig
option added as required.

An earlier attempt to allow the ISA bus driver to build for X86_64 took
an inappropriate approach resulting in legacy ISA drivers becoming
enabled unconditionally on untested and unsupported architectures.
Commit 51e68d055cba ("x86 isa: add back X86_32 dependency on
CONFIG_ISA"), added to restrict the ISA bus driver to only X86_32,
causes several drivers intended for X86_64 to be restricted to X86_32 as
well.

This patchset replaces the ISA Kconfig option dependency of several
drivers to ISA_BUS_API, so that they may build for X86_64 as intended.
The respective drivers are as follows:
    * ACCES 104-IDIO-16 GPIO driver
    * ACCES 104-IDI-48 GPIO driver
    * ACCES 104-DIO-48E GPIO driver
    * Apex Embedded Systems STX104 DAC driver
    * WinSystems EBC-C384 watchdog timer driver
    * WinSystems WS16C48 GPIO driver

William Breathitt Gray (4):
  isa: Allow ISA-style drivers on modern systems
  gpio: Allow PC/104 devices on X86_64
  iio: stx104: Allow build for X86_64
  watchdog: ebc-c384_wdt: Allow build for X86_64

 arch/Kconfig             | 3 +++
 arch/x86/Kconfig         | 9 +++++++++
 drivers/base/Makefile    | 2 +-
 drivers/gpio/Kconfig     | 8 ++++----
 drivers/iio/dac/Kconfig  | 2 +-
 drivers/watchdog/Kconfig | 2 +-
 include/linux/isa.h      | 2 +-
 7 files changed, 20 insertions(+), 8 deletions(-)

-- 
2.7.3

[PATCH v5 1/4] isa: Allow ISA-style drivers on modern systems

[William Breathitt Gray]

Several modern devices, such as PC/104 cards, are expected to run on
modern systems via an ISA bus interface. Since ISA is a legacy interface
for most modern architectures, ISA support should remain disabled in
general. Support for ISA-style drivers should be enabled on a per driver
basis.

To allow ISA-style drivers on modern systems, this patch introduces the
ISA_BUS_API and ISA_BUS Kconfig options. The ISA bus driver will now
build conditionally on the ISA_BUS_API Kconfig option, which defaults to
the legacy ISA Kconfig option. The ISA_BUS Kconfig option allows the
ISA_BUS_API Kconfig option to be selected on architectures which do not
enable ISA (e.g. X86_64).

The ISA_BUS Kconfig option is currently only implemented for X86
architectures. Other architectures may have their own ISA_BUS Kconfig
options added as required.

Cc: Linus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 arch/Kconfig          | 3 +++
 arch/x86/Kconfig      | 9 +++++++++
 drivers/base/Makefile | 2 +-
 include/linux/isa.h   | 2 +-
 4 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index b16e74e..9d9942f 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -598,6 +598,9 @@ config HAVE_STACK_VALIDATION
 	  Architecture supports the 'objtool check' host tool command, which
 	  performs compile-time stack metadata validation.
 
+config ISA_BUS_API
+	def_bool ISA
+
 #
 # ABI hall of shame
 #
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 0a7b885..d9a94da 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2439,6 +2439,15 @@ config PCI_CNB20LE_QUIRK
 
 source "drivers/pci/Kconfig"
 
+config ISA_BUS
+	bool "ISA-style bus support on modern systems" if EXPERT
+	select ISA_BUS_API
+	help
+	  Enables ISA-style drivers on modern systems. This is necessary to
+	  support PC/104 devices on X86_64 platforms.
+
+	  If unsure, say N.
+
 # x86_64 have no ISA slots, but can have ISA-style DMA.
 config ISA_DMA_API
 	bool "ISA-style DMA support" if (X86_64 && EXPERT)
diff --git a/drivers/base/Makefile b/drivers/base/Makefile
index 6b2a84e..2609ba2 100644
--- a/drivers/base/Makefile
+++ b/drivers/base/Makefile
@@ -10,7 +10,7 @@ obj-$(CONFIG_DMA_CMA) += dma-contiguous.o
 obj-y			+= power/
 obj-$(CONFIG_HAS_DMA)	+= dma-mapping.o
 obj-$(CONFIG_HAVE_GENERIC_DMA_COHERENT) += dma-coherent.o
-obj-$(CONFIG_ISA)	+= isa.o
+obj-$(CONFIG_ISA_BUS_API)	+= isa.o
 obj-$(CONFIG_FW_LOADER)	+= firmware_class.o
 obj-$(CONFIG_NUMA)	+= node.o
 obj-$(CONFIG_MEMORY_HOTPLUG_SPARSE) += memory.o
diff --git a/include/linux/isa.h b/include/linux/isa.h
index 5ab8528..384ab9b 100644
--- a/include/linux/isa.h
+++ b/include/linux/isa.h
@@ -22,7 +22,7 @@ struct isa_driver {
 
 #define to_isa_driver(x) container_of((x), struct isa_driver, driver)
 
-#ifdef CONFIG_ISA
+#ifdef CONFIG_ISA_BUS_API
 int isa_register_driver(struct isa_driver *, unsigned int);
 void isa_unregister_driver(struct isa_driver *);
 #else
-- 
2.7.3

Re: [PATCH v5 1/4] isa: Allow ISA-style drivers on modern systems

[Linus Torvalds]

On Fri, May 27, 2016 at 3:08 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> Several modern devices, such as PC/104 cards, are expected to run on
> modern systems via an ISA bus interface. Since ISA is a legacy interface
> for most modern architectures, ISA support should remain disabled in
> general. Support for ISA-style drivers should be enabled on a per driver
> basis.
>
> To allow ISA-style drivers on modern systems, this patch introduces the
> ISA_BUS_API and ISA_BUS Kconfig options. The ISA bus driver will now
> build conditionally on the ISA_BUS_API Kconfig option, which defaults to
> the legacy ISA Kconfig option. The ISA_BUS Kconfig option allows the
> ISA_BUS_API Kconfig option to be selected on architectures which do not
> enable ISA (e.g. X86_64).
>
> The ISA_BUS Kconfig option is currently only implemented for X86
> architectures. Other architectures may have their own ISA_BUS Kconfig
> options added as required.
>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>

Acked-by: Linus Torvalds <torvalds@linux-foundation.org>

This version seems fine and safe. I didn't see the other patches in
the series (not cc'd to me), but at least this one would seem to do
the right thing and expose part of the ISA code without causing other
architectures to possibly lose it.

              Linus

[PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[William Breathitt Gray]

With the introduction of the ISA_BUS_API Kconfig option, ISA-style
drivers may be built for X86_64 architectures. This patch changes the
ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus
allowing them to build for X86_64 as they are expected to.

Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/gpio/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 48da857..dc6da77 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -530,7 +530,7 @@ menu "Port-mapped I/O GPIO drivers"
 
 config GPIO_104_DIO_48E
 	tristate "ACCES 104-DIO-48E GPIO support"
-	depends on ISA
+	depends on ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the ACCES 104-DIO-48E series (104-DIO-48E,
@@ -540,7 +540,7 @@ config GPIO_104_DIO_48E
 
 config GPIO_104_IDIO_16
 	tristate "ACCES 104-IDIO-16 GPIO support"
-	depends on ISA
+	depends on ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the ACCES 104-IDIO-16 family (104-IDIO-16,
@@ -551,7 +551,7 @@ config GPIO_104_IDIO_16
 
 config GPIO_104_IDI_48
 	tristate "ACCES 104-IDI-48 GPIO support"
-	depends on ISA
+	depends on ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the ACCES 104-IDI-48 family (104-IDI-48A,
@@ -627,7 +627,7 @@ config GPIO_TS5500
 
 config GPIO_WS16C48
 	tristate "WinSystems WS16C48 GPIO support"
-	depends on ISA
+	depends on ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the WinSystems WS16C48. The base port
-- 
2.7.3

Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[Linus Walleij]

On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray
<vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> drivers may be built for X86_64 architectures. This patch changes the
> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus
> allowing them to build for X86_64 as they are expected to.
>
> Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Reviewed-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
> Signed-off-by: William Breathitt Gray <vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Or should I apply this directly to the GPIO tree?

Yours,
Linus Walleij

Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[William Breathitt Gray]

On Tue, May 31, 2016 at 10:41:49AM +0200, Linus Walleij wrote:
>On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray
><vilhelm.gray@gmail.com> wrote:
>
>> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
>> drivers may be built for X86_64 architectures. This patch changes the
>> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus
>> allowing them to build for X86_64 as they are expected to.
>>
>> Cc: Alexandre Courbot <gnurou@gmail.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>
>Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
>Or should I apply this directly to the GPIO tree?
>
>Yours,
>Linus Walleij

Greg K-H,

Would you be able to pick up this entire patchset via driver-core; I
figure that tree is the most appropriate to receive any core ISA bus
driver changes (unless you see a more fitting path to take).

If possible, I'd like this patchset to find its way into one of the
coming release candidates in order to resolve the regression mentioned
in the cover letter: as of 4.7-rc1, the drivers which switched to
utilize the ISA bus driver are now restricted to X86_32 despite being
allowed in X86_64 in the 4.6 release.

Thanks,

William Breathitt Gray

Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[Greg KH]

On Tue, May 31, 2016 at 07:23:06AM -0400, William Breathitt Gray wrote:
> On Tue, May 31, 2016 at 10:41:49AM +0200, Linus Walleij wrote:
> >On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray
> ><vilhelm.gray@gmail.com> wrote:
> >
> >> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> >> drivers may be built for X86_64 architectures. This patch changes the
> >> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus
> >> allowing them to build for X86_64 as they are expected to.
> >>
> >> Cc: Alexandre Courbot <gnurou@gmail.com>
> >> Cc: Linus Walleij <linus.walleij@linaro.org>
> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> >
> >Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >
> >Or should I apply this directly to the GPIO tree?
> >
> >Yours,
> >Linus Walleij
> 
> Greg K-H,
> 
> Would you be able to pick up this entire patchset via driver-core; I
> figure that tree is the most appropriate to receive any core ISA bus
> driver changes (unless you see a more fitting path to take).
> 
> If possible, I'd like this patchset to find its way into one of the
> coming release candidates in order to resolve the regression mentioned
> in the cover letter: as of 4.7-rc1, the drivers which switched to
> utilize the ISA bus driver are now restricted to X86_32 despite being
> allowed in X86_64 in the 4.6 release.

Yes, I can take this through the driver core tree as that's where the
original series came from...

thanks,

greg k-h

Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[Thorsten Leemhuis]

On 31.05.2016 17:25, Greg KH wrote:
> On Tue, May 31, 2016 at 07:23:06AM -0400, William Breathitt Gray wrote:
>> On Tue, May 31, 2016 at 10:41:49AM +0200, Linus Walleij wrote:
>>> On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray
>>> <vilhelm.gray@gmail.com> wrote:
>>>> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
>>>> drivers may be built for X86_64 architectures. This patch changes the
>>>> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus
>>>> allowing them to build for X86_64 as they are expected to.
> […]
>> Greg K-H,
>>
>> Would you be able to pick up this entire patchset via driver-core; I
>> figure that tree is the most appropriate to receive any core ISA bus
>> driver changes (unless you see a more fitting path to take).
> […]
> Yes, I can take this through the driver core tree as that's where the
> original series came from...

Was this series merged or did it fell through the cracks? I currently
assume the latter, as I can't see it in neither mainline nor linux-next
(but maybe I'm missing something). Just wondering, because I have this
issue on my regression list for 4.7.

For the whole context see:
http://thread.gmane.org/gmane.linux.kernel.gpio/17016/

Sincerely, your regression tracker for Linux 4.7 (http://bit.ly/28JRmJo)
 Thorsten

Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[Greg KH]

On Fri, Jun 17, 2016 at 12:47:14PM +0200, Thorsten Leemhuis wrote:
> On 31.05.2016 17:25, Greg KH wrote:
> > On Tue, May 31, 2016 at 07:23:06AM -0400, William Breathitt Gray wrote:
> >> On Tue, May 31, 2016 at 10:41:49AM +0200, Linus Walleij wrote:
> >>> On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray
> >>> <vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >>>> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> >>>> drivers may be built for X86_64 architectures. This patch changes the
> >>>> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus
> >>>> allowing them to build for X86_64 as they are expected to.
> > […]
> >> Greg K-H,
> >>
> >> Would you be able to pick up this entire patchset via driver-core; I
> >> figure that tree is the most appropriate to receive any core ISA bus
> >> driver changes (unless you see a more fitting path to take).
> > […]
> > Yes, I can take this through the driver core tree as that's where the
> > original series came from...
> 
> Was this series merged or did it fell through the cracks? I currently
> assume the latter, as I can't see it in neither mainline nor linux-next
> (but maybe I'm missing something). Just wondering, because I have this
> issue on my regression list for 4.7.
> 
> For the whole context see:
> http://thread.gmane.org/gmane.linux.kernel.gpio/17016/
> 
> Sincerely, your regression tracker for Linux 4.7 (http://bit.ly/28JRmJo)

I don't think this is a regression, I was going to queue these up for
4.8-rc1.  As it is now, 4.7-rc is working just fine in this regards,
right?

Or am I missing something?

thanks,

greg k-h

Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[William Breathitt Gray]

On Fri, Jun 17, 2016 at 07:36:07PM -0700, Greg KH wrote:
>On Fri, Jun 17, 2016 at 12:47:14PM +0200, Thorsten Leemhuis wrote:
>> On 31.05.2016 17:25, Greg KH wrote:
>> > On Tue, May 31, 2016 at 07:23:06AM -0400, William Breathitt Gray wrote:
>> >> On Tue, May 31, 2016 at 10:41:49AM +0200, Linus Walleij wrote:
>> >>> On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray
>> >>> <vilhelm.gray@gmail.com> wrote:
>> >>>> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
>> >>>> drivers may be built for X86_64 architectures. This patch changes the
>> >>>> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus
>> >>>> allowing them to build for X86_64 as they are expected to.
>> > […]
>> >> Greg K-H,
>> >>
>> >> Would you be able to pick up this entire patchset via driver-core; I
>> >> figure that tree is the most appropriate to receive any core ISA bus
>> >> driver changes (unless you see a more fitting path to take).
>> > […]
>> > Yes, I can take this through the driver core tree as that's where the
>> > original series came from...
>> 
>> Was this series merged or did it fell through the cracks? I currently
>> assume the latter, as I can't see it in neither mainline nor linux-next
>> (but maybe I'm missing something). Just wondering, because I have this
>> issue on my regression list for 4.7.
>> 
>> For the whole context see:
>> http://thread.gmane.org/gmane.linux.kernel.gpio/17016/
>> 
>> Sincerely, your regression tracker for Linux 4.7 (http://bit.ly/28JRmJo)
>
>I don't think this is a regression, I was going to queue these up for
>4.8-rc1.  As it is now, 4.7-rc is working just fine in this regards,
>right?
>
>Or am I missing something?

The PC/104 drivers were changed to utilize the ISA bus driver as part of
the original patchset which attempted to decouple the X86_32 dependency
from the ISA Kconfig option; these drivers were updated with the
intention of building on X86_64 in addition to X86_32.

However, the respective patches were merged without the decoupling
changes (since decoupling was the wrong approach), resulting in an
unintentional regression: the PC/104 drivers are now restricted to
X86_32 due to the ISA Kconfig option dependency, while they were capable
of building for X86_64 in previous kernel versions.

This patchset should fix this regression by introducing the ISA_BUS_API
Kconfig option, and the respective Kconfig dependency changes for the
drivers, in order to allow them to build for both X86_64 and X86_32 as
originally capable.

William Breathitt Gray

Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[Greg KH]

On Fri, Jun 17, 2016 at 10:49:59PM -0400, William Breathitt Gray wrote:
> On Fri, Jun 17, 2016 at 07:36:07PM -0700, Greg KH wrote:
> >On Fri, Jun 17, 2016 at 12:47:14PM +0200, Thorsten Leemhuis wrote:
> >> On 31.05.2016 17:25, Greg KH wrote:
> >> > On Tue, May 31, 2016 at 07:23:06AM -0400, William Breathitt Gray wrote:
> >> >> On Tue, May 31, 2016 at 10:41:49AM +0200, Linus Walleij wrote:
> >> >>> On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray
> >> >>> <vilhelm.gray@gmail.com> wrote:
> >> >>>> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> >> >>>> drivers may be built for X86_64 architectures. This patch changes the
> >> >>>> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus
> >> >>>> allowing them to build for X86_64 as they are expected to.
> >> > […]
> >> >> Greg K-H,
> >> >>
> >> >> Would you be able to pick up this entire patchset via driver-core; I
> >> >> figure that tree is the most appropriate to receive any core ISA bus
> >> >> driver changes (unless you see a more fitting path to take).
> >> > […]
> >> > Yes, I can take this through the driver core tree as that's where the
> >> > original series came from...
> >> 
> >> Was this series merged or did it fell through the cracks? I currently
> >> assume the latter, as I can't see it in neither mainline nor linux-next
> >> (but maybe I'm missing something). Just wondering, because I have this
> >> issue on my regression list for 4.7.
> >> 
> >> For the whole context see:
> >> http://thread.gmane.org/gmane.linux.kernel.gpio/17016/
> >> 
> >> Sincerely, your regression tracker for Linux 4.7 (http://bit.ly/28JRmJo)
> >
> >I don't think this is a regression, I was going to queue these up for
> >4.8-rc1.  As it is now, 4.7-rc is working just fine in this regards,
> >right?
> >
> >Or am I missing something?
> 
> The PC/104 drivers were changed to utilize the ISA bus driver as part of
> the original patchset which attempted to decouple the X86_32 dependency
> from the ISA Kconfig option; these drivers were updated with the
> intention of building on X86_64 in addition to X86_32.
> 
> However, the respective patches were merged without the decoupling
> changes (since decoupling was the wrong approach), resulting in an
> unintentional regression: the PC/104 drivers are now restricted to
> X86_32 due to the ISA Kconfig option dependency, while they were capable
> of building for X86_64 in previous kernel versions.
> 
> This patchset should fix this regression by introducing the ISA_BUS_API
> Kconfig option, and the respective Kconfig dependency changes for the
> drivers, in order to allow them to build for both X86_64 and X86_32 as
> originally capable.

Ah, ok, that makes more sense, thanks.  I'll go queue these up now.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[William Breathitt Gray]

On Fri, Jun 17, 2016 at 08:18:10PM -0700, Greg KH wrote:
>On Fri, Jun 17, 2016 at 10:49:59PM -0400, William Breathitt Gray wrote:
>> The PC/104 drivers were changed to utilize the ISA bus driver as part of
>> the original patchset which attempted to decouple the X86_32 dependency
>> from the ISA Kconfig option; these drivers were updated with the
>> intention of building on X86_64 in addition to X86_32.
>> 
>> However, the respective patches were merged without the decoupling
>> changes (since decoupling was the wrong approach), resulting in an
>> unintentional regression: the PC/104 drivers are now restricted to
>> X86_32 due to the ISA Kconfig option dependency, while they were capable
>> of building for X86_64 in previous kernel versions.
>> 
>> This patchset should fix this regression by introducing the ISA_BUS_API
>> Kconfig option, and the respective Kconfig dependency changes for the
>> drivers, in order to allow them to build for both X86_64 and X86_32 as
>> originally capable.
>
>Ah, ok, that makes more sense, thanks.  I'll go queue these up now.
>
>greg k-h

Greg K-H,

Please also consider picking up the following two patches which fix bugs
discovered during the ISA bus driver utilization conversion:

  1. https://patchwork.kernel.org/patch/9046831/
  2. https://patchwork.kernel.org/patch/9074641/

The second patch in particular fixes a kernel BUG which prevents some
drivers that call isa_register_driver from being built-in. This was
first reported by Sasha Levin (https://lkml.org/lkml/2016/5/11/719), and
the patch was later tested by Ye Xiaolong
(https://lkml.org/lkml/2016/5/31/164).

Thanks,

William Breathitt Gray

Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64

[Greg KH]

On Fri, Jun 17, 2016 at 11:39:04PM -0400, William Breathitt Gray wrote:
> On Fri, Jun 17, 2016 at 08:18:10PM -0700, Greg KH wrote:
> >On Fri, Jun 17, 2016 at 10:49:59PM -0400, William Breathitt Gray wrote:
> >> The PC/104 drivers were changed to utilize the ISA bus driver as part of
> >> the original patchset which attempted to decouple the X86_32 dependency
> >> from the ISA Kconfig option; these drivers were updated with the
> >> intention of building on X86_64 in addition to X86_32.
> >> 
> >> However, the respective patches were merged without the decoupling
> >> changes (since decoupling was the wrong approach), resulting in an
> >> unintentional regression: the PC/104 drivers are now restricted to
> >> X86_32 due to the ISA Kconfig option dependency, while they were capable
> >> of building for X86_64 in previous kernel versions.
> >> 
> >> This patchset should fix this regression by introducing the ISA_BUS_API
> >> Kconfig option, and the respective Kconfig dependency changes for the
> >> drivers, in order to allow them to build for both X86_64 and X86_32 as
> >> originally capable.
> >
> >Ah, ok, that makes more sense, thanks.  I'll go queue these up now.
> >
> >greg k-h
> 
> Greg K-H,
> 
> Please also consider picking up the following two patches which fix bugs
> discovered during the ISA bus driver utilization conversion:
> 
>   1. https://patchwork.kernel.org/patch/9046831/
>   2. https://patchwork.kernel.org/patch/9074641/
> 
> The second patch in particular fixes a kernel BUG which prevents some
> drivers that call isa_register_driver from being built-in. This was
> first reported by Sasha Levin (https://lkml.org/lkml/2016/5/11/719), and
> the patch was later tested by Ye Xiaolong
> (https://lkml.org/lkml/2016/5/31/164).

Now queued up, thanks for the prompt, they were still setting in my
queue.

greg k-h

[PATCH v5 3/4] iio: stx104: Allow build for X86_64

[William Breathitt Gray]

With the introduction of the ISA_BUS_API Kconfig option, ISA-style
drivers may be built for X86_64 architectures. This patch changes the
ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC
driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is
expected to.

Cc: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>
Cc: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
Cc: Peter Meerwald-Stadler <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>
Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Reviewed-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Signed-off-by: William Breathitt Gray <vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/iio/dac/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index e63b957..f7c71da 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -247,7 +247,7 @@ config MCP4922
 
 config STX104
 	tristate "Apex Embedded Systems STX104 DAC driver"
-	depends on X86 && ISA
+	depends on X86 && ISA_BUS_API
 	help
 	  Say yes here to build support for the 2-channel DAC on the Apex
 	  Embedded Systems STX104 integrated analog PC/104 card. The base port
-- 
2.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 3/4] iio: stx104: Allow build for X86_64

[Jonathan Cameron]

On 27/05/16 23:09, William Breathitt Gray wrote:
> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> drivers may be built for X86_64 architectures. This patch changes the
> ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC
> driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is
> expected to.
> 
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
I've only been following this discussion very vaguely, but the consensus seems
to be good, so feel free to apply this one with my Ack for IIO.
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>  drivers/iio/dac/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index e63b957..f7c71da 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -247,7 +247,7 @@ config MCP4922
>  
>  config STX104
>  	tristate "Apex Embedded Systems STX104 DAC driver"
> -	depends on X86 && ISA
> +	depends on X86 && ISA_BUS_API
>  	help
>  	  Say yes here to build support for the 2-channel DAC on the Apex
>  	  Embedded Systems STX104 integrated analog PC/104 card. The base port
> 

[PATCH v5 4/4] watchdog: ebc-c384_wdt: Allow build for X86_64

[William Breathitt Gray]

With the introduction of the ISA_BUS_API Kconfig option, ISA-style
drivers may be built for X86_64 architectures. This patch changes the
ISA Kconfig option dependency of the WinSystems EBC-C384 watchdog timer
driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is
expected to.

Cc: Wim Van Sebroeck <wim@iguana.be>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/watchdog/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index b54f26c..b4b3e25 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -746,7 +746,7 @@ config ALIM7101_WDT
 
 config EBC_C384_WDT
 	tristate "WinSystems EBC-C384 Watchdog Timer"
-	depends on X86 && ISA
+	depends on X86 && ISA_BUS_API
 	select WATCHDOG_CORE
 	help
 	  Enables watchdog timer support for the watchdog timer on the
-- 
2.7.3