Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warnings after merge of the scsi-mkp tree
@ 2018-02-13  3:00 Stephen Rothwell
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2018-02-13  3:00 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Hannes Reinecke

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/scsi/myrb.c: In function 'myrb_get_ldev_info':
drivers/scsi/myrb.c:428:10: warning: 'ldev_num' may be used uninitialized in this function [-Wmaybe-uninitialized]
   sdev = scsi_device_lookup(shost, myrb_logical_channel(shost),
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        ldev_num, 0);
        ~~~~~~~~~~~~
drivers/scsi/myrs.c: In function 'myrs_handle_scsi':
drivers/scsi/myrs.c:2175:6: warning: 'status' may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (status == DAC960_V2_AbnormalCompletion &&
      ^
drivers/scsi/myrs.c: In function 'myrs_log_event':
drivers/scsi/myrs.c:988:21: warning: 'cmd_specific' may be used uninitialized in this function [-Wmaybe-uninitialized]
         cmd_specific[0], cmd_specific[1],
                     ^
drivers/scsi/myrs.c:986:19: warning: 'sense_info' may be used uninitialized in this function [-Wmaybe-uninitialized]
         sense_info[0], sense_info[1],
                   ^

Introduced by commits

  dd47c1072226 ("scsi: myrb: Add Mylex RAID controller (block interface)")
  8a8606895947 ("scsi: myrs: Add Mylex RAID controller (SCSI interface)")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build warnings after merge of the scsi-mkp tree
  2021-03-03  6:03 Stephen Rothwell
@ 2021-04-21  6:03 ` Stephen Rothwell
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2021-04-21  6:03 UTC (permalink / raw)
  To: James Bottomley
  Cc: Martin K. Petersen, Ming Lei, Linux Kernel Mailing List,
	Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

Hi all,

On Wed, 3 Mar 2021 17:03:49 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> include/linux/blk-mq.h:395: warning: Function parameter or member 'set_rq_budget_token' not described in 'blk_mq_ops'
> include/linux/blk-mq.h:395: warning: Function parameter or member 'get_rq_budget_token' not described in 'blk_mq_ops'
> 
> Introduced by commit
> 
>   9dda23635dbe ("scsi: blk-mq: Add callbacks for storing & retrieving budget token")

This is now commit

  d022d18c045f ("scsi: blk-mq: Add callbacks for storing & retrieving budget token")

in the scsi tree and I am still seeing these warnings (as of next-20210420).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: build warnings after merge of the scsi-mkp tree
@ 2021-03-03  6:03 Stephen Rothwell
  2021-04-21  6:03 ` Stephen Rothwell
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2021-03-03  6:03 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Ming Lei, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (htmldocs)
produced these warnings:

include/linux/blk-mq.h:395: warning: Function parameter or member 'set_rq_budget_token' not described in 'blk_mq_ops'
include/linux/blk-mq.h:395: warning: Function parameter or member 'get_rq_budget_token' not described in 'blk_mq_ops'

Introduced by commit

  9dda23635dbe ("scsi: blk-mq: Add callbacks for storing & retrieving budget token")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build warnings after merge of the scsi-mkp tree
  2017-06-29  5:07 ` Stephen Rothwell
@ 2017-06-29 18:35   ` Madhani, Himanshu
  0 siblings, 0 replies; 6+ messages in thread
From: Madhani, Himanshu @ 2017-06-29 18:35 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, Martin K. Petersen, Linux-Next Mailing List,
	Linux Kernel Mailing List, Trapp, Darren, Grigsby, Duane,
	Anil Gurumurthy, Malavali, Giridhar, Hannes Reinecke

Hi Stephen, James,

> On Jun 28, 2017, at 10:07 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi James,
> 
> This has now migrated to the scsi tree.
> 
> On Wed, 28 Jun 2017 15:55:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> 
>> After merging the scsi-mkp tree, today's linux-next build
>> (powerpc_ppc64_defconfig) produced these warnings:
>> 
>> In file included from include/linux/byteorder/big_endian.h:4:0,
>>                 from arch/powerpc/include/uapi/asm/byteorder.h:13,
>>                 from include/asm-generic/bitops/le.h:5,
>>                 from arch/powerpc/include/asm/bitops.h:246,
>>                 from include/linux/bitops.h:36,
>>                 from include/linux/kernel.h:10,
>>                 from include/asm-generic/bug.h:15,
>>                 from arch/powerpc/include/asm/bug.h:127,
>>                 from include/linux/bug.h:4,
>>                 from arch/powerpc/include/asm/mmu.h:125,
>>                 from arch/powerpc/include/asm/lppaca.h:36,
>>                 from arch/powerpc/include/asm/paca.h:21,
>>                 from arch/powerpc/include/asm/current.h:16,
>>                 from include/linux/sched.h:11,
>>                 from include/linux/blkdev.h:4,
>>                 from include/linux/blk-mq.h:4,
>>                 from drivers/scsi/qla2xxx/qla_nvme.h:10,
>>                 from drivers/scsi/qla2xxx/qla_nvme.c:7:
>> drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2x00_start_nvme_mq':
>> include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>> #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
>>                          ^
>> include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
>> #define cpu_to_le32 __cpu_to_le32
>>                     ^
>> drivers/scsi/qla2xxx/qla_nvme.c:444:27: note: in expansion of macro 'cpu_to_le32'
>>    cont_pkt->entry_type = cpu_to_le32(CONTINUE_A64_TYPE);
>>                           ^
>> drivers/scsi/qla2xxx/qla_nvme.c: At top level:
>> drivers/scsi/qla2xxx/qla_nvme.c:667:13: warning: 'qla_nvme_unregister_remote_port' defined but not used [-Wunused-function]
>> static void qla_nvme_unregister_remote_port(struct work_struct *work)
>>             ^
>> drivers/scsi/qla2xxx/qla_nvme.c:604:12: warning: 'qla_nvme_wait_on_rport_del' defined but not used [-Wunused-function]
>> static int qla_nvme_wait_on_rport_del(fc_port_t *fcport)
>>            ^
>> drivers/scsi/qla2xxx/qla_nvme.c:634:13: warning: 'qla_nvme_abort_all' defined but not used [-Wunused-function]
>> static void qla_nvme_abort_all(fc_port_t *fcport)
>>             ^
>> 
>> Introduced by commit
>> 
>>  e84067d74301 ("scsi: qla2xxx: Add FC-NVMe F/W initialization and transport registration")
> 
> -- 
> Cheers,
> Stephen Rothwell


Would it be okay if we send patch to address this warnings in couple days? 

Thanks,
- Himanshu

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build warnings after merge of the scsi-mkp tree
  2017-06-28  5:55 Stephen Rothwell
@ 2017-06-29  5:07 ` Stephen Rothwell
  2017-06-29 18:35   ` Madhani, Himanshu
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2017-06-29  5:07 UTC (permalink / raw)
  To: James Bottomley
  Cc: Martin K. Petersen, Linux-Next Mailing List,
	Linux Kernel Mailing List, Darren Trapp, Duane Grigsby,
	Anil Gurumurthy, Giridhar Malavali, Himanshu Madhani,
	Hannes Reinecke

Hi James,

This has now migrated to the scsi tree.

On Wed, 28 Jun 2017 15:55:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build
> (powerpc_ppc64_defconfig) produced these warnings:
> 
> In file included from include/linux/byteorder/big_endian.h:4:0,
>                  from arch/powerpc/include/uapi/asm/byteorder.h:13,
>                  from include/asm-generic/bitops/le.h:5,
>                  from arch/powerpc/include/asm/bitops.h:246,
>                  from include/linux/bitops.h:36,
>                  from include/linux/kernel.h:10,
>                  from include/asm-generic/bug.h:15,
>                  from arch/powerpc/include/asm/bug.h:127,
>                  from include/linux/bug.h:4,
>                  from arch/powerpc/include/asm/mmu.h:125,
>                  from arch/powerpc/include/asm/lppaca.h:36,
>                  from arch/powerpc/include/asm/paca.h:21,
>                  from arch/powerpc/include/asm/current.h:16,
>                  from include/linux/sched.h:11,
>                  from include/linux/blkdev.h:4,
>                  from include/linux/blk-mq.h:4,
>                  from drivers/scsi/qla2xxx/qla_nvme.h:10,
>                  from drivers/scsi/qla2xxx/qla_nvme.c:7:
> drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2x00_start_nvme_mq':
> include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>  #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
>                           ^
> include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
>  #define cpu_to_le32 __cpu_to_le32
>                      ^
> drivers/scsi/qla2xxx/qla_nvme.c:444:27: note: in expansion of macro 'cpu_to_le32'
>     cont_pkt->entry_type = cpu_to_le32(CONTINUE_A64_TYPE);
>                            ^
> drivers/scsi/qla2xxx/qla_nvme.c: At top level:
> drivers/scsi/qla2xxx/qla_nvme.c:667:13: warning: 'qla_nvme_unregister_remote_port' defined but not used [-Wunused-function]
>  static void qla_nvme_unregister_remote_port(struct work_struct *work)
>              ^
> drivers/scsi/qla2xxx/qla_nvme.c:604:12: warning: 'qla_nvme_wait_on_rport_del' defined but not used [-Wunused-function]
>  static int qla_nvme_wait_on_rport_del(fc_port_t *fcport)
>             ^
> drivers/scsi/qla2xxx/qla_nvme.c:634:13: warning: 'qla_nvme_abort_all' defined but not used [-Wunused-function]
>  static void qla_nvme_abort_all(fc_port_t *fcport)
>              ^
> 
> Introduced by commit
> 
>   e84067d74301 ("scsi: qla2xxx: Add FC-NVMe F/W initialization and transport registration")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: build warnings after merge of the scsi-mkp tree
@ 2017-06-28  5:55 Stephen Rothwell
  2017-06-29  5:07 ` Stephen Rothwell
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2017-06-28  5:55 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Darren Trapp,
	Duane Grigsby, Anil Gurumurthy, Giridhar Malavali,
	Himanshu Madhani, Hannes Reinecke

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build
(powerpc_ppc64_defconfig) produced these warnings:

In file included from include/linux/byteorder/big_endian.h:4:0,
                 from arch/powerpc/include/uapi/asm/byteorder.h:13,
                 from include/asm-generic/bitops/le.h:5,
                 from arch/powerpc/include/asm/bitops.h:246,
                 from include/linux/bitops.h:36,
                 from include/linux/kernel.h:10,
                 from include/asm-generic/bug.h:15,
                 from arch/powerpc/include/asm/bug.h:127,
                 from include/linux/bug.h:4,
                 from arch/powerpc/include/asm/mmu.h:125,
                 from arch/powerpc/include/asm/lppaca.h:36,
                 from arch/powerpc/include/asm/paca.h:21,
                 from arch/powerpc/include/asm/current.h:16,
                 from include/linux/sched.h:11,
                 from include/linux/blkdev.h:4,
                 from include/linux/blk-mq.h:4,
                 from drivers/scsi/qla2xxx/qla_nvme.h:10,
                 from drivers/scsi/qla2xxx/qla_nvme.c:7:
drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2x00_start_nvme_mq':
include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
                          ^
include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
 #define cpu_to_le32 __cpu_to_le32
                     ^
drivers/scsi/qla2xxx/qla_nvme.c:444:27: note: in expansion of macro 'cpu_to_le32'
    cont_pkt->entry_type = cpu_to_le32(CONTINUE_A64_TYPE);
                           ^
drivers/scsi/qla2xxx/qla_nvme.c: At top level:
drivers/scsi/qla2xxx/qla_nvme.c:667:13: warning: 'qla_nvme_unregister_remote_port' defined but not used [-Wunused-function]
 static void qla_nvme_unregister_remote_port(struct work_struct *work)
             ^
drivers/scsi/qla2xxx/qla_nvme.c:604:12: warning: 'qla_nvme_wait_on_rport_del' defined but not used [-Wunused-function]
 static int qla_nvme_wait_on_rport_del(fc_port_t *fcport)
            ^
drivers/scsi/qla2xxx/qla_nvme.c:634:13: warning: 'qla_nvme_abort_all' defined but not used [-Wunused-function]
 static void qla_nvme_abort_all(fc_port_t *fcport)
             ^

Introduced by commit

  e84067d74301 ("scsi: qla2xxx: Add FC-NVMe F/W initialization and transport registration")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-13  3:00 linux-next: build warnings after merge of the scsi-mkp tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2021-03-03  6:03 Stephen Rothwell
2021-04-21  6:03 ` Stephen Rothwell
2017-06-28  5:55 Stephen Rothwell
2017-06-29  5:07 ` Stephen Rothwell
2017-06-29 18:35   ` Madhani, Himanshu

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git