linux-next: Signed-off-by missing for commit in the mediatek tree

linux-next: Signed-off-by missing for commit in the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

Hi Matthias,

Commit

  f039c4193c93 ("iregmap: include <linux/ktime.h> from include/linux/regmap.h")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Matthias Brugger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Stephen,

On 05/13/2018 11:57 PM, Stephen Rothwell wrote:
> Hi Matthias,
> 
> Commit
> 
> f039c4193c93 ("iregmap: include <linux/ktime.h> from
> include/linux/regmap.h")
> 
> is missing a Signed-off-by from its committer.
> 

My tree was broken and the merge commit disappeared which pulled this commit
into my tree. Should be fixed by now.

Regards,
Matthias
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEiUuSfQSYnG8EMsBltDliWyzx00MFAlr5aU0ACgkQtDliWyzx
00O68Q//eXk6z6PiRXG+30Pk5z5Wl3vmEvEokwivO1I1kCErktyAcvjMNYA5CJS+
Df7FWAg3p17G7e6p7w5NOteOxBI4leCsebLnRMKOja2m6IrulxHb98koAjcx14sx
twKsa2YEMI7GjhwE93ozkoqkeGeQ0i/IxyFRqn0brcpmUv/49AY8Qw4VTi/Q5rxm
ma6YFWygcQ7x603eWrkxJKG5pmExmUTwNU7B+9Ycqp/yMaikUYW9RedToDxjILAJ
OGQ2uexySNyUJaX2ECpHeM7FnSkOBKzqAjzCD8bDQTL82hiUla5mDFRsOhtzg9be
pe/CdChbeLxZ0v8fv1n2WEO4Bb1E6OXp7YmL8hH6nbmWVxQf448QX0POV5IrJX+V
46/iMzwUtjTasAj50RoI8cb3mhj0fcJgmB/Ivk6OZQfy1UoZ0VrPjIiNlymfgTGM
aP28Dx8RUxysZCvj0Uy/CX+kxMxJU77OgOMDxotf8iTAVnbC2dSqiHSkqZCj7ncK
1cVQkfUHvqEgtCdsEyHN+k7fcu2vmYwvISE5IpoKZyHPU1CNc5+cFdEbxlCvUVVJ
K9PNYz8VFJsYJyYcVG+1C4EUJHLRrnhTK6cdp5GaKlSHagV8UKaefuUvXU8GRBZm
BO+xTm6qRX5ZnQI57MPaq/xEvhVevMRG4xp0wZ5Bf86uIvlP97w=
=gxCq
-----END PGP SIGNATURE-----

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Matthias Brugger]

On 26/04/2022 10:52, Krzysztof Kozlowski wrote:
> On 26/04/2022 10:48, Matthias Brugger wrote:
>> Hi Stephen,
>>
>> On 26/04/2022 00:07, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Commits
>>>
>>>     775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
>>>     c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
>>>     c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
>>>     75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")
>>>
>>> are missing a Signed-off-by from their committer.
>>>
>>
>> These patches are taken by Krysztof and merge into my tree via a tag [1] to
>> avoid any conflicts. Please let me know if there is anything I need to do to fix
>> this problem.
> 
> Hi Matthias,
> 
> Before you merged my branch, which was fine, but later you rebased all
> this thus making yourself committer. Commits pulled from other trees
> should in general not be rebased, because it creates duplicates - there
> are ones in my tree, and separate in yours.
> 
> Additionally, such rebase changes the author, so you need your SoB.
> 

Ok thanks for the explanation.

> Since you already rebased it, I propose you add your own SoB to Mediatek
> patches and drop the one hisilicon (75a3c81bc634). I will do the reverse
> - drop Mediatek and keep hisilicon.
> 

Ok, I think this is the easiest solution. Sorry for the inconvenience I created.

Regards,
Matthias

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Krzysztof Kozlowski]

On 26/04/2022 10:52, Krzysztof Kozlowski wrote:
> On 26/04/2022 10:48, Matthias Brugger wrote:
>> Hi Stephen,
>>
>> On 26/04/2022 00:07, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Commits
>>>
>>>    775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
>>>    c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
>>>    c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
>>>    75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")
>>>
>>> are missing a Signed-off-by from their committer.
>>>
>>
>> These patches are taken by Krysztof and merge into my tree via a tag [1] to 
>> avoid any conflicts. Please let me know if there is anything I need to do to fix 
>> this problem.
> 
> Hi Matthias,
> 
> Before you merged my branch, which was fine, but later you rebased all
> this thus making yourself committer. Commits pulled from other trees
> should in general not be rebased, because it creates duplicates - there
> are ones in my tree, and separate in yours.
> 
> Additionally, such rebase changes the author, so you need your SoB.

Minor update - you not only rebased these commits, but also kept my
branch so even in your tree they are duplicated.

> Since you already rebased it, I propose you add your own SoB to Mediatek
> patches and drop the one hisilicon (75a3c81bc634). I will do the reverse
> - drop Mediatek and keep hisilicon.

Best regards,
Krzysztof

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Krzysztof Kozlowski]

On 26/04/2022 10:48, Matthias Brugger wrote:
> Hi Stephen,
> 
> On 26/04/2022 00:07, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commits
>>
>>    775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
>>    c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
>>    c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
>>    75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")
>>
>> are missing a Signed-off-by from their committer.
>>
> 
> These patches are taken by Krysztof and merge into my tree via a tag [1] to 
> avoid any conflicts. Please let me know if there is anything I need to do to fix 
> this problem.

Hi Matthias,

Before you merged my branch, which was fine, but later you rebased all
this thus making yourself committer. Commits pulled from other trees
should in general not be rebased, because it creates duplicates - there
are ones in my tree, and separate in yours.

Additionally, such rebase changes the author, so you need your SoB.

Since you already rebased it, I propose you add your own SoB to Mediatek
patches and drop the one hisilicon (75a3c81bc634). I will do the reverse
- drop Mediatek and keep hisilicon.


Best regards,
Krzysztof

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Matthias Brugger]

Hi Stephen,

On 26/04/2022 00:07, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>    775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
>    c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
>    c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
>    75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")
> 
> are missing a Signed-off-by from their committer.
> 

These patches are taken by Krysztof and merge into my tree via a tag [1] to 
avoid any conflicts. Please let me know if there is anything I need to do to fix 
this problem.

Regards,
Matthias

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-v5.19/arm-dts64-cleanups

linux-next: Signed-off-by missing for commit in the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi all,

Commits

  775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
  c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
  c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
  75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]