linux-next: Fixes tag needs some work in the battery tree

linux-next: Fixes tag needs some work in the battery tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

Hi all,

In commit

  b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")

Fixes tag

  Fixes: 76b16f4cdfb8 ("power: supply: sbs-battery: don't assume

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  38fa8b9f75ea ("power: supply: sbs-battery: use correct flags field")

Fixes tag

  Fixes: 76b16f4cdfb8 ("power: supply: sbs-battery: don't assume

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the battery tree

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi Stephen,

On Mon, Sep 02, 2019 at 09:31:31AM +1000, Stephen Rothwell wrote:
> In commit
> 
> b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")
> 
> [...]
> 
> Please do not split Fixes tags over more than one line.

I have fixed this and rebased the branch, so the issue should be
gone tomororw. Thanks for the notice,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: linux-next: Fixes tag needs some work in the battery tree

[Michael Nosthoff]

Hi Sebastian,

I think you missed that the second commit

38fa8b9f75ea ("power: supply: sbs-battery: use correct flags field")

also needs this fix.


Regards,
Michael

On Monday, September 02, 2019 09:10 CEST, Sebastian Reichel <sre@kernel.org> wrote:

> Hi Stephen,
>
> On Mon, Sep 02, 2019 at 09:31:31AM +1000, Stephen Rothwell wrote:
> > In commit
> >
> > b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")
> >
> > [...]
> >
> > Please do not split Fixes tags over more than one line.
>
> I have fixed this and rebased the branch, so the issue should be
> gone tomororw. Thanks for the notice,
>
> -- Sebastian

Re: linux-next: Fixes tag needs some work in the battery tree

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

Hi,

On Mon, Sep 02, 2019 at 09:32:47AM +0200, Michael Nosthoff wrote:
> On Monday, September 02, 2019 09:10 CEST, Sebastian Reichel <sre@kernel.org> wrote:
> > On Mon, Sep 02, 2019 at 09:31:31AM +1000, Stephen Rothwell wrote:
> > > In commit
> > >
> > > b19aca4eb2d2 ("power: supply: sbs-battery: only return health when battery present")
> > >
> > > [...]
> > >
> > > Please do not split Fixes tags over more than one line.
> >
> > I have fixed this and rebased the branch, so the issue should be
> > gone tomororw. Thanks for the notice,
>
> I think you missed that the second commit
> 
> 38fa8b9f75ea ("power: supply: sbs-battery: use correct flags field")
> 
> also needs this fix.

Right, now also fixed.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Fixes tag needs some work in the battery tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

Hi all,

In commit

  89cfe2fc3ad4 ("power: suppy: ucs1002: Make the symbol 'ucs1002_regulator_enable' static")

Fixes tag

  Fixes: a3d70dacc727 ("power: suppy: ucs1002: disable power when maxcurrent is 0")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the battery tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

Hi all,

In commit

  f9d293364b45 ("power: supply: sbs-battery: keep error code when get_property() fails")

Fixes tag

  Fixes: c4f382930145 (power: supply: sbs-battery: don't assume i2c errors as battery disconnect)

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 395a7251dc2b ("power: supply: sbs-battery: don't assume i2c errors as battery disconnect")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the battery tree

[Ikjoon Jang]

On Mon, Oct 5, 2020 at 7:50 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   f9d293364b45 ("power: supply: sbs-battery: keep error code when get_property() fails")
>
> Fixes tag
>
>   Fixes: c4f382930145 (power: supply: sbs-battery: don't assume i2c errors as battery disconnect)
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 395a7251dc2b ("power: supply: sbs-battery: don't assume i2c errors as battery disconnect")
>

Yes, you're right. I guess I made a mistake here.
I'll send a v2 patch.

Thank you!

> --
> Cheers,
> Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the battery tree

[Ikjoon Jang]

On Tue, Oct 6, 2020 at 11:57 AM Ikjoon Jang <ikjn@chromium.org> wrote:
>
> On Mon, Oct 5, 2020 at 7:50 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> >   f9d293364b45 ("power: supply: sbs-battery: keep error code when get_property() fails")
> >
> > Fixes tag
> >
> >   Fixes: c4f382930145 (power: supply: sbs-battery: don't assume i2c errors as battery disconnect)
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 395a7251dc2b ("power: supply: sbs-battery: don't assume i2c errors as battery disconnect")
> >
>
> Yes, you're right. I guess I made a mistake here.
> I'll send a v2 patch.

Oh I'm sorry, it's from linux-next!

I found d6e24aa0bf15 ("power: supply: sbs-battery: keep error code
when get_property() fails") on sre/for-next branch
with a valid Fixes tag:

    power: supply: sbs-battery: keep error code when get_property() fails

    Commit c4f382930145 (power: supply: sbs-battery: don't assume
    i2c errors as battery disconnect) overwrites the original error code
    returned from internal functions. On such a sporadic i2c error,
    a user will get a wrong value without errors.

    Fixes: 395a7251dc2b (power: supply: sbs-battery: don't assume i2c
errors as battery disconnect)

    Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

but there is still a wrong sha-1 hash in the commit message,
Sebastian, can you please amend the commit message before merge?


>
> Thank you!
>
> > --
> > Cheers,
> > Stephen Rothwell

linux-next: Fixes tag needs some work in the battery tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Hi all,

In commit

  e1cc2d7d3868 ("power: supply: bq256xx: Fix BQ256XX_NUM_WD_VAL and bq256xx_watchdog_time[] overrun")

Fixes tag

  Fixes: 32e4978bb92 ("power: supply: bq256xx: Introduce the BQ256XX charger driver")

has these problem(s):

  - SHA1 should be at least 12 digits long

Probably not worth rebasing to fix.

Can be fixed in the future by setting core.abbrev to 12 (or more) or (for
git v2.11 or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the battery tree

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

Hi Stephen,

On Fri, Jan 15, 2021 at 06:39:35AM +1100, Stephen Rothwell wrote:
> In commit
> 
>   e1cc2d7d3868 ("power: supply: bq256xx: Fix BQ256XX_NUM_WD_VAL and bq256xx_watchdog_time[] overrun")
> 
> Fixes tag
> 
>   Fixes: 32e4978bb92 ("power: supply: bq256xx: Introduce the BQ256XX charger driver")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
> 
> Probably not worth rebasing to fix.
> 
> Can be fixed in the future by setting core.abbrev to 12 (or more) or (for
> git v2.11 or later) just making sure it is not set (or set to "auto").

Thanks for the report. I rebased and fixed this up, since there were
also Tony's incorrect fixes Tags.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]